From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AEF6A04B5; Tue, 27 Oct 2020 19:19:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2B0D2BEA; Tue, 27 Oct 2020 19:19:11 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70079.outbound.protection.outlook.com [40.107.7.79]) by dpdk.org (Postfix) with ESMTP id 8194E2BE3 for ; Tue, 27 Oct 2020 19:19:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAP85n6Yp+PMURrOUbugSewPy/Wpvt04Ma2ZCVRA9IICG0O3L6+ejRofZSFYi6WiQzdoN5pSVbTOMn3JG00EbJhsY7JyuQIJYZbS7zGokmjyyX/ZF/7PS/CfX5qSuhEYGbhGbYvBFgBdPkpV7IoVwd8ZRf2Pgdy77nQsxcLbxbBtxq0hyRts9vNLcEfjO17CRr86A3xdFYD2ELebVt6hakXTqH3wh5r+PuxcVwYe4bR8rwIV+OFFnpE08+QutbB3l5bFaZWO+fxOzqfjxAr22ifqvzkVvdvkqE1M05/CnaZch2KbEo7yp8BKb9w8np4Tu+adu94gt9fuTdloo05j0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O6cjtqcaET0WeIBKMsJBbl8g53U33NrIB3/wdUu/dMU=; b=bjfipmRCTViAxn4iPEFTt8LKNfb4yHOVil8qwjlimdVA4mmm/ARQDNCF3/gWLPk9EyMyvfowO6VdOeXLplTnj3XJQ0bnoV77lK6oE2Z8Xc8knfM7GGQ2HQ4SDRByK7XneORyV4XoHazW4H4upIAzuTcOgAsrUzi26hyeo1s6CGLQYBpPKI4iWE0wh183195pHEXcybdzbzAZxhyzXDjwUGxSzlzFrVtNT1QEkQKHknYUfMEKavUGrAD4Syaywe1RY1or/kwOTrO760CvN7kvVSQQiwltzQkszLXDEuZnZH/fFlTD4LJVgfVoKoeWi7aVgNBWAAC+N1vIXyDxumVt7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O6cjtqcaET0WeIBKMsJBbl8g53U33NrIB3/wdUu/dMU=; b=m65GCOT9ZSr/jWw1XNBlXrQF6cbqUlUo2uVt2g98WohdIAL0JYI8HaGhT5yM1AlloYlj/fe2GessYJaVyJgLqo21qLZiZe1BgGHtRGZQwDVXC4NHETlDMWzhKOTWdLdH58DMHx7kjuVp6IX1y056kNLXPRI7AfJxN4Ge4vgqUwc= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR0401MB2462.eurprd04.prod.outlook.com (2603:10a6:800:5a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 27 Oct 2020 18:19:07 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3499.018; Tue, 27 Oct 2020 18:19:07 +0000 From: Akhil Goyal To: Abhinandan Gujjar , "dev@dpdk.org" , "declan.doherty@intel.com" , "Honnappa.Nagarahalli@arm.com" , "konstantin.ananyev@intel.com" CC: "narender.vangati@intel.com" , "jerinj@marvell.com" Thread-Topic: [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8kYL4cZYB+DTUiYqx6FrV0786mrsotQ Date: Tue, 27 Oct 2020 18:19:06 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.162.226.234] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6894f97f-265b-4c99-ca57-08d87aa4caf8 x-ms-traffictypediagnostic: VI1PR0401MB2462: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RgahZqDthkYTjg8ybKAsy4QRbk9jJcNuUZpYp0M7o52c5TqCa4blqwCp8URnqmfHnNCoe6ikx8IdXZEOZTKCPrTuPvDSan5KDM0L0jhFOWFN7s8+7tUjEaF/7mGPX1Cl2vgfZ+kb3xbdtOuem3O8UQY1xLkNImXCBV/F5QJJ2lJZl3/5SYYQT0vFAZ3RymDCwx2xCtdMebE8fWFcXA8hubS/kXz7y43ehdDloXyss1bU1teHlUCasPIbfCg1+LT/5OpXlwyizcDwCddCHrRc0QQsL6iv/RWSIbqJB6ZATsdQ27Yr63NPM9PV0w1QiNNd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(376002)(136003)(39860400002)(2906002)(8676002)(4326008)(478600001)(55016002)(110136005)(54906003)(71200400001)(86362001)(44832011)(7696005)(5660300002)(26005)(316002)(66556008)(6506007)(8936002)(30864003)(66446008)(76116006)(83380400001)(66476007)(66946007)(9686003)(186003)(52536014)(33656002)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: z7fGhpb+g3YEcgrPpNaPVz9am6Mi0h6y86VK3TaPqiz+qSNEZnRHTYocNgNEHdKcgTvZa0DgSoDTU4gVpmjFgbasMe33SOCLudenY61xj0bzGiDTP3ZlKThACo3qYD7HtEk87vxS/RGt+kEqte0G2Z8Kp9CAFVxOSnSsTGTnjdnRAWnUBObJLEfHo127BauzJxGQxpMHIzvDqmVAnahTPGs4qcDAc9UM7QkmkrO7xGZhbfVO4/SY8VSta7ps2EUHrNws7Sq+Gg/B4EAIyXtUwUkuVdmbpjN7aYYK75+bd0EWfRThMG/czMiivWQ5p4k43ImXMgCUIxkXP0UFQwq4FaWwuIz3V+hJkmIO+EqQNIUfvZ5qmCzon7GAornxzHs3WSYD566pQMM4K9wIX7zUZNJQkZ2Lt1NMjTvEU21zbvOIXJM3yeTPUgUrRnF1BUEjZ7Mr1Abiy8VWplRucD12bY7CtAC52WqLR+pLTCqPU1aRsbw+fI891WegBiu8JfrDBDOwo5Gdp3yXYLd/ZjKuJnsrnBbbO12Xw48P/p2icrdil0Ch8COKYswwPzpkTfez2RAKHSktnyq3HF591jzGutoEINCj6qjIy5M5xDjo6pTbhjylAWttCyp6QyD6wpcXSyOYb44DoZmkinC8ghvQZg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6894f97f-265b-4c99-ca57-08d87aa4caf8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 18:19:06.9833 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 691IptXeVJHquMQlyJ3vHExblQia7GdPpV/NhoiuVLdZOIbS8wVLoCAV7F9+pmq4k7mHaPSuPKn5oEa5Mko9bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2462 Subject: Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, > Subject: [v4 1/3] cryptodev: support enqueue callback functions >=20 > This patch adds APIs to add/remove callback functions. The callback > function will be called for each burst of crypto ops received on a > given crypto device queue pair. >=20 > Signed-off-by: Abhinandan Gujjar > --- > config/rte_config.h | 1 + > lib/librte_cryptodev/meson.build | 2 +- > lib/librte_cryptodev/rte_cryptodev.c | 230 +++++++++++++++++++= ++++++ > lib/librte_cryptodev/rte_cryptodev.h | 158 ++++++++++++++++- > lib/librte_cryptodev/rte_cryptodev_version.map | 2 + > 5 files changed, 391 insertions(+), 2 deletions(-) >=20 > diff --git a/config/rte_config.h b/config/rte_config.h > index 03d90d7..e999d93 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -61,6 +61,7 @@ > /* cryptodev defines */ > #define RTE_CRYPTO_MAX_DEVS 64 > #define RTE_CRYPTODEV_NAME_LEN 64 > +#define RTE_CRYPTO_CALLBACKS 1 >=20 > /* compressdev defines */ > #define RTE_COMPRESS_MAX_DEVS 64 > diff --git a/lib/librte_cryptodev/meson.build b/lib/librte_cryptodev/meso= n.build > index c4c6b3b..8c5493f 100644 > --- a/lib/librte_cryptodev/meson.build > +++ b/lib/librte_cryptodev/meson.build > @@ -9,4 +9,4 @@ headers =3D files('rte_cryptodev.h', > 'rte_crypto.h', > 'rte_crypto_sym.h', > 'rte_crypto_asym.h') > -deps +=3D ['kvargs', 'mbuf'] > +deps +=3D ['kvargs', 'mbuf', 'rcu'] > diff --git a/lib/librte_cryptodev/rte_cryptodev.c > b/lib/librte_cryptodev/rte_cryptodev.c > index 3d95ac6..0880d9b 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -448,6 +448,91 @@ struct rte_cryptodev_sym_session_pool_private_data > { > return 0; > } >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > +/* spinlock for crypto device enq callbacks */ > +static rte_spinlock_t rte_cryptodev_callback_lock =3D > RTE_SPINLOCK_INITIALIZER; > + > +static void > +cryptodev_cb_cleanup(struct rte_cryptodev *dev) > +{ > + struct rte_cryptodev_cb **prev_cb, *curr_cb; > + struct rte_cryptodev_enq_cb_rcu *list; > + uint16_t qp_id; > + > + if (dev->enq_cbs =3D=3D NULL) > + return; > + > + for (qp_id =3D 0; qp_id < dev->data->nb_queue_pairs; qp_id++) { > + list =3D &dev->enq_cbs[qp_id]; > + prev_cb =3D &list->next; > + > + while (*prev_cb !=3D NULL) { > + curr_cb =3D *prev_cb; > + /* Remove the user cb from the callback list. */ > + __atomic_store_n(prev_cb, curr_cb->next, > + __ATOMIC_RELAXED); > + rte_rcu_qsbr_synchronize(list->qsbr, > + RTE_QSBR_THRID_INVALID); > + rte_free(curr_cb); > + } > + > + rte_free(list->qsbr); > + } > + > + rte_free(dev->enq_cbs); > + dev->enq_cbs =3D NULL; > +} > + > +static int > +cryptodev_cb_init(struct rte_cryptodev *dev) > +{ > + struct rte_cryptodev_enq_cb_rcu *list; > + struct rte_rcu_qsbr *qsbr; > + uint16_t qp_id; > + size_t size; > + > + /* Max thread set to 1, as one DP thread accessing a queue-pair */ > + const uint32_t max_threads =3D 1; > + > + dev->enq_cbs =3D rte_zmalloc(NULL, > + sizeof(struct rte_cryptodev_enq_cb_rcu) * > + dev->data->nb_queue_pairs, 0); > + if (dev->enq_cbs =3D=3D NULL) { > + CDEV_LOG_ERR("Failed to allocate memory for callbacks"); > + rte_errno =3D ENOMEM; > + return -1; > + } Why not return ENOMEM here? You are not using rte_errno while returning from this function, so setting it does not have any meaning. > + > + /* Create RCU QSBR variable */ > + size =3D rte_rcu_qsbr_get_memsize(max_threads); > + > + for (qp_id =3D 0; qp_id < dev->data->nb_queue_pairs; qp_id++) { > + list =3D &dev->enq_cbs[qp_id]; > + qsbr =3D rte_zmalloc(NULL, size, RTE_CACHE_LINE_SIZE); > + if (qsbr =3D=3D NULL) { > + CDEV_LOG_ERR("Failed to allocate memory for RCU on > " > + "queue_pair_id=3D%d", qp_id); > + goto cb_init_err; > + } > + > + if (rte_rcu_qsbr_init(qsbr, max_threads)) { > + CDEV_LOG_ERR("Failed to initialize for RCU on " > + "queue_pair_id=3D%d", qp_id); > + goto cb_init_err; > + } > + > + list->qsbr =3D qsbr; > + } > + > + return 0; > + > +cb_init_err: > + rte_errno =3D ENOMEM; > + cryptodev_cb_cleanup(dev); > + return -1; Same here, return -ENOMEM > + Extra line > +} > +#endif >=20 > const char * > rte_cryptodev_get_feature_name(uint64_t flag) > @@ -927,6 +1012,11 @@ struct rte_cryptodev * >=20 > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, - > ENOTSUP); >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > + cryptodev_cb_cleanup(dev); > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > +#endif > /* Setup new number of queue pairs and reconfigure device. */ > diag =3D rte_cryptodev_queue_pairs_config(dev, config->nb_queue_pairs, > config->socket_id); > @@ -936,6 +1026,15 @@ struct rte_cryptodev * > return diag; > } >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > + diag =3D cryptodev_cb_init(dev); > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > + if (diag) { > + CDEV_LOG_ERR("Callback init failed for dev_id=3D%d", dev_id); > + return -ENOMEM; > + } > +#endif > rte_cryptodev_trace_configure(dev_id, config); > return (*dev->dev_ops->dev_configure)(dev, config); > } > @@ -1136,6 +1235,137 @@ struct rte_cryptodev * > socket_id); > } >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > +struct rte_cryptodev_cb * > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + rte_cryptodev_callback_fn cb_fn, > + void *cb_arg) > +{ > + struct rte_cryptodev *dev; > + struct rte_cryptodev_enq_cb_rcu *list; > + struct rte_cryptodev_cb *cb, *tail; > + > + if (!cb_fn) > + return NULL; > + > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > + CDEV_LOG_ERR("Invalid dev_id=3D%d", dev_id); > + return NULL; > + } > + > + dev =3D &rte_crypto_devices[dev_id]; > + if (qp_id >=3D dev->data->nb_queue_pairs) { > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > + return NULL; > + } Errno is not set before above three returns. > + > + cb =3D rte_zmalloc(NULL, sizeof(*cb), 0); > + if (cb =3D=3D NULL) { > + CDEV_LOG_ERR("Failed to allocate memory for callback on " > + "dev=3D%d, queue_pair_id=3D%d", dev_id, qp_id); > + rte_errno =3D ENOMEM; > + return NULL; > + } > + > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > + > + cb->fn =3D cb_fn; > + cb->arg =3D cb_arg; > + > + /* Add the callbacks in fifo order. */ > + list =3D &dev->enq_cbs[qp_id]; > + tail =3D list->next; > + > + if (tail) { > + while (tail->next) > + tail =3D tail->next; > + /* Stores to cb->fn and cb->param should complete before > + * cb is visible to data plane. > + */ > + __atomic_store_n(&tail->next, cb, __ATOMIC_RELEASE); > + } else { > + /* Stores to cb->fn and cb->param should complete before > + * cb is visible to data plane. > + */ > + __atomic_store_n(&list->next, cb, __ATOMIC_RELEASE); > + } > + > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > + > + return cb; > +} > + > +int > +rte_cryptodev_remove_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + struct rte_cryptodev_cb *cb) > +{ > + struct rte_cryptodev *dev; > + struct rte_cryptodev_cb **prev_cb, *curr_cb; > + struct rte_cryptodev_enq_cb_rcu *list; > + int ret; > + > + ret =3D -EINVAL; No need to set EINVAL here. You are returning same value everywhere. The error numbers can be different at each exit. > + > + if (!cb) { > + CDEV_LOG_ERR("cb is NULL"); > + return ret; You should directly return -EINVAL here and in below cases as well. > + } > + > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > + CDEV_LOG_ERR("Invalid dev_id=3D%d", dev_id); > + return ret; Here return value should be -ENODEV > + } > + > + dev =3D &rte_crypto_devices[dev_id]; > + if (qp_id >=3D dev->data->nb_queue_pairs) { > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > + return ret; > + } > + > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > + if (dev->enq_cbs =3D=3D NULL) { > + CDEV_LOG_ERR("Callback not initialized"); > + goto cb_err; > + } > + > + list =3D &dev->enq_cbs[qp_id]; > + if (list =3D=3D NULL) { > + CDEV_LOG_ERR("Callback list is NULL"); > + goto cb_err; > + } > + > + if (list->qsbr =3D=3D NULL) { > + CDEV_LOG_ERR("Rcu qsbr is NULL"); > + goto cb_err; > + } > + > + prev_cb =3D &list->next; > + for (; *prev_cb !=3D NULL; prev_cb =3D &curr_cb->next) { > + curr_cb =3D *prev_cb; > + if (curr_cb =3D=3D cb) { > + /* Remove the user cb from the callback list. */ > + __atomic_store_n(prev_cb, curr_cb->next, > + __ATOMIC_RELAXED); > + ret =3D 0; > + break; > + } > + } > + > + if (!ret) { > + /* Call sync with invalid thread id as this is part of > + * control plane API > + */ > + rte_rcu_qsbr_synchronize(list->qsbr, > RTE_QSBR_THRID_INVALID); > + rte_free(cb); > + } > + > +cb_err: > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > + return ret; > +} > +#endif >=20 > int > rte_cryptodev_stats_get(uint8_t dev_id, struct rte_cryptodev_stats *stat= s) > diff --git a/lib/librte_cryptodev/rte_cryptodev.h > b/lib/librte_cryptodev/rte_cryptodev.h > index 0935fd5..1b7d7ef 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -23,6 +23,7 @@ > #include "rte_dev.h" > #include > #include > +#include >=20 > #include "rte_cryptodev_trace_fp.h" >=20 > @@ -522,6 +523,34 @@ struct rte_cryptodev_qp_conf { > /**< The mempool for creating sess private data in sessionless mode */ > }; >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > +/** > + * Function type used for pre processing crypto ops when enqueue burst i= s > + * called. > + * > + * The callback function is called on enqueue burst immediately > + * before the crypto ops are put onto the hardware queue for processing. > + * > + * @param dev_id The identifier of the device. > + * @param qp_id The index of the queue pair in which ops are > + * to be enqueued for processing. The value > + * must be in the range [0, nb_queue_pairs - 1] > + * previously supplied to > + * *rte_cryptodev_configure*. > + * @param ops The address of an array of *nb_ops* pointers > + * to *rte_crypto_op* structures which contain > + * the crypto operations to be processed. > + * @param nb_ops The number of operations to process. > + * @param user_param The arbitrary user parameter passed in by the > + * application when the callback was originally > + * registered. > + * @return The number of ops to be enqueued to the > + * crypto device. > + */ > +typedef uint16_t (*rte_cryptodev_callback_fn)(uint16_t dev_id, uint16_t = qp_id, > + struct rte_crypto_op **ops, uint16_t nb_ops, void > *user_param); > +#endif > + > /** > * Typedef for application callback function to be registered by applica= tion > * software for notification of device events > @@ -822,7 +851,6 @@ struct rte_cryptodev_config { > enum rte_cryptodev_event_type event, > rte_cryptodev_cb_fn cb_fn, void *cb_arg); >=20 > - > typedef uint16_t (*dequeue_pkt_burst_t)(void *qp, > struct rte_crypto_op **ops, uint16_t nb_ops); > /**< Dequeue processed packets from queue pair of a device. */ > @@ -839,6 +867,33 @@ typedef uint16_t (*enqueue_pkt_burst_t)(void *qp, > /** Structure to keep track of registered callbacks */ > TAILQ_HEAD(rte_cryptodev_cb_list, rte_cryptodev_callback); >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > +/** > + * @internal > + * Structure used to hold information about the callbacks to be called f= or a > + * queue pair on enqueue. > + */ > +struct rte_cryptodev_cb { > + struct rte_cryptodev_cb *next; > + /** < Pointer to next callback */ > + rte_cryptodev_callback_fn fn; > + /** < Pointer to callback function */ > + void *arg; > + /** < Pointer to argument */ > +}; > + > +/** > + * @internal > + * Structure used to hold information about the RCU for a queue pair. > + */ > +struct rte_cryptodev_enq_cb_rcu { > + struct rte_cryptodev_cb *next; > + /** < Pointer to next callback */ > + struct rte_rcu_qsbr *qsbr; > + /** < RCU QSBR variable per queue pair */ > +}; > +#endif > + > /** The data structure associated with each crypto device. */ > struct rte_cryptodev { > dequeue_pkt_burst_t dequeue_burst; > @@ -867,6 +922,10 @@ struct rte_cryptodev { > __extension__ > uint8_t attached : 1; > /**< Flag indicating the device is attached */ > + > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > + /**< User application callback for pre enqueue processing */ > + Extra line We should add support for post dequeue callbacks also. Since this is an LTS= release And we wont be very flexible in future quarterly release, we should do all = the changes In one go. I believe we should also double check with techboard if this is an ABI brea= kage. IMO, it is ABI breakage, rte_cryprodevs is part of stable APIs, but not sur= e. > } __rte_cache_aligned; >=20 > void * > @@ -989,6 +1048,31 @@ struct rte_cryptodev_data { > { > struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > + if (unlikely(dev->enq_cbs !=3D NULL)) { > + struct rte_cryptodev_enq_cb_rcu *list; > + struct rte_cryptodev_cb *cb; > + > + /* __ATOMIC_RELEASE memory order was used when the > + * call back was inserted into the list. > + * Since there is a clear dependency between loading > + * cb and cb->fn/cb->next, __ATOMIC_ACQUIRE memory order > is > + * not required. > + */ > + list =3D &dev->enq_cbs[qp_id]; > + rte_rcu_qsbr_thread_online(list->qsbr, 0); > + cb =3D __atomic_load_n(&list->next, __ATOMIC_RELAXED); > + > + while (cb !=3D NULL) { > + nb_ops =3D cb->fn(dev_id, qp_id, ops, nb_ops, > + cb->arg); > + cb =3D cb->next; > + }; > + > + rte_rcu_qsbr_thread_offline(list->qsbr, 0); > + } > +#endif > + > rte_cryptodev_trace_enqueue_burst(dev_id, qp_id, (void **)ops, > nb_ops); > return (*dev->enqueue_burst)( > dev->data->queue_pairs[qp_id], ops, nb_ops); > @@ -1730,6 +1814,78 @@ struct rte_crypto_raw_dp_ctx { > rte_cryptodev_raw_dequeue_done(struct rte_crypto_raw_dp_ctx *ctx, > uint32_t n); >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Add a user callback for a given crypto device and queue pair which wi= ll be > + * called on crypto ops enqueue. > + * > + * This API configures a function to be called for each burst of crypto = ops > + * received on a given crypto device queue pair. The return value is a p= ointer > + * that can be used later to remove the callback using > + * rte_cryptodev_remove_enq_callback(). > + * > + * Multiple functions are called in the order that they are added. Is there a limit for the number of cbs that can be added? Better to add a Comment here. > + * > + * @param dev_id The identifier of the device. > + * @param qp_id The index of the queue pair in which ops are > + * to be enqueued for processing. The value > + * must be in the range [0, nb_queue_pairs - 1] > + * previously supplied to > + * *rte_cryptodev_configure*. > + * @param cb_fn The callback function > + * @param cb_arg A generic pointer parameter which will be > passed > + * to each invocation of the callback function on > + * this crypto device and queue pair. > + * > + * @return > + * NULL on error. > + * On success, a pointer value which can later be used to remove the c= allback. > + */ > + > +__rte_experimental > +struct rte_cryptodev_cb * > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + rte_cryptodev_callback_fn cb_fn, > + void *cb_arg); > + > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Remove a user callback function for given crypto device and queue pai= r. > + * > + * This function is used to removed callbacks that were added to a crypt= o > + * device queue pair using rte_cryptodev_add_enq_callback(). > + * > + * > + * > + * @param dev_id The identifier of the device. > + * @param qp_id The index of the queue pair in which ops are > + * to be enqueued for processing. The value > + * must be in the range [0, nb_queue_pairs - 1] > + * previously supplied to > + * *rte_cryptodev_configure*. > + * @param cb Pointer to user supplied callback created via > + * rte_cryptodev_add_enq_callback(). > + * > + * @return > + * - 0: Success. Callback was removed. > + * - -EINVAL: The dev_id or the qp_id is out of range, or the callbac= k > + * is NULL or not found for the crypto device queue pair. > + */ > + > +__rte_experimental > +int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + struct rte_cryptodev_cb *cb); > + > +#endif > + > #ifdef __cplusplus > } > #endif > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > b/lib/librte_cryptodev/rte_cryptodev_version.map > index 7e4360f..5d8d6b0 100644 > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > @@ -101,6 +101,7 @@ EXPERIMENTAL { > rte_cryptodev_get_qp_status; >=20 > # added in 20.11 > + rte_cryptodev_add_enq_callback; > rte_cryptodev_configure_raw_dp_ctx; > rte_cryptodev_get_raw_dp_ctx_size; > rte_cryptodev_raw_dequeue; > @@ -109,4 +110,5 @@ EXPERIMENTAL { > rte_cryptodev_raw_enqueue; > rte_cryptodev_raw_enqueue_burst; > rte_cryptodev_raw_enqueue_done; > + rte_cryptodev_remove_enq_callback; > }; > -- > 1.9.1