From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 486D2A0351; Sat, 9 May 2020 21:05:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F99C1D659; Sat, 9 May 2020 21:05:07 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00065.outbound.protection.outlook.com [40.107.0.65]) by dpdk.org (Postfix) with ESMTP id 7E67C1D603 for ; Sat, 9 May 2020 21:05:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E70soH6f6dXlxThCk4C1hX5z7u76jovyY260l1iSJj2JHnbZWjTgt8dxgfScIErVFqxB8oKpaH3frKtbuD0dFDVmi4NiLOzmaEttGh2osAJAgK9D6kssGt/3ykwA0L2mED8IpbvpQKnmdjzop5Y5vk3DgmsphPJqi9grGY9ZjNjlVrvg3amfOnzQYZBp5QMJr6CiSnD0wF4VSgz9a9XztEbg0Y0Sl14R/2lSnUBUiqndW1zgJ1QTt97Ka19nJord9ZwS4XnOsrEPFKqq+gRHJ03UO4WU2CmjbINpgrEoOfXk7TbOg/jFO5KpJ/4tFQLLoUKSnqM09ho5RqJ8DyJA6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taX77XqMGTsDFUp+aOmaibRfkkuB7/G2hzldzBjcoG4=; b=K66/0X8Rn/+GeBZE0xezuwurvUjIdLTdMREB15Auwvq2kw1+IMD3Hn3doU0GasKn5RyG4AAzmlYafipfIFZnYHFnyqIPFXf0KHCf2jtGa8Kobe2Xjb1JBrIqKBvLMnL16X2+PkE5EnZOwEcvrCKj0+ZTVT2VHeN/Qd/sT5xCVJRFhFYAfP08guCk1ONC68uRIrdYaq1AppTXJfW4D1+9K6Y9UdnvjBLC0YKNiQXDv8TqcrdFbHhzXjB9Hm13FOtT5fjaO3qQ5ApxbcUTNZFRrhMOPmsfUnUeNvumKYwa8FFQIOykUyiBz3/3x0HKiZxp7FFHFdqh3CoxeuzXYxw32A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taX77XqMGTsDFUp+aOmaibRfkkuB7/G2hzldzBjcoG4=; b=eNTlyqeH8gM3dLRmSUtyXZz3a1KAahI9R6369Bpe66EMz3g45AEgtRI3Y39AbIPDKW9XFoOlDbULc0DfvM5vx0z5ZCZFMMAtx4bFJBH7goPGGhjv3bBh5Xk+Ag4NhbegLsIp4f7SddOUdu7pcnMwfhDNdACV+vxKpbqbWTZjWvM= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4959.eurprd04.prod.outlook.com (2603:10a6:803:5a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Sat, 9 May 2020 19:05:05 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2979.030; Sat, 9 May 2020 19:05:05 +0000 From: Akhil Goyal To: Pablo de Lara , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54 Thread-Index: AQHWF/3mcPKHIiVQ50KxnyiV7OANqKigOKxw Date: Sat, 9 May 2020 19:05:04 +0000 Message-ID: References: <1587488214-68422-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1587488214-68422-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 185f4eda-d07e-45f0-2b70-08d7f44be229 x-ms-traffictypediagnostic: VI1PR04MB4959: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pneK/3vpnJvFuH+WwOH22vadAZwEj1v/4wX0sLXVVViV43F9OpbiLRi56L/z0PYtEVkhxnBMG7KIqRUW5bbprobvFl6fUXWRqz1auLAxLnTcD3BKgfOe+UVnrpheExR0YaqatbcTYOGjiTZVYiBmXu/xVVzQZsiYGdfFTbJFev9I+hKXGRB7D8VV2tjIGTyTClA4Ah2UxhZc64b5MotWRwHqBpI1MQBzZVl9+5hIZqKYsjrVO/k4TGY7MHj1xSComs1pEPoqvD/Uhm6mUvB3G2CsV3k16cXFAnNQ0wpidPX74lM0aN54Na0eUdz1ea3O9V8rjx7L049owk4INAeaolOxbM6ZhlY0AwytpDT7Ym9+tOYzCwZhqsx/3mSaLzqgQf4RMcftmqZQx4tJLZCRS5eiJG4W1PXZWY0ZHjh5qAANsHB1DznUOiIzL0yKgsOGt5sEJEsgPOyXX3O87mr4d0Y8ppbgZ5QLHfhZ80qKkm7uxVJJ3kuVBHIr9xu1Drlm2BZzriLEbJOdc3WBXtTC2A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(33430700001)(8936002)(2906002)(52536014)(186003)(5660300002)(4744005)(478600001)(76116006)(55016002)(7696005)(33440700001)(33656002)(66946007)(71200400001)(6506007)(86362001)(26005)(66446008)(110136005)(64756008)(66476007)(44832011)(9686003)(316002)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: flpLMfgjc1S4MCFK1Wxp80sy8ZjXhiK8t3+69NRIs/HcfZzspYIqU/uJ8dzeCUivFYwfC1vVbCwS9Bcj4jviG5R4JPQtrBNLp/D6QMSle+i23yFfyw1oaoZTEfkPkJO/v/3TFpcnwMFzbnDWz3UlPvVSOjGyFWFD6BWkyiLHV1J+uV4q796zoIlIgJlSndL62DpGGprTyh6xu7ciOgnWeIMBPtw62xd3z8RHYB+fUtJG7xI+DC90kk4dq8VWMzc9ippI7UQw38WrzbzEUdcxm5RCeoMPPbV/89m2BZ9WUFUSZOTbRuKBTY5QnMpVXYkIz3p79iQIjXO6KobGyFg/Q/Vw+HNHl91k4o2Ho2P9PgdzyK1HVDizXPnkWtHIqqhCmJD6cfbU7MYFphyypKIzfZrwMoaSnaRzg5qtnAnyFGPUelIfQ9A/jYVqUurN2or2rl7jZ0/GwmRCCTL/6fBcj1MQl+BmmWHRcizIRiwxaZA= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 185f4eda-d07e-45f0-2b70-08d7f44be229 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 19:05:04.9318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HEYAQ0HyuE9b20AQbuUc7ONU2VkYVi92Ttxlo3A9PrloNHEUazAKMi31w3GflG/Nd871dqdnmC9iSMcGfBCxUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4959 Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo, > +#if IMB_VERSION_NUM >=3D IMB_VERSION(0, 53, 3) > + processed_ops =3D process_zuc_hash_op_mb(qp, ops, sessions, > + num_ops); > +#else > processed_ops =3D process_zuc_hash_op(qp, ops, sessions, > num_ops); > +#endif > break; Instead of having a separate name for process_zuc_hash_op in case of newer = IMB version, Is it not better to have same name of the function but having different def= initions for different IMB version. This way you can reduce the #ifs in the code. Regards, Akhil