From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D485A00BE; Fri, 15 May 2020 19:45:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E5441DAFD; Fri, 15 May 2020 19:45:08 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40077.outbound.protection.outlook.com [40.107.4.77]) by dpdk.org (Postfix) with ESMTP id 596A91DAE8 for ; Fri, 15 May 2020 19:45:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKl4a6uFJ8KY7xalCECnG8fsapFMUOGlQbZYq9HYFdsAMoejckVVf85/adjtf+Y9/NATRexfCiELHOu2kf/aujMg3TEf6Zo54558gneucgMa0DDEWmcJ4lIZDVRMWsfvHlHpDoIlNBJj40NknxKjPBKCDfuLbGkOS6tkIl3VWqRCsJ7flQbUCend2Q6bzSwjTXusKsq1+3I30jN+jUKJIvos1zYqpvUFAi0r097XaNtqpiehGcugw3s6t4HN65zyMInmi5Kn2ywHYqtlHxd3NzgV/Dr1FdNblmOy46dFPhCp4/eJGtauBzqxaWIeTFlE0U2SzzkzqLFSYBYZjgv4zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fQNHHbmQ97L7WaPf3ISRER7GdlIUQb8MxqWWh4BN098=; b=fb8ptfzcvqzKEyJvTZK/lFaOyC/T1TAYN1mgPe+2WLmMBcsky/rqyzi97LpUSn4dXyo2zjohrNNeChdNLgUaN4HQHRO1WrL2SLeihWYRuSkpRbfULj4ZTegZ+BiZ8iHKUNpEBgnBvEqXTULCfaLdqQNh+mjOOKyOx9i9RTt8dzsIyIqmipUyoU4/r+KHaS0+bgxNGrCpgnueilxXcC6/7VhK6odUejFnTgm6ciUtI+YKuXlgrjlb3qh7FUJ+385yJaoP4eFKSFGDH3Nlk1cThajhUhaxi3xilNuWtH6JBz/aQaELo16oG/pDkaATPxw1Wd3IETHDDLcHYyFbz0KqGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fQNHHbmQ97L7WaPf3ISRER7GdlIUQb8MxqWWh4BN098=; b=YWe/uxJ77PV7UKkT5cX42M9L9Mj9hIcly6jZGMQu23v4ldZBQiTTbjHsLYflCp9joE8aM+Dzh2yapBAAqezPp6z/xbYdNVE7iMPbopUoE6YjTeykPU2vuEavLl9LQK/42xYLs0UQB1nqjbh5qIh7J1CLa/FoXUV72m8HjcBmiys= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4143.eurprd04.prod.outlook.com (2603:10a6:803:46::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Fri, 15 May 2020 17:45:04 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2979.033; Fri, 15 May 2020 17:45:04 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , Apeksha Gupta , "dev@dpdk.org" CC: "Ruifeng.Wang@arm.com" , "Doherty, Declan" , "asomalap@amd.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "Trahe, Fiona" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "jianjay.zhou@huawei.com" , "De Lara Guarch, Pablo" , "Dybkowski, AdamX" Thread-Topic: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test Thread-Index: AQHWKp+6b0/2rXYOh0i1PyDIKP+/e6ipavyw Date: Fri, 15 May 2020 17:45:04 +0000 Message-ID: References: <20200515073242.24720-1-apeksha.gupta@nxp.com> <20200515075606.25709-1-apeksha.gupta@nxp.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.64] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 31a2db1a-54b6-458f-45ac-08d7f8f7b35c x-ms-traffictypediagnostic: VI1PR04MB4143: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04041A2886 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Od5ZtelU2L7iX6pUiRx/LggZ4nMwuT2UIiGx15aNXHVGW3om8bpLaS2uAcLYwxd8d7sdeZm6HHzN4L0Iz8tEDtGfd76MTw8zCrEvKCj0cXh8bukntEWLM86LoBVNxRvVxpl2RZCgupnWfPJffn6/62JkmpkdfgETKdc4Z+VwRXHx90hjRY7bcBcVKB6Dk0YSX/ZNuYVY03qV5gyioVKct7fBI+Mk73fd6ankN5dRvLLuSk+7Mai3urVh0mh2AtFZ6t7jnGYTjiLeLyVyPl0YlZ/4XmNdAJu0jKwpHHCpExlTBGkP8LJ6+58jbW5Q7tei6SYiUy+tHjoZYMHyOsIlSXgWW8xP5UFl3KSD0f8TJK7pfwd0T06J4YnWVVfMmy/y74/QwMJ1LOCOIlRL9ptTQDnkXzuZrY0S/Q+86qARmOoZuUPFOD/becIziv3xOI40 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(366004)(136003)(346002)(396003)(316002)(66446008)(66556008)(186003)(66476007)(76116006)(64756008)(110136005)(9686003)(66946007)(71200400001)(44832011)(33656002)(55016002)(7696005)(54906003)(7416002)(6506007)(5660300002)(26005)(4326008)(2906002)(8936002)(52536014)(86362001)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: F5zqqUUyVzg9/Px64BRepkvf+yUML++X3QvghMob/3mKFTqFbAFrrWMSX9LhT+Owxz2PWBgs6WPQhxwYoOwz1g/aBuICeNFLPlemPM6FBZzNk2BCyK4HRYiHDxQD8pWd00JdRHnsKwKQ3jI97p3iDWgDzwVEdNkcbq00dXxajwv0e2cSAxNd9ztLVzqdaC4H5uss50FTj1pCRM7CIGQj4LLRVU6cfZuag+wnB9kaBdPULXstwwZ4AB+dWwPoP//3jsnVHEO/a23rcIcTtDgvgwGmbk8dm/W0XPPtwrApLrXENoIcddyU9E+SHXuOVTJ9XBaX1a4msf5n/dVHTqbUoR+JfslhfsHzwEBRpExBP7lplmBHSs+2hjH5weVgmPNpxzeLNDyf7+lHJ+9oOV1II3SLNHh4lzumihOzZ2Uzc7GKIOsM+rHazyXnrv+Lf1ONkmgcWEx+5rbKUWm8PS4ff8XKhHey5/yQGeIgu0zwtx8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31a2db1a-54b6-458f-45ac-08d7f8f7b35c X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2020 17:45:04.5054 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2CLqb3Ed6nF29C/BJcyYGWDbAZ/Obtzf8R/UCKbUTqS69y0g17Ij0ISpSZWALOI3u6Uvo2/j8TPk10I+fSWedA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4143 Subject: Re: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, >=20 > > Test_stats is an optional cryptodev op and if it is not defined by the > > PMD, it should not run the test cases for it. > > > > Signed-off-by: Apeksha Gupta > > --- > > app/test/test_cryptodev.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index c624018ee..1ad650675 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -8801,6 +8801,10 @@ test_stats(void) > > if (gbl_action_type =3D=3D RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) > > return -ENOTSUP; > > > > + dev =3D &rte_cryptodevs[ts_params->valid_devs[0]]; > > + if (dev->dev_ops->stats_get =3D=3D 0) > > + return -ENOTSUP; > > + > > >=20 > rte_cryptodevs[] and dev_ops supposed to be internal for cryptodev > (though in practice they are not). > It is not a good practice for the app to access them directly. >=20 Yes, you are absolutely correct. The test case is not properly written. App should not access the dev_ops directly. Apeksha, You can do the following change to fix this. diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 1ed2df898..aa14d42fa 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -8751,7 +8751,6 @@ test_stats(void) struct crypto_testsuite_params *ts_params =3D &testsuite_params; struct rte_cryptodev_stats stats; struct rte_cryptodev *dev; - cryptodev_stats_get_t temp_pfn; if (gbl_action_type =3D=3D RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) return -ENOTSUP; @@ -8769,19 +8768,16 @@ test_stats(void) &cap_idx) =3D=3D NULL) return -ENOTSUP; + if (rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats) + =3D=3D -ENOTSUP) + return -ENOTSUP; + rte_cryptodev_stats_reset(ts_params->valid_devs[0]); TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0] + 600= , &stats) =3D=3D -ENODEV), "rte_cryptodev_stats_get invalid dev failed"); TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], 0) != =3D 0), "rte_cryptodev_stats_get invalid Param failed"); - dev =3D &rte_cryptodevs[ts_params->valid_devs[0]]; - temp_pfn =3D dev->dev_ops->stats_get; - dev->dev_ops->stats_get =3D (cryptodev_stats_get_t)0; - TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], &sta= ts) - =3D=3D -ENOTSUP), - "rte_cryptodev_stats_get invalid Param failed"); - dev->dev_ops->stats_get =3D temp_pfn; /* Test expected values */ ut_setup();