From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD2FCA00C5; Thu, 2 Jul 2020 12:36:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAA151D8E0; Thu, 2 Jul 2020 12:36:25 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00084.outbound.protection.outlook.com [40.107.0.84]) by dpdk.org (Postfix) with ESMTP id 2F5281D8DB for ; Thu, 2 Jul 2020 12:36:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Btv5ggnTDEDHIYchGv2/JNL++9XEwL4KtFH9Ao3zWw7Qsy5RKqNtB5hpJfl4QQS9sbecbNb9m8eFCBAUeMvVTGOJFDM3uvUeX8JP0dhJFOmaHN/8kFDWoOjmy4DF+Vw8OpGcZP5KS5FiedQ32XN7h/xa8FupZKG60FWJ8n+euesXN14dJu05rTJrmil2FjMcftp3wm+/DSxSIZjrsu1ZQ7P033o/YKSmIdixBJ7o3CWtLsxOQS5MoK5QhcJTP+f6+m9Whg1ZOxMsuQX9mBO3WO+fn6FwgfpJirP/GNZPUgcosHNgYQtz2CcVWiU5eHL7qZ+BUGBc8LWyR5eynw7kqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMHaQiu36JtCAQzE5qZG4TYgalnDX1fd6kmMJXjd+oU=; b=OoE1ew3w64b/WJQx08mxmJ23t9R5/bnab2CDaHA1kRFXpuuPykILCnNTFWKPjLCAEzAKzPE5j/vhy92A4VuwQgWh1uqHoSh4iM4i7NQHfd6PFPQGAiZ5CFUXaee4vc6XeDedErfcHes9dj+bPvGqTQ6oQPuIbMNJHrgoZ+NDNg438FO0uHFwewnuMXDRi3WDSQpEzrThmUpevqOqdU/THhxPt3Dku4uM27NQRQTRmrIuKOXspQHLbQp4hyTGptsvprhjHRat0sm14EW5+dtFM53/MDwQRb/CCj43uXU4pUCNu0GdOj6CW12+8RmIUdZIlkoGi9iVEQNCewpdgns5DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMHaQiu36JtCAQzE5qZG4TYgalnDX1fd6kmMJXjd+oU=; b=FnyC291H/Uba4ocwbtdWL5wxuPZoZZ8O1D15KbrRG6s07RhFXSsZTxd43to9LCDdhlQ5O4/l2Hjz8RwmmPghwqJX2tnpRzXif/dKHncsVSGrGZgOT+719OwbFGlCXBGCVOfVfQ8N+VwV1QfxE+Dlog0kL7KHgj/W86PZpRFig6k= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB3165.eurprd04.prod.outlook.com (2603:10a6:802:a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Thu, 2 Jul 2020 10:36:23 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3131.035; Thu, 2 Jul 2020 10:36:23 +0000 From: Akhil Goyal To: Tejasree Kondoj , Radu Nicolau CC: Narayana Prasad Raju Athreya , Anoob Joseph , Vamsi Krishna Attunuru , "dev@dpdk.org" Thread-Topic: [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities Thread-Index: AQHWSVAlTVqjWHzGK0WL9/77Bl5Kh6jzQ4QQgADh5oCAAAEPMA== Date: Thu, 2 Jul 2020 10:36:22 +0000 Message-ID: References: <20200623121228.10355-1-ktejasree@marvell.com> <20200623121228.10355-5-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.91] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 598857f5-aa78-4c04-7545-08d81e73c3f2 x-ms-traffictypediagnostic: VI1PR04MB3165: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RHI1r6Mh4IBIP1d5chyEbY8Xcqqixxz4fIjV9NJ6WSbf4hVX7XloNX7uhv/Z3yLySzkNWjL0r3Ny2/Nc82LoWPmeYQai2tJlTENE3B5A+9El2z1/CAFL36fw3zaOadp96U/YrOGtpGPMykaE9/L/ssTle6UbRKgzvXt0wiSXCdF7V3stB11p9qa+3kmcVJafCITwTAuM8O13wTLOkIjdxsRyQEjW6dGYUW3PhznxsxakQLloEFVQNKETC4roU4pQxsRLDrgwhxgOc9Vpn++/NTm8yRhzHH4Mg0TK8NSlgiguiY1PdHssP04OCK+4JCTdPK8U2GOb+qs0CJ3Zzp641w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(54906003)(26005)(44832011)(186003)(316002)(7696005)(110136005)(86362001)(2906002)(52536014)(6506007)(5660300002)(83380400001)(4326008)(4744005)(71200400001)(478600001)(8676002)(8936002)(66446008)(33656002)(66946007)(66476007)(66556008)(64756008)(76116006)(9686003)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: FwEJt8VO8y5H8a77YB7pUELFBd7m0+zpUBNL6sbUu+wL+cSEVlwFO69SmueYA39g1giJbbgIm3BCqIqtb6mjAuzlZ1GbxoTMDNW7D+4gf5iFFG5mljkpU4EDorEd4qjvavIjhQ5OUrokhbC4+ruWT7nwm8EZpOxeo1McK5I+b1z4FqphQ8Xaa/h1n5Uff+ywuka31RcHWwJrRmRVt2rj7SKRhnZbZzV3uWWtmb2vokMzEeCW6grYzZeHREOWtHpSw1AYPCjex38l1ZH1vaUikEJKVqWmfzDp8UnB+1WKGmusewGKItLms7yALW4yGsPGzoQSW002DVRxeRIov/89lu223KCdUmcOvFPde0fkoY61tSlGSpBI/q6UwRlzrcxON0NEnKYOEISpwluwB9WPuTUrsiMlc90kbk5A5ulp9CXRb8IdtgZiiBl0lbNZi3stEMcRPg5NwF0lZ1jePILAk343mSpSM0lN8BWix8BYsH8bHPBjGg2s0lWzIjrq3Hxy x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 598857f5-aa78-4c04-7545-08d81e73c3f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 10:36:22.9065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pGSpW97TqxpyF+SMqAA8injcRPBEQiSGKj3SVF/+lyN9s9fVdEsf+8XbqDFkokxjjOCnZcrLi2XpNQCuGHJutA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3165 Subject: Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > +static const struct rte_cryptodev_capabilities * > > > +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps) { > > > + SEC_CAPS_ADD(hw_caps, aes); > > > + > > > + sec_caps_add(caps_end, RTE_DIM(caps_end)); > > > + > > > + return otx2_cpt_sec_caps; > > > +} > > SEC_CAPS_ADD should be called earlier when the security context is crea= ted > > Or where all other capabilities of the PMD are initialized. > > It should not be added when capabilities need to be retrieved. > > As of now you are supporting only AES-GCM, but in future if you add mor= e > > algos, Then it would be difficult to manage. > [Tejasree] We will initialize capabilities during probe and capabilities= _get() > would return pointer. Would that work? Yes, I think so.