DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Ankur Dwivedi <adwivedi@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "declan.doherty@intel.com" <declan.doherty@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Vakul Garg <vakul.garg@nxp.com>,
	Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector
Date: Mon, 6 Jul 2020 18:54:09 +0000	[thread overview]
Message-ID: <VI1PR04MB3168E886C7274EB964633CD2E6690@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DM5PR1801MB18846D927A48EDFAF0196518DD690@DM5PR1801MB1884.namprd18.prod.outlook.com>

> >Why do we need this change?
> >The existing test case is to demonstrate a generic case where we can have an
> >auth only trailer as well. It is similar to a case of IPSEC ESN but not exactly
> >IPSec. Cipher offset can be anything as per the app requirement.
> >I don't think there is anything wrong in the vector. It should pass in every
> >hardware without any issue.
> [Ankur] It's a limitation in OCTEON TX PMDs that the (encr offset - auth offset)
> should be 8 bytes aligned.
> In the IPSEC ESN scenario generally the offsets will be such.
> But in the above IPSEC ESN test vector, this requirement is not met and hence
> the associated test cases fails on the PMD.

In that case, I think it is better to have a separate test vector and both should
be executed. With the previous one as not supported in your case and this
one will be supported.


  reply	other threads:[~2020-07-06 18:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  8:30 Ankur Dwivedi
2020-06-30 14:15 ` Ankur Dwivedi
2020-07-06 12:23 ` Akhil Goyal
2020-07-06 15:03   ` Ankur Dwivedi
2020-07-06 18:54     ` Akhil Goyal [this message]
2020-07-07  6:07       ` Ankur Dwivedi
2020-07-07 19:20         ` Akhil Goyal
2020-07-08  9:51           ` Anoob Joseph
2020-07-14  7:52             ` Anoob Joseph
2020-07-15 19:54             ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB3168E886C7274EB964633CD2E6690@VI1PR04MB3168.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=adwivedi@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=vakul.garg@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).