DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	"Vangati, Narender" <narender.vangati@intel.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions
Date: Tue, 3 Nov 2020 16:53:06 +0000
Message-ID: <VI1PR04MB3168EB38F24B7442F52B7344E6110@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB183841C190DF493D6374A823E8110@MWHPR11MB1838.namprd11.prod.outlook.com>

Hi Abhinandan,
> 
> Hi Thomas,
> 
> >
> > 03/11/2020 08:44, Gujjar, Abhinandan S:
> > > From: Akhil Goyal <akhil.goyal@nxp.com>
> > > > As I suggested 2 times that there are documentation issues. Haven't
> > > > seen a version To fix that. Please check it at your end and try
> > > > fixing the timing of your system so that CI Can pick it for compilation.
> > >
> > > As far as I remember, I have pulled in all the comments from you for the
> > previous patch.
> > > >
> > > > > I understand that we work in same time zone, getting feedback from
> > > > > you in the mid night will not help me/you to pull this patch in.
> > > > > A quick response will enable me to prepare patch set quickly and
> > > > > send it
> > > > across.
> > > >
> > > > I am not dedicatedly working on your patchset. I will work as per my
> > priorities.
> > >
> > > It is same for me. End of the day, we have mutually agreed to get this
> feature
> > in.
> > >
> > > > Had it been a CI pass for compilation for both documentation and
> > > > code, it would have been applied last night. I could remove those
> > > > extra spaces, but there are other issues also as the newly added
> > > > APIs are not visible in html files generated. Please ensure that
> > > > there are no issues in doxygen build issues and should be able to see the
> > newly added APIs in html guides.
> > >
> > > This is the kind of information I was looking for, which was not
> > > available in your previous patch. If this info had been available quickly, I
> > would have prepared next patchset.
> >
> > It seems you didn't do all the checks you are required to do.
> > Please be kind with Akhil who is working hard for the community.
> > If you want to accelerate the process, help by reviewing other patches.
> >
> I have done enough follow ups with Akhil and we both agreed to get this into
> RC2.
> I did not realize that CI did not pick up the patches because of mismatch with my
> system time.
> All I am saying is giving this information would have helped me.

I highlighted the documentation issue and the system timing on Friday itself.
When the fix was not there on Monday, I tried to fix on my side which took me late
To comment back. Had it been done by CI, it would have been faster.

> 
> > > Anyway, I will post the next patch set.
> >
> > This is too late.
> > We are not supposed to add new API in -rc2, and for sure not after -rc2
> > deadline.
> >
> > > >
> > > > And please note, do not top post your comments. It becomes difficult
> > > > to read it in Archives.
> > >
> > > Ok
> >
> > Yes please do not top post, use --in-reply-to to gather all versions in the same
> > thread, and fix the clock of your machine.
> Ok
> >
> >


  reply	other threads:[~2020-11-03 16:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 23:10 [dpdk-dev] [v6 0/2] support enqueue & dequeue callbacks on cryptodev Abhinandan Gujjar
2020-10-28 23:10 ` [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions Abhinandan Gujjar
2020-10-30 18:28   ` Akhil Goyal
2020-10-30 18:36     ` Gujjar, Abhinandan S
2020-11-02  9:37       ` Gujjar, Abhinandan S
2020-11-02 18:57         ` Akhil Goyal
2020-11-03  5:50           ` Gujjar, Abhinandan S
2020-11-03  6:28             ` Akhil Goyal
2020-11-03  7:44               ` Gujjar, Abhinandan S
2020-11-03 16:04                 ` Thomas Monjalon
2020-11-03 16:37                   ` Gujjar, Abhinandan S
2020-11-03 16:53                     ` Akhil Goyal [this message]
2020-11-03 17:03                       ` Gujjar, Abhinandan S
2020-11-03 17:07                         ` Akhil Goyal
2020-10-28 23:10 ` [dpdk-dev] [v6 2/2] test: add testcase for crypto enqueue callback Abhinandan Gujjar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB3168EB38F24B7442F52B7344E6110@VI1PR04MB3168.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=narender.vangati@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git