From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FFC4A0548; Sat, 18 Jul 2020 23:24:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 787221BFB8; Sat, 18 Jul 2020 23:24:54 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by dpdk.org (Postfix) with ESMTP id D27FA1BFA9 for ; Sat, 18 Jul 2020 23:24:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ePooczAvVcCX3Ffo7oRXJxLxFkMYI0ULSoSErwZ6Uq0gE3Gd6c/MMuJsgIYZ6rHN9X5eETOLCye65ucjykdc+AH3zD7HzL2D1T6TvKB3TZawTtXJXcmrST6YBzFipqFGdgEoxuT12bqQrt43CpilJzNfxxtvkyyyuQfyYJD2+oEaMRkYsNtVbu7A7KclHk/27Mjqd7t2h8s0gQ20+O+RZDAVVh+gfivqI4LmBN63zfEIMXrqJc2++FpunY3M0pmtuhMJUEDN6iXNNQ50+GoDASx5nGc/Or1p3bUslkLlcEQgKrgzQLkFM20dYOiJTnnD9CL61Kp8RIwVzycqYhCu1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hHszFuTaeS3SV8VewRCttvXibJeqrK0vKZgwxWGB4mc=; b=PLCjmZB2fhNlr8WY32npA1jrS7K6EDlF0klt7KkEcBFox1xyWSSlUc6p5mB6LHyKsvYVxj5U8UEVH3PonupPE6TYUMVPJWMYp3pLnf1UzzinQFvV3qOew5qp0OJmmAAslaYmzub88hbSOZM/f7snAYvtft7+VgmkHKYtS83zvjGPEjwABADCrL/6HdPCBW6JDy85eVHf83TzWbIURuWPjmUx1u3Fjje6PbZ0ExOFiE+/RHxz9c8r+eBj6sqDpgJeElw5X5hH4BS/Mw0f/eT64/zc++dSnWn5lVkC/iIXSAiMnuwuzcfrkTtS7Z0BtoCw5RddOQZVodIAvfZpAJJC8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hHszFuTaeS3SV8VewRCttvXibJeqrK0vKZgwxWGB4mc=; b=nE01KakhVr/c7+nzOnSxLWz6iIuXKJ5HVezdovi0w9Z4FqXamX0cGImIRMX4kdDDJuRfdLobn5iOzk+ob5eb54A2Oyt24zxTW9r80ZDUBvDlhLSzr+bCMfLkX7VN2/lzct1htdPZKfhLrjKBAtVFDwbOpOeM85EXnLGQNyYrmp0= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5838.eurprd04.prod.outlook.com (2603:10a6:803:ea::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Sat, 18 Jul 2020 21:24:51 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3174.029; Sat, 18 Jul 2020 21:24:51 +0000 From: Akhil Goyal To: "De Lara Guarch, Pablo" , "Coyle, David" , "Doherty, Declan" , "Trahe, Fiona" CC: "dev@dpdk.org" , "Ryan, Brendan" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v1 2/2] crypto/aesni_mb: improve DOCSIS session creation Thread-Index: AQHWW4mthGVh843ZJUqJlta7Q1n6DKkMJHCAgAG4CnA= Date: Sat, 18 Jul 2020 21:24:51 +0000 Message-ID: References: <20200716153218.65491-1-david.coyle@intel.com> <20200716153218.65491-3-david.coyle@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.166.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ba245457-eb99-4fda-aff2-08d82b6101c8 x-ms-traffictypediagnostic: VI1PR04MB5838: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Bsh84Bho5Ih/XARlXe/cHknk2v0x9XMz7W+OUo+sn+lvuNk82ZlLe1ZbOxOTmqyLbG4GY1mI6XdQxv77fp7YjYIG1PZ6whtlxTJP2zy4gP3rN41FiGDuG1cIZrwLts9ewlMDrOKHtkqMdx5TMDn64xNYLkZ9Na0nGRULWq+4qPSTVSKh2jDRHkzq7be7/Qnc1XqRa2lf4TeBNF/HY4HjybwyozcnHb6Ol8Cxo7DWMtO8by6kxa5NZvcUKfs5B9g1Ur8nx6M5qsZ5UUPKBTgxOJ22y/NBV1V3TI3I8JrCnY7TvyUqNQ5BJEe58fRNG+FNNHbVnbpNkJXPmTvHF/ghig== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(396003)(346002)(376002)(366004)(136003)(52536014)(2906002)(7696005)(4744005)(54906003)(8676002)(110136005)(316002)(5660300002)(9686003)(55016002)(478600001)(83380400001)(33656002)(66476007)(66946007)(86362001)(44832011)(26005)(8936002)(6506007)(186003)(4326008)(76116006)(66556008)(64756008)(71200400001)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: KL56yRInIA4oGZlUHqLyMQAHjb+/ri+1tJc+gyopawjSgP3drVA1oyo2W6ENnjVSaJRfodU6SPfFTi8/UldvQCAe5C724vMKUyVJ7WpyqbMBo7apX7rYbq4NdC/AdNfJ193Sr7EGMGUgUaatp2vXAjk7MJEnKvEvcACrwGjHzGoLPpHeco+FsZ4SKHRcQkbBcS0xV+NV8wwJAvS8AAOf3CqLKSdlXJJ4nzAy2sKz8Aon+irRI9sExPAlnvVnSeSDhIjKNQdEGmUD4rbzW46CUZOCMyr3ggklakTnrEnqDNTMQ5VuZgxzh2s/Woot9hzubyriOR1OfgklJC+uRteuNbdKHY27t/c0LSE5bdm232tkIBeQUxjQtZxmAlx07TFHleAVRsBKO/8XP+e3AIAe/tM+ZGjPAZT+PH3iH2C2qKSYVd9WhFjnswaROvqIdOGt/tqAg0OCJsIcqQ/t+aQros9XZyNYkPqWeAXYiN1xIOw= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba245457-eb99-4fda-aff2-08d82b6101c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2020 21:24:51.3557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BQ6WFQLazp+5N7Rpqqg6UF52rJZjS6xIcw/fkKSGXa5phKTmc3YgwtuyxcxM87Mp0k0b+J8IFLXvxyZOgAg+Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5838 Subject: Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_mb: improve DOCSIS session creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > This patch improves the DOCSIS session creation as follows: > > - it validates the security action type as well as the protocol before > > creating a session and now does this validation before allocating the > > session from the mempool > > > > Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") > > > > Signed-off-by: David Coyle >=20 > Nice, this is actually fixing a potential memory leak, so you could menti= on this in > the commit message/title. >=20 > Apart from this: >=20 > Acked-by: Pablo de Lara Series applied to dpdk-next-crypto Title updated as " crypto/aesni_mb: fix memory leak in DOCSIS session" Thanks.