* [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove unnecessary NULL check
@ 2020-03-31 10:22 wangyunjian
2020-04-15 18:17 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2020-03-31 10:22 UTC (permalink / raw)
To: dev; +Cc: akhil.goyal, hemant.agrawal, jerry.lilijun, xudingke, Yunjian Wang
From: Yunjian Wang <wangyunjian@huawei.com>
This NULL check is unnecessary, container_of is never NULL.
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 6ed2701ab..4d3b93cdd 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -3729,10 +3729,6 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)
PMD_INIT_FUNC_TRACE();
dpaa2_dev = container_of(dev, struct rte_dpaa2_device, device);
- if (dpaa2_dev == NULL) {
- DPAA2_SEC_ERR("DPAA2 SEC device not found");
- return -1;
- }
hw_id = dpaa2_dev->object_id;
cryptodev->driver_id = cryptodev_driver_id;
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove unnecessary NULL check
2020-03-31 10:22 [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove unnecessary NULL check wangyunjian
@ 2020-04-15 18:17 ` Akhil Goyal
2020-04-17 21:03 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2020-04-15 18:17 UTC (permalink / raw)
To: wangyunjian, dev; +Cc: Hemant Agrawal, jerry.lilijun, xudingke
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This NULL check is unnecessary, container_of is never NULL.
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove unnecessary NULL check
2020-04-15 18:17 ` Akhil Goyal
@ 2020-04-17 21:03 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2020-04-17 21:03 UTC (permalink / raw)
To: Akhil Goyal, wangyunjian, dev; +Cc: Hemant Agrawal, jerry.lilijun, xudingke
> >
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > This NULL check is unnecessary, container_of is never NULL.
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-17 21:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 10:22 [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove unnecessary NULL check wangyunjian
2020-04-15 18:17 ` Akhil Goyal
2020-04-17 21:03 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).