From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16C81A0093; Sun, 17 May 2020 16:09:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92BBC1D579; Sun, 17 May 2020 16:09:09 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80089.outbound.protection.outlook.com [40.107.8.89]) by dpdk.org (Postfix) with ESMTP id 355131D577 for ; Sun, 17 May 2020 16:09:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqhd/tqRsJq9gRUXDRHkgYoiuLSiI/fWgvhQUOZFytDt8skXIaq9j+G2v0h4LWRKuVvs5BI7TZmokBc41AaLBZOPuwE1oNKQti6ePswC58bxKHGFwWuwrWTlhONr8iz8Rl64MuPupcv3zLa7E4jf6nKAMzHmZqYvdFB4gvbujwyBs72pGmqFBDNg349GSANBUdLMomx9RBbvO6iVfvl068ASoN3mIQ1/dNDnIM8PcyruxpQnAu+UMekgyd85ekDNQASdw4OySGIqUd1TohWECo7m4vIFX1wNjkYtSqcJS6RXuk8mupbdG3tt8xps+Xpwk4DU0K7egIZcsZ9y6H6RjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dbu+cMPUwDxNKeV0H4ZpUfawPwqrSNNKiJS0vSJjE4Q=; b=KKIkcyt6Vzx9qE2EYnhK61SNoTauDXpLMaZfrm4YZG+RzvUhp9sW+uigk+kUPIwjr8VwNDDKw4j1D9rHavH/AKsbHZk2z+LRglp71WKo/6d4/t+AcouiBAZfAQXD5WmX4eH7ek8qE+jNuH1vH0z2DwcxMcqGtxUZGkK54qehA+nwVD6gXLSlo03Hjqfz7k8lUsrqF+NoJ9Weqx28tdEeZK78Z/huZP8rQetKDPduOytuFSBNaRS3/Yl+L6tnBykbFDrbg70Fe1Eck6uBsRLi9nJkSc/iANlj7WdSzAbFn7jx66l3gT49jlvVbAUFz3Vq5kQd5VQ9gIAaWtyGLzNeiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dbu+cMPUwDxNKeV0H4ZpUfawPwqrSNNKiJS0vSJjE4Q=; b=N6H8GqPu+tXtcG05gVgjCuqgMasrVogvNXG3MZ26APNfctOcjlxz4ocWwXqlYcvq6WQW8xvsG2EYhYbJHzUTCxRNd8ZEoH7cbcw0/U1M6q5IZk6rGFI55qwXekkJXIIzDWm6WdpBH5OBXzhfWP+Em+vaZqsoESLP2Bs+OQgbNIo= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4957.eurprd04.prod.outlook.com (2603:10a6:803:51::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Sun, 17 May 2020 14:09:06 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2979.033; Sun, 17 May 2020 14:09:05 +0000 From: Akhil Goyal To: Apeksha Gupta , "dev@dpdk.org" CC: "Ruifeng.Wang@arm.com" , "declan.doherty@intel.com" , "asomalap@amd.com" , "anoobj@marvell.com" , "roy.fan.zhang@intel.com" , "fiona.trahe@intel.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "jianjay.zhou@huawei.com" , "pablo.de.lara.guarch@intel.com" , "adamx.dybkowski@intel.com" , Apeksha Gupta Thread-Topic: [PATCH v4] Test/crypto: check valid test_stats before running test Thread-Index: AQHWKyUWlq+KLuFGo0+UmfpmtHq1u6isUpXA Date: Sun, 17 May 2020 14:09:05 +0000 Message-ID: References: <20200515075606.25709-1-apeksha.gupta@nxp.com> <20200516015514.8773-1-apeksha.gupta@nxp.com> In-Reply-To: <20200516015514.8773-1-apeksha.gupta@nxp.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.80] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3af094f6-f099-477e-710e-08d7fa6bdc39 x-ms-traffictypediagnostic: VI1PR04MB4957: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 040655413E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qQzWukdMuABjNtRCQXzugObCYwEinOEwDftv77Vug9gGwdlCqmShvsG0eayg1YAaz3f+s0V+LKtwamGMyEtNc7xjg9H4ygfPmebpxLnJh276oQZ5GIFCzdCE0cUl0IndyOcylaE0ra241xqnpa11i7r2xwAXBQSTRMOWsQTesfIBvEQDpNtIZOJIQDR8DVc/IKqFYwcTg74rdJJAlfe9HEpL2JLpHYNF8gQnfkkaeEbwhK9Ic0+2g3ux1xYCqUsmEXhT8aeoWkbvVIX2L0/wpbv2clr/iKMOy1jm8B2iYrGKI+uC/szuRm72KoHP3d7KZSeNiKdXN31EvCvuli1DOfom8EZ6g8CUNZJl+soB24b8j7SJjldom/9/Za86HHGyri3tli/J4NtjnYtcs2g8cVtewzX3+LStku7pQWjQocixixgi1uS8LMPK6Lh5sSN7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(4326008)(44832011)(33656002)(55016002)(9686003)(8676002)(6506007)(8936002)(26005)(5660300002)(2906002)(7696005)(4744005)(52536014)(7416002)(66946007)(478600001)(76116006)(54906003)(86362001)(66446008)(66476007)(110136005)(316002)(186003)(71200400001)(66556008)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: PsseHzPvm6UDXb/FoE8frZCRzJh9bm8p+nayGfTaAxjAt8399P7QKxfWQXSyaBizKVjUwwhEueX/LlGFuX5EA4q7dHpTcHIuk0NhR622Bf5uDYg/jnN9lULnnmHqC/iE/Liap2zZeZAgjLsj/9VG0VBydioYtnI1ysqLj/LgDov5+TO/QhVdvBolG9Dq0TymzIG/mDPUJz91t6oDeWum4w2wJ8mN80AyYiYFmJ2mo/OEu6uutW5UYHnGNWSbJFSC19b1ztwGwS0TGtD/y9KPergKZUIEVs/5Wld0NrOO4TacMbqICdQl6e5I83RF3UEKoa2k3oBsVig6b6NDOXNYndKlInoZSBnLZpZby5OqGg3CIwnSrAVK0xoT16U2eF9fntILRKqyxQit7Gxmz0LGB2B428YLEaeRxYPhN+T/BKwuv8cPp7L8RJn79N9fuSRBK6pdww+wwZ2J9306xD2mle9w+TqSVWhsqe6UsFrA5lU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3af094f6-f099-477e-710e-08d7fa6bdc39 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2020 14:09:05.8511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7VM4LvcQEI+uH5k9Yn1+qza56/H6xA9hYwwJHZno5akT8vHfvfdEZnaeruHYfim77PxNuVk0ARFJp34xyfe9RA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4957 Subject: Re: [dpdk-dev] [PATCH v4] Test/crypto: check valid test_stats before running test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Test_stats is an optional cryptodev op and if it is not defined by the > PMD, it should not run the test cases for it. >=20 > Signed-off-by: Apeksha Gupta > --- Acked-by: Akhil Goyal Title and description of the patch updated as test/crypto: fix statistics case The test case - test_stats is directly accessing the cryptodev and its dev_ops which are internal to library and should not be used directly by the application. However, the test case is also missing to check for the error ENOTSUP. It should skip the case if the API returns ENOTSUP. This patch fixes these two issues. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance test= s") Cc: stable@dpdk.org Signed-off-by: Apeksha Gupta Applied to dpdk-next-crypto. Thanks.