DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Fredrik A Lindgren" <Fredrik.a.Lindgren@tietoevry.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] Question: typedef of eventdev_info_get_t bug?
Date: Mon, 1 Feb 2021 09:21:46 +0000	[thread overview]
Message-ID: <VI1PR04MB430314C777B3063DC85B4C4AC3B69@VI1PR04MB4303.eurprd04.prod.outlook.com> (raw)

While debugging a driver I was looking at the code and realized that eventdev_info_get_t typedef is defined with void return value but documentation for it says it should return 0

lib/librte_eventdev/eventdev_pmd.h:

...
* @return
*   Returns 0 on success
*/
typedef void (*eventdev_info_get_t)(struct rte_eventdev *dev,
                                                          struct rte_event_dev_info *dev_info);
...
struct rte_eventdev_ops {
                             eventdev_info_get_t dev_infos_get;              /**< Get device info. */
...

While return value from it is used in lib/librte_ethdev/rte_ethdev.c:

int
rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info)
...
   diag = (*dev->dev_ops->dev_infos_get)(dev, dev_info);
   if (diag != 0) {
...


Driver I'm debugging doesn't have any return statement in it's dev_infos_get function which seems to cause it to have "result" of last operation done in that function as return value.
Though this behavior may be compiler specific but it should probably be clarified and updated (change prototype of stop using return value) to avoid issue with it.

Br,
Fredrik

             reply	other threads:[~2021-02-01  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01  9:21 Fredrik A Lindgren [this message]
2021-02-01  9:44 ` Van Haaren, Harry
2021-02-01 10:02   ` Fredrik A Lindgren
2021-02-01 10:31     ` Van Haaren, Harry
2021-02-01 12:49       ` Fredrik A Lindgren
2021-02-01 13:23         ` Van Haaren, Harry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB430314C777B3063DC85B4C4AC3B69@VI1PR04MB4303.eurprd04.prod.outlook.com \
    --to=fredrik.a.lindgren@tietoevry.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).