Re: [dpdk-dev] [EXT] [PATCH 2/2] examples/l3fwd: support multiple queues in event mode

[Nipun Gupta <nipun.gupta@nxp.com>]

> -----Original Message-----
> From: Sunil Kumar Kori <skori@marvell.com>
> Sent: Monday, January 6, 2020 11:39 AM
> To: Nipun Gupta <nipun.gupta@nxp.com>; dev@dpdk.org
> Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Akhil Goyal <akhil.goyal@nxp.com>;
> marko.kovacevic@intel.com; orika@mellanox.com;
> bruce.richardson@intel.com; radu.nicolau@intel.com;
> tomasz.kantecki@intel.com
> Subject: RE: [EXT] [PATCH 2/2] examples/l3fwd: support multiple queues in
> event mode
> 
> 
> 
> Regards
> Sunil Kumar Kori
> 
> >-----Original Message-----
> >From: Nipun Gupta <nipun.gupta@nxp.com>
> >Sent: Monday, January 6, 2020 10:05 AM
> >To: dev@dpdk.org
> >Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> >Kollanukkaran <jerinj@marvell.com>; hemant.agrawal@nxp.com;
> >akhil.goyal@nxp.com; marko.kovacevic@intel.com; orika@mellanox.com;
> >bruce.richardson@intel.com; radu.nicolau@intel.com;
> >tomasz.kantecki@intel.com; Sunil Kumar Kori <skori@marvell.com>; Nipun
> >Gupta <nipun.gupta@nxp.com>
> >Subject: [EXT] [PATCH 2/2] examples/l3fwd: support multiple queues in event
> >mode
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> >---
> > examples/l3fwd/l3fwd_event.c | 55 ++++++++++++++++++++++++++++--------
> > examples/l3fwd/l3fwd_event.h |  4 +++
> > examples/l3fwd/main.c        |  8 ++++--
> > 3 files changed, 53 insertions(+), 14 deletions(-)
> >
> >diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index
> >68998f42c..ecfaca435 100644
> >--- a/examples/l3fwd/main.c
> >+++ b/examples/l3fwd/main.c
> >@@ -285,7 +285,8 @@ print_usage(const char *prgname)
> > 		" [--parse-ptype]"
> > 		" [--per-port-pool]"
> > 		" [--mode]"
> >-		" [--eventq-sched]\n\n"
> >+		" [--eventq-sched]"
> >+		" [--event-eth-queues]\n\n"
> >
> > 		"  -p PORTMASK: Hexadecimal bitmask of ports to
> >configure\n"
> > 		"  -P : Enable promiscuous mode\n"
> >@@ -306,7 +307,10 @@ print_usage(const char *prgname)
> > 		"  --eventq-sched: Event queue synchronization method "
> > 		"                  ordered, atomic or parallel.\n\t\t"
> > 		"		   Default: atomic\n\t\t"
> >-		"                  Valid only if --mode=eventdev\n\n",
> >+		"                  Valid only if --mode=eventdev\n"
> >+		"  --event-eth-queues: Number of ethernet queues per
> >device.\n\t\t"
> Will it be better to make it like "eth-rx-queues" simply ? So that It will clearly
> reflect that which queues it is referring to, Rx or Tx.  Also Comment should be
> updated accordingly.

Agree we should add rx also in the name to make it more clear, but I do not want
to remove event from the name. How about ' --event-eth-rxqs'?

Regards,
Nipun

> >+		"		       Default: 1\n\t\t"
> >+		"		       Valid only if --mode=eventdev\n\n",
> > 		prgname);
> > }
> >
> >--
> >2.17.1