Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

[Sachin Saxena <sachin.saxena@nxp.com>]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, November 20, 2019 3:20 AM
> To: Anatoly Burakov <anatoly.burakov@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Cc: dev <dev@dpdk.org>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Sachin Saxena <sachin.saxena@nxp.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kinsella, Ray <ray.kinsella@intel.com>; Bruce
> Richardson <bruce.richardson@intel.com>
> Subject: Re: [PATCH v7 09/10] build: change ABI version to 20.0
> Importance: High
> 
> Reduced the Cc: list.
> 
> On Fri, Nov 8, 2019 at 5:26 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
> >
> > From: Pawel Modrak <pawelx.modrak@intel.com>
> >
> > Merge all vesions in linker version script files to DPDK_20.0.
> >
> > This commit was generated by running the following command:
> >
> > :~/DPDK$ buildtools/update-abi.sh 20.0
> >
> 
> I inspected the changes.
> I caught just 3 oddities.
> The first two were reported in the patches on timer and lpm.
> 
> The last one is in the dpaa bus driver:
> 
> > diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map
> > b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> > index cf428a54dc..e6ca4361e0 100644
> > --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map
> > +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> > -DPDK_18.08 {
> > -       global:
> > -
> > -       fman_if_get_sg_enable;
> > -       fman_if_set_sg;
> > -
> > -} DPDK_18.02;
> > -
> > -DPDK_18.11 {
> > -       global:
> > -
> > -       bman_thread_irq;
> > -       fman_if_get_sg_enable;
> > -       fman_if_set_sg;
> > -       qman_clear_irq;
> > -
> > -       qman_irqsource_add;
> > -       qman_irqsource_remove;
> >         qman_thread_fd;
> >         qman_thread_irq;
> > -
> 
> Here, we had fman_if_get_sg_enable and fman_if_set_sg in 18.08 and
> 18.11 sections, but no symbols for 18.08 were in the code.
> I'd say this is fine, as there was no ABI change between 18.08 and
> 18.11 on them.
> 
[Sachin Saxena]  Yes, we are also fine with this.

> 
> The rest of the series looks good to me.
> Thanks Anatoly.
> 
> 
> --
> David Marchand