From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00A13A2EEB for ; Tue, 10 Sep 2019 18:36:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FB411EDC0; Tue, 10 Sep 2019 18:36:47 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50]) by dpdk.org (Postfix) with ESMTP id 171921EDB4; Tue, 10 Sep 2019 18:36:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwQCtj4c/WflWmfjntMEfY1mLmd2pxNnGd+TSAllkWdS7QdAqtTI8RtoNXGwH3pASq5d+UL4aOU7p1N00kKuL8PLCdDJWocjashxuA2X85eS8ltbWDJAbDcLxEROzEPCKbAy4wrq3WYuo5ItvEwoc3R3X8yr+9CHWd9mOP3Me5V2GLRuw7t9A1lJ3LEmm1MLNfhREUwgJtDsvfNLqRBdvTo0yIgSShlIHoKYkIyolpYKe1QDzdDwW4+gTZgssmATiSDSuWiPg2k8PrP3BMFxy45f5feftTYfLgOoHUPXXQsyljSomaaQZdR4AV2ZeeTwt2CuIKI27JVnCbbKyBkp0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZiDSroYy4geoGefR7D4hOImHPU9Vz8WpHl7O4IFWmI=; b=UzPRcVanJHf1V5+KqoNy6MaRwSdwks/3BFGTGD+Oi4oMV3l9QhUmy51VbO3h2p/rqlnfENATILeSb4al93S+E24B2AGnHZI3bV0nH8oeARQUyaVKk8hzSfsX2chBsD1d47Rx95DhRzYhryW5wUnrqi4m/Qs0oeIuGEwSILEWvEWeyALVaWRiQz1MeRdPumL4TfnnXzgtZwEqEz1rb+rzucZhi7RXuzLCtGAtps2dbde0Sax48ZDYCGESMDv9STS9GMPmJvv6oOBm2HDljtjV/rdlTF8WhR0s+OCLOgCs5Z+L9joRBaaR4S9ZNA8OE1CTiCHxZWgLO7LgyLSqn2UsXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZiDSroYy4geoGefR7D4hOImHPU9Vz8WpHl7O4IFWmI=; b=oDcXFWY3LHz44j4z+6vQ50Bh8I4r7HxF/7ZGsi5cQpv/fgGmhwcwNfsovbxhB/aot+rTQCBu93zNILPieJ27uYNZADXNEj5vFohImRA9FrxfFjMqX3W4ifah/XZSTbUthJXamj0mKfORi8HGCYdo07Mo/LxWngnHxawOSltdP00= Received: from VI1PR04MB4845.eurprd04.prod.outlook.com (20.177.49.14) by VI1PR04MB4461.eurprd04.prod.outlook.com (20.177.53.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Tue, 10 Sep 2019 16:36:44 +0000 Received: from VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::d568:dcf7:6329:7c80]) by VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::d568:dcf7:6329:7c80%6]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 16:36:44 +0000 From: Sachin Saxena To: Ferruh Yigit , "dev@dpdk.org" CC: "stable@dpdk.org" , Hemant Agrawal Thread-Topic: [PATCH 01/10] bus/fslmc: fix global variable multiple definitions Thread-Index: AQHVY/mrFKd3KmrNL0CWDUGL9nxXgKclI3eQ Date: Tue, 10 Sep 2019 16:36:43 +0000 Message-ID: References: <20190905145315.19395-1-ferruh.yigit@intel.com> <20190905145315.19395-2-ferruh.yigit@intel.com> In-Reply-To: <20190905145315.19395-2-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sachin.saxena@nxp.com; x-originating-ip: [92.120.0.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f8179c9-3e84-4053-d29e-08d7360d10c6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB4461; x-ms-traffictypediagnostic: VI1PR04MB4461:|VI1PR04MB4461: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(13464003)(189003)(199004)(446003)(110136005)(54906003)(76176011)(53546011)(316002)(86362001)(99286004)(14454004)(25786009)(2906002)(81166006)(81156014)(8936002)(4326008)(66476007)(66556008)(7696005)(64756008)(74316002)(8676002)(66446008)(3846002)(76116006)(66946007)(305945005)(9686003)(55016002)(53936002)(14444005)(7736002)(6246003)(71190400001)(71200400001)(229853002)(44832011)(33656002)(6436002)(5660300002)(66066001)(6506007)(256004)(52536014)(102836004)(478600001)(486006)(476003)(11346002)(186003)(2501003)(26005)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4461; H:VI1PR04MB4845.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: i4ZzAkwrZ0DcOKEnUX7rD+vqBCPAiKgApf5TyotRLyV6MKgJQR/jJVpU+4toleI0kp6U1CDtoai4LyyRhYuIwT16ovCeycDxNP9NPRTWjbKQP9SuvxioHnFA5f3sIDMuqxQ3O5sgQLb1zcACN4/zwaTVwWl+JeWKmZ3HWdna0YGI18WmAZBUFWkiWW6850qUbxX5SamsjK0RklmobMVG9V6/b3O3jzgGuGSMo3OFk7h8Xnvz76IwBp8d+FWDZq3/Zh8WrMSWGdA4zmh3Jo0FYYg+QEOmnMkJ7rdfJ+JVTEotsw18yCF/bbrOdbYqLD0LjuwcegyejVGKsUrbaY77KDXo05uvzNv2Em2Bo4wS+ZM3DYGnf4RVlX6uY0/wr/PXy9y5PNuVrOhxTMHml0h3e/gqOAdo+WdWGbh2KR4oS4g= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f8179c9-3e84-4053-d29e-08d7360d10c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 16:36:43.9605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1sJxvBRNfYaCfDEFK2InRxgDmO10hfkHcM3kZEVeTiBdSd6majE9E3W6gZ5s6iZVMQAxu3YXKUo5MEV91qhuPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4461 Subject: Re: [dpdk-dev] [PATCH 01/10] bus/fslmc: fix global variable multiple definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Sachin Saxena > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, September 5, 2019 8:23 PM > To: Hemant Agrawal ; Sachin Saxena > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 01/10] bus/fslmc: fix global variable multiple definition= s >=20 > 'qman_version' global variable is defined in a header file which was caus= ing > multiple definitions of the variable, fixed it by moving it to the .c fil= e. >=20 > Issue has been detected by '-fno-common' gcc flag. >=20 > Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with > QBMAN 5.0") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/bus/fslmc/qbman/qbman_portal.c | 2 ++ > drivers/bus/fslmc/qbman/qbman_portal.h | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c > b/drivers/bus/fslmc/qbman/qbman_portal.c > index e6066ce35..12a718117 100644 > --- a/drivers/bus/fslmc/qbman/qbman_portal.c > +++ b/drivers/bus/fslmc/qbman/qbman_portal.c > @@ -61,6 +61,8 @@ enum qbman_sdqcr_fc { > #define MAX_QBMAN_PORTALS 64 > static struct qbman_swp *portal_idx_map[MAX_QBMAN_PORTALS]; >=20 > +uint32_t qman_version; > + > /* Internal Function declaration */ > static int > qbman_swp_enqueue_array_mode_direct(struct qbman_swp *s, diff --git > a/drivers/bus/fslmc/qbman/qbman_portal.h > b/drivers/bus/fslmc/qbman/qbman_portal.h > index e54f2661c..0e9de8a1b 100644 > --- a/drivers/bus/fslmc/qbman/qbman_portal.h > +++ b/drivers/bus/fslmc/qbman/qbman_portal.h > @@ -11,7 +11,7 @@ > #include "qbman_sys.h" > #include >=20 > -uint32_t qman_version; > +extern uint32_t qman_version; > #define QMAN_REV_4000 0x04000000 > #define QMAN_REV_4100 0x04010000 > #define QMAN_REV_4101 0x04010001 > -- > 2.21.0