From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50088.outbound.protection.outlook.com [40.107.5.88]) by dpdk.org (Postfix) with ESMTP id 6D9AA1B4B9; Tue, 16 Apr 2019 15:49:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xjM0P3BSZ79HPFCtaBex+2GpvMR3tjiTfS5IIpmLCU=; b=Vp/U4+Y5XLy/iU/ShfkniN/OSpEn1a9pfglGNBONRQ5YDffnh4jmdAcepu8rNdSZPnQ4jUqjeozlaJ7WhFrtttWJA71D8bvqZobgb/NUx/7au3eRqUqgfg4p7HcgUawOQs6tGa+gLCGOTpLqbIbouidHx321jyyWmQ37SM9aZJo= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB5149.eurprd04.prod.outlook.com (20.177.50.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Tue, 16 Apr 2019 13:49:49 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 13:49:49 +0000 From: Akhil Goyal To: Bruce Richardson , "dev@dpdk.org" CC: "stable@dpdk.org" , Declan Doherty , Fan Zhang Thread-Topic: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id Thread-Index: AQHU7e0D58JIUPap3ESls9ce5ZQBd6Y+2nag Date: Tue, 16 Apr 2019 13:49:49 +0000 Message-ID: References: <20190408092514.36330-1-bruce.richardson@intel.com> In-Reply-To: <20190408092514.36330-1-bruce.richardson@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95c918cb-8766-4d95-f03e-08d6c2726510 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB5149; x-ms-traffictypediagnostic: VI1PR04MB5149: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(376002)(39860400002)(396003)(346002)(189003)(199004)(11346002)(4744005)(316002)(71190400001)(71200400001)(256004)(14454004)(478600001)(86362001)(486006)(106356001)(33656002)(476003)(81156014)(81166006)(8936002)(44832011)(97736004)(105586002)(99286004)(446003)(7696005)(2906002)(305945005)(26005)(6436002)(9686003)(229853002)(2501003)(76176011)(186003)(52536014)(7736002)(68736007)(6506007)(55016002)(25786009)(54906003)(110136005)(4326008)(5660300002)(6116002)(3846002)(66066001)(53936002)(102836004)(6246003)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5149; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8TE3SgDvl9VXEMYL5t1R7ESsBOhlI0duIye0eFXVa8R57wkE5jicidzbHQQZqE2Z7z1F/oAI8n7DNgC8qCNaH1x7JWFHyfwt1ypGg4QwucI1vgdIXNHPxla/jqOK+HpHKuu5k6DMZY3ZLuaMiKiGkOUYzASkvrKagfSIJm8ljcK5zniMbadXDhPszy3lltwcCDszrEhKyCAe43PdCOzSEVf44rq3s0CjRw9HTdKhquoq6aQhX9XNvh7BtGGOFhZ+ylAy1xWElhZH5agFurecnChSo1zxUwZmD7/kFvauq4rFn6FPEFDKeTiqyJKWnzm7FLu+rquQEYLC3lrre5tnj2pF+qfj0lLrjd2lwqTkDE30SiDI1AWICjTNtnm0d6CBqCoFdgtqH99cd3s1kkoDaus0sgyZOEsC4FWhSvupuuc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95c918cb-8766-4d95-f03e-08d6c2726510 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 13:49:49.6152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5149 Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 13:49:51 -0000 > The socket_id is used as an array index so should be within the range > of zero to max numa nodes. Add a range check to ensure we don't get > excessive values. >=20 > Coverity issue: 336812 > Coverity issue: 336829 > Fixes: 2c59bd32b70d ("cryptodev: do not create session mempool internally= ") > CC: stable@dpdk.org > CC: Declan Doherty > CC: Fan Zhang >=20 > Signed-off-by: Bruce Richardson Acked-by: Akhil Goyal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 77151A00E6 for ; Tue, 16 Apr 2019 15:49:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 460FE1B4C0; Tue, 16 Apr 2019 15:49:52 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50088.outbound.protection.outlook.com [40.107.5.88]) by dpdk.org (Postfix) with ESMTP id 6D9AA1B4B9; Tue, 16 Apr 2019 15:49:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xjM0P3BSZ79HPFCtaBex+2GpvMR3tjiTfS5IIpmLCU=; b=Vp/U4+Y5XLy/iU/ShfkniN/OSpEn1a9pfglGNBONRQ5YDffnh4jmdAcepu8rNdSZPnQ4jUqjeozlaJ7WhFrtttWJA71D8bvqZobgb/NUx/7au3eRqUqgfg4p7HcgUawOQs6tGa+gLCGOTpLqbIbouidHx321jyyWmQ37SM9aZJo= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB5149.eurprd04.prod.outlook.com (20.177.50.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Tue, 16 Apr 2019 13:49:49 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 13:49:49 +0000 From: Akhil Goyal To: Bruce Richardson , "dev@dpdk.org" CC: "stable@dpdk.org" , Declan Doherty , Fan Zhang Thread-Topic: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id Thread-Index: AQHU7e0D58JIUPap3ESls9ce5ZQBd6Y+2nag Date: Tue, 16 Apr 2019 13:49:49 +0000 Message-ID: References: <20190408092514.36330-1-bruce.richardson@intel.com> In-Reply-To: <20190408092514.36330-1-bruce.richardson@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95c918cb-8766-4d95-f03e-08d6c2726510 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB5149; x-ms-traffictypediagnostic: VI1PR04MB5149: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(376002)(39860400002)(396003)(346002)(189003)(199004)(11346002)(4744005)(316002)(71190400001)(71200400001)(256004)(14454004)(478600001)(86362001)(486006)(106356001)(33656002)(476003)(81156014)(81166006)(8936002)(44832011)(97736004)(105586002)(99286004)(446003)(7696005)(2906002)(305945005)(26005)(6436002)(9686003)(229853002)(2501003)(76176011)(186003)(52536014)(7736002)(68736007)(6506007)(55016002)(25786009)(54906003)(110136005)(4326008)(5660300002)(6116002)(3846002)(66066001)(53936002)(102836004)(6246003)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5149; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8TE3SgDvl9VXEMYL5t1R7ESsBOhlI0duIye0eFXVa8R57wkE5jicidzbHQQZqE2Z7z1F/oAI8n7DNgC8qCNaH1x7JWFHyfwt1ypGg4QwucI1vgdIXNHPxla/jqOK+HpHKuu5k6DMZY3ZLuaMiKiGkOUYzASkvrKagfSIJm8ljcK5zniMbadXDhPszy3lltwcCDszrEhKyCAe43PdCOzSEVf44rq3s0CjRw9HTdKhquoq6aQhX9XNvh7BtGGOFhZ+ylAy1xWElhZH5agFurecnChSo1zxUwZmD7/kFvauq4rFn6FPEFDKeTiqyJKWnzm7FLu+rquQEYLC3lrre5tnj2pF+qfj0lLrjd2lwqTkDE30SiDI1AWICjTNtnm0d6CBqCoFdgtqH99cd3s1kkoDaus0sgyZOEsC4FWhSvupuuc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95c918cb-8766-4d95-f03e-08d6c2726510 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 13:49:49.6152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5149 Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416134949.-3jmdI3LlePS06KwWDyWBm53wCPBiRO--DvzpLWMNhM@z> > The socket_id is used as an array index so should be within the range > of zero to max numa nodes. Add a range check to ensure we don't get > excessive values. >=20 > Coverity issue: 336812 > Coverity issue: 336829 > Fixes: 2c59bd32b70d ("cryptodev: do not create session mempool internally= ") > CC: stable@dpdk.org > CC: Declan Doherty > CC: Fan Zhang >=20 > Signed-off-by: Bruce Richardson Acked-by: Akhil Goyal