From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BC5BA0597; Thu, 9 Apr 2020 08:33:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CE071C13B; Thu, 9 Apr 2020 08:33:01 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80115.outbound.protection.outlook.com [40.107.8.115]) by dpdk.org (Postfix) with ESMTP id B46D31C12B for ; Thu, 9 Apr 2020 08:32:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlPMcGISs8YAhw1TwcZChYRfybC9Fgg+aBzSsOYzHY0wVeN9QbC0g/jmvglq+remAvSXiPpWhd1F082I+UD8BDzNm6FSVN8fZWDwodvaL22nSFMkdQHiWYc/aOpTL7+j3k1nELNE1hVrWiCCNyRQ4p8QTNjV3dCgap/+L2gx/7hND+dbIqD/F5eVFvGZuGcK1+ApytHkDTljI+sFPvf203ZgMyoPy05faZJj9BNdP31+KbDZdctb1kvVt9NDyYdX3MxP7nt8y7/i7vD7oh577iPP+ALLMy0K6VwCneYKVm2ZlgbQgjxgPCFVhpw2eBzZsbZjTdkugm1PhXUXj4R/Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sH1G33QzUzPvGwns/kxOPfRlmnZZ2W73nhLSoeE7PBs=; b=QUsQakwHrmTsR/QJ3hFBNo/C9+h09jrfWgnB0AEXqTnH4wBpnVT6k8/Jz5Zs8QktVrfUuRHOLChwCcMPQcq37DfoiJDx4675qNUqQPgVdt9SAr8FixWUBbMekAbkF2VMdJWRLpe3A+LRSAFWC35CV+mhX9dQab3I5DdRnqeHb8o7/V9xqttiomxQWJNp3LzJtNgxxDGn4Las1n7Ue5uFmQ3qBJShdWMW9HhfIQWudX6dXbJ9NXpTxGujWHCo49RkzTJEbdv/yFtxv71bWWb4DqsyAQK5bDM1u4Amz6mgQnMY4mVKXD/9XXFwxoAUQ0c2qOqHNu8BH12hkSSZu4F7Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom.co.il; dmarc=pass action=none header.from=silicom.co.il; dkim=pass header.d=silicom.co.il; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sH1G33QzUzPvGwns/kxOPfRlmnZZ2W73nhLSoeE7PBs=; b=qT3Q2mCglmubLyQ9UXT/VXQ8hfJQ5L0zpDpb9E9Xhjo9kQ0Cpe7InTLqT5vdL6RLBrjuPoEWLiEps4wkWRKkeqQHODbsR9P6fo0iXNWtw4PQIBgbbnhe4ctPp6Mnu4V/+hglIVuh3mxRVcuzYCyil7QErPFvXiFW9JDG3xqwH6g= Received: from VI1PR04MB5150.eurprd04.prod.outlook.com (2603:10a6:803:5c::19) by VI1PR04MB4110.eurprd04.prod.outlook.com (2603:10a6:803:42::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Thu, 9 Apr 2020 06:32:57 +0000 Received: from VI1PR04MB5150.eurprd04.prod.outlook.com ([fe80::79cf:289f:b9b4:53b5]) by VI1PR04MB5150.eurprd04.prod.outlook.com ([fe80::79cf:289f:b9b4:53b5%4]) with mapi id 15.20.2900.015; Thu, 9 Apr 2020 06:32:57 +0000 From: Xiaojun Liu To: "Wang, Xiao W" , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 5/5] net/fm10k: add switch management support Thread-Index: AQHV/oU2x6zXlaXofUWMdmlxIxujYahloIQAgArSE/A= Date: Thu, 9 Apr 2020 06:32:57 +0000 Message-ID: References: <1582879102-17977-6-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-1-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-6-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiaojun.liu@silicom.co.il; x-originating-ip: [113.110.226.153] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 098288fc-2366-479c-97ce-08d7dc4fd7b1 x-ms-traffictypediagnostic: VI1PR04MB4110: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0368E78B5B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5150.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(366004)(396003)(136003)(376002)(346002)(39840400004)(71200400001)(66946007)(66476007)(5660300002)(7696005)(53546011)(44832011)(55016002)(9686003)(6506007)(26005)(186003)(478600001)(110136005)(8676002)(81156014)(64756008)(2906002)(86362001)(76116006)(66446008)(8936002)(66556008)(316002)(33656002)(4326008)(81166007)(52536014); DIR:OUT; SFP:1102; received-spf: None (protection.outlook.com: silicom.co.il does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hpSHfzZt3XZc57d7oO8RAS9zwz6nOOMZERDvnHFJGemcZ7GamKYy1gVafrMmU959UfcheP+5dbQISRKlxng/8ehSs+xrb5InXU8a5t+TnM/Mn1vqs20YGVr+dwgPQXkOEMyR+4PvnLp6t3wGJ8P8q8bcnFpHMNYMmvBBAi+XFODqxbDdQAfUpJXCUVKKFqzbEhmNgPqMjlRsVyw/Omxyn67c3HBI/2L6NvDSvZP1/v2+1XE9EvjIj7mV13wC7vc8+DX9iMdyEGoXb+1NsdLpxPh4+D8CLAHlSf3+SoT3hoqmPi2FQqDDH7Gl4mSjyd7jKxxuEl2w2tEHjzFcewQJ2eYG7l3OZsSNF7Rep6f6kSLnocpG8Wa3jsnIu/X7fK/EsEGnGpn8qfIq0asBjDXAVnAhJyzTYqG32By+px3LekROOjs/jKx7q8Kup7CNTRQu x-ms-exchange-antispam-messagedata: W/OQ+ZD8w0VN/n/9LLIsQwyphalYelIysA2+TwEKYR4i5cmhlS9oOQSeIHUjMA5vP2ox5nYQIuBMaXtC88H0LBAJGKVvoZD0OwRP10gWW9ZVDPrH0TvVVfQBogMLzNoLGmf4nvImWqAfKiNa/nAW1A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom.co.il X-MS-Exchange-CrossTenant-Network-Message-Id: 098288fc-2366-479c-97ce-08d7dc4fd7b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2020 06:32:57.3772 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JhiCmDrgTiFbmFEhU8V0c+NAk75+W4+/kWJlJbix79atciLx84Lwn6n9ihQ965n6ghWAlhF390ec/1IhbuE3J6QpFr4ZlaKQpEQxUWTU+pw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4110 Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, Thank you! I add release note and remove the DEV_RX_OFFLOAD_RSS_HASH modifi= cation(It may be a mistake).=20 I submit the new patch again:)=20 Best regards, Xiaojun -----Original Message----- From: Wang, Xiao W [mailto:xiao.w.wang@intel.com]=20 Sent: Thursday, April 02, 2020 5:12 PM To: Xiaojun Liu; Zhang, Qi Z; Kwan, Ngai-mint; Keller, Jacob E Cc: dev@dpdk.org Subject: RE: [PATCH v3 5/5] net/fm10k: add switch management support Hi, This is a feature-add patch, so you need to add release note in doc/guides/= rel_notes/release_20_05.rst, that can be included as part of this 5/5 patch= . Another issue, why delete DEV_RX_OFFLOAD_RSS_HASH unconditionally? I think = it would impact the existing usage. @@ -1808,8 +2044,7 @@ static uint64_t fm10k_get_rx_port_offloads_capa(stru= ct rte_eth_dev *dev) DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_JUMBO_FRAME | - DEV_RX_OFFLOAD_HEADER_SPLIT | - DEV_RX_OFFLOAD_RSS_HASH); + DEV_RX_OFFLOAD_HEADER_SPLIT); Also some comments on the feature description are inlined below. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Friday, March 20, 2020 2:59 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Kelle= r, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v3 5/5] net/fm10k: add switch management support >=20 > Split dev init to 2 parts. > First only register the port in switch > management; second init hook will be > called after all the pf are registered > and switch initialization. It will finish > dev init. Also add switch interrupt support. > Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset > to support mirror operation. Add fm10k_dev_filter_ctrl > to support flow operation. > Add dpdk port and pf mapping, so > the dpdk port can map to a specific pf > and 1 dpdk port can map to 2 pf to get > total 100G throughput. Update fm10k.rst. >=20 > Signed-off-by: Xiaojun Liu > --- > doc/guides/nics/fm10k.rst | 5 + > drivers/net/fm10k/fm10k_ethdev.c | 559 > ++++++++++++++++++++++++++++++++++++--- > 2 files changed, 525 insertions(+), 39 deletions(-) >=20 > diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst > index 4e178c2..75f9929 100644 > --- a/doc/guides/nics/fm10k.rst > +++ b/doc/guides/nics/fm10k.rst > @@ -124,6 +124,11 @@ FM10000 PMD driver. The switch driver can be > acquired from Intel support. > Only Testpoint is validated with DPDK, the latest version that has been > validated with DPDK is 4.1.6. >=20 > +To avoid loading other switch driver from outside of DPDK, there is anot= her > +way to load switch driver in DPDK. If you want to use the inline switch = driver, "There is a way to load..." Since what you do is the only way to load switc= h driver inside DPDK. > +you need to set ''CONFIG_RTE_FM10K_SWITCH_MANAGEMENT=3Dy'' in the > configure file. Configuration file. > +The inline switch driver supports mirror and some flow forward rules. Please be clear on what forwarding rules are supported. Any doc reader will= be confused by "some". > + > Support for Switch Restart > ~~~~~~~~~~~~~~~~~~~~~~~~~~ [...]