From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B925DA0597; Wed, 8 Apr 2020 05:25:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 983841BF02; Wed, 8 Apr 2020 05:25:19 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130132.outbound.protection.outlook.com [40.107.13.132]) by dpdk.org (Postfix) with ESMTP id 2C7681BE90 for ; Wed, 8 Apr 2020 05:25:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l/CtSpkeTkFRl1YXC+rq/c8HrVxMUD7XGhNFQ2HRAkAngP/4NPrznLTWm23sn6QoEua6xIWOWPCUaXLRLI7pYa+GXJUkUYqaToH85R4VF10FTFJ7GhifFVnsZaAjK0etXeT5vlWyTjBcXZPz64NkmcsuQ4LTDXg1tB0w1NrBIlqbEMYtVLnPjjAMmnIGVWneR7bXT0mecPk+ftTvhdis/EQqOFv0G+jp1GzRNPYW469hevs3cBiy21iXqvUCtuc+jL+tE8dcpt3mS1ILAkMK64bzrfYgP1byVwlnKv38zEKk3Cddz+ZuyIPFseLUkI3m/G6Z2KWdKbeU44vFTQoNqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mM0zWSA1OTk0WgHgX64dJDGgTSSqr3pJiWMZZcnNpKo=; b=EDV6UN7Nxv0imx9liZeXIgUyvuk2pEQ+U0bVUKQ9JVr6K7qT6r0sunvy2xUrPiRAOKqV/i5Sa1vkkNOCNdyaW9ZGED0Qd2oLf4+aHaQReiRhzC0ym20zaEw8UXne/d4LINDDj/meuvPAa0k3lBvNs++mddFMQFeP8MvygrvcDEA5wP2G0vQ+mS+xoSGEEIUEZiCR4MMMywXfP62flW1znY4eDJllowFGtKCTv+JRgcA7tMX6RInVfFVr1+fbxQmSbO/2qDjpyXjfLUvuT28VevbakRpAcALGi5QA9XYzzqUCaQ8mkUIR6ISMt/vKoM5mFCAMAZlwzYyh3LmmYYKvNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom.co.il; dmarc=pass action=none header.from=silicom.co.il; dkim=pass header.d=silicom.co.il; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mM0zWSA1OTk0WgHgX64dJDGgTSSqr3pJiWMZZcnNpKo=; b=t62Iq3LHoQVZzTdY6Ns5VAHt5h6AIX2hBwR36b/bfTuInDj0uJMD/+mt2PfrBfE8D08fIKNCCZkw/d+XNtLtkwyHiBRYNrxkiisB/o0CLwQpXXzAGiYExpyl6hwKGAryi8yjXi7kTMKYIYD0QBSF+amAwhPsoogNGVlvAu9Q66g= Received: from VI1PR04MB5150.eurprd04.prod.outlook.com (2603:10a6:803:5c::19) by VI1PR04MB6798.eurprd04.prod.outlook.com (2603:10a6:803:131::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 8 Apr 2020 03:25:15 +0000 Received: from VI1PR04MB5150.eurprd04.prod.outlook.com ([fe80::79cf:289f:b9b4:53b5]) by VI1PR04MB5150.eurprd04.prod.outlook.com ([fe80::79cf:289f:b9b4:53b5%4]) with mapi id 15.20.2900.015; Wed, 8 Apr 2020 03:25:14 +0000 From: Xiaojun Liu To: "Wang, Xiao W" , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 1/5] net/fm10k: add basic functions for switch management Thread-Index: AQHV/oUfe9WhSq+tSUiSgdcwovw3d6hlmAYAgAkT30A= Date: Wed, 8 Apr 2020 03:25:14 +0000 Message-ID: References: <1582879102-17977-6-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-1-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-2-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiaojun.liu@silicom.co.il; x-originating-ip: [113.110.226.153] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e6f9b6c6-cfe5-4b13-d82e-08d7db6c7441 x-ms-traffictypediagnostic: VI1PR04MB6798: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0367A50BB1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5150.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(366004)(346002)(376002)(39850400004)(396003)(136003)(81156014)(26005)(8936002)(2906002)(478600001)(71200400001)(44832011)(966005)(110136005)(76116006)(8676002)(81166007)(316002)(7696005)(186003)(4326008)(86362001)(6506007)(53546011)(55016002)(66946007)(66446008)(66476007)(52536014)(66556008)(9686003)(64756008)(33656002)(5660300002); DIR:OUT; SFP:1102; received-spf: None (protection.outlook.com: silicom.co.il does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vng1crKToaT3/knYVWnOQ+0U/o/Kjq//xR7+6FIf5FlPkokRk1ii+F/1KcbGJUTZbPWYD+roY9NUKBUv1wIlEXmE+6dH4bleLqbFMODHqXOS+TsRRcvAtrsA1AEmseyUZeV4Zm6JKWiE3QikmIq0zaASIsp9U/Ilks9MIl6Z0amuvMG73JpXhbxigtbn8EcF4haknz2ywuF3m5oJOwCEIss1+VnXAbnUD9xSDywsUjwRv7mvSIpEQXm9cKjLKLPh3rCJeZdQcUqFUCUUq5P4ypMvjYBCp5GgUUk02g4ei049cOJA2l7crIrrMkRcvb9SAzQzL/KkG+y5rN0hXoXBlPoY5K4z6XihfNQerkG0w1PTfR8APHmVuE/e/iUWqGSmDH968a6fPseQG/5dpJ1377ufzYr0b5evya/P8q6ItCkbRrriPMi/VYmNlLght3KSOnqHS7QzrX28Xv6eO7sjkwQOvpnqQrhKirNelui3mPh5QSqdnCxtR8RuvWnGo7a02lcOjyg30ylNU0ItUneVfA== x-ms-exchange-antispam-messagedata: xfAQ72Icj1CjLme3pl4wvlEK8e7Unr2N05Bxeg2X3EwwJuCLxcx75ooLb1/ry1T8Q6MQU+xzDSOxvRsvBS7GO/8E7zB9sAAn7o1qEy+l3lGvz6EHRGb7C8Y5X4p4YXODIeOaW3xiqDQsY5ahqi7LIA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom.co.il X-MS-Exchange-CrossTenant-Network-Message-Id: e6f9b6c6-cfe5-4b13-d82e-08d7db6c7441 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2020 03:25:14.6689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4PYatzx5iZedbaPWkYeLS8lO+THIEhS+kG0GGQlk72twTppIZI9ZVRHItn0c2/dCntgXkCTlormVI6jjkrOCpYrYtUlQMKT6SjY/rhPo0NI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6798 Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, Please check the source file. It not looks align in patch file because the = patch add "+" for each new line. Best regards, Xiaojun -----Original Message----- From: Wang, Xiao W [mailto:xiao.w.wang@intel.com]=20 Sent: Thursday, April 02, 2020 4:42 PM To: Xiaojun Liu; Zhang, Qi Z; Kwan, Ngai-mint; Keller, Jacob E Cc: dev@dpdk.org Subject: RE: [PATCH v3 1/5] net/fm10k: add basic functions for switch manag= ement Hi Xiaojun, Just comments on the alignment issue, things like below looks not nice. If = you are using vim, I recommend " set tabstop=3D8 " setting. +#define FM10K_SW_BIST_CTRL_BIST_RUN_PCIE(p_) (1ULL << (p_)) +#define FM10K_SW_BIST_CTRL_BIST_RUN_EPL (1ULL << 9) +#define FM10K_SW_BIST_CTRL_BIST_RUN_FABRIC (1ULL << 10) +#define FM10K_SW_BIST_CTRL_BIST_RUN_TUNNEL (1ULL << 11) +#define FM10K_SW_BIST_CTRL_BIST_RUN_BSM (1ULL << 12) +#define FM10K_SW_BIST_CTRL_BIST_RUN_CRM (1ULL << 13) +#define FM10K_SW_BIST_CTRL_BIST_RUN_FIBM (1ULL << 14) +#define FM10K_SW_BIST_CTRL_BIST_RUN_SBM (1ULL << 15) +#define FM10K_SW_SCAN_DATA_IN_SHIFT_IN (1 << 25) +#define FM10K_SW_SCAN_DATA_IN_SHIFT_OUT (1 << 26) +#define FM10K_SW_SCAN_DATA_IN_UPDATE_NODES (1 << 27) Check more at http://patches.dpdk.org/patch/66973/. Please take care for ne= xt version. I'm wondering if we could have a tool for automatically check this kind of = alignment issue. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Friday, March 20, 2020 2:59 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Kelle= r, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v3 1/5] net/fm10k: add basic functions for switch managem= ent >=20 > Add I2C to control the inside LED and PHY. > All the operations of I2C are using fm10k I2C register. > Add SBUS to communicate with spico(micro code in serdes) > by using fm10k SBUS register. This is like I2C operations. > Add registers defination, which include all the registers > will be used in the driver. Add switch management log API. > Add switch management structures. Modify Makefile to add > new files building. Add CONFIG_RTE_FM10K_MANAGEMENT=3Dn > in config/common_linux. >=20 > Signed-off-by: Xiaojun Liu > --- > config/common_linux | 5 + > drivers/net/fm10k/Makefile | 11 + > drivers/net/fm10k/switch/fm10k_debug.h | 19 + > drivers/net/fm10k/switch/fm10k_i2c.c | 309 +++++ > drivers/net/fm10k/switch/fm10k_i2c.h | 55 + > drivers/net/fm10k/switch/fm10k_regs.h | 2302 > +++++++++++++++++++++++++++++++ > drivers/net/fm10k/switch/fm10k_sbus.c | 291 ++++ > drivers/net/fm10k/switch/fm10k_sbus.h | 40 + > drivers/net/fm10k/switch/fm10k_switch.h | 335 +++++ > 9 files changed, 3367 insertions(+) > create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h > create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h >=20 > diff --git a/config/common_linux b/config/common_linux > index 8168106..6e62b99 100644 > --- a/config/common_linux > +++ b/config/common_linux > @@ -66,3 +66,8 @@ CONFIG_RTE_LIBRTE_HINIC_PMD=3Dy > # Hisilicon HNS3 PMD driver > # > CONFIG_RTE_LIBRTE_HNS3_PMD=3Dy > + [...]