From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64CBEA0032; Fri, 1 Oct 2021 12:22:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54B5D41149; Fri, 1 Oct 2021 12:22:56 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57]) by mails.dpdk.org (Postfix) with ESMTP id BB5B740040 for ; Fri, 1 Oct 2021 12:22:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iklc+bVInU6P/6ZfdfQ4dH5lu0wkg67hf00wbeCaX1oJxJlQFqOzkvIoA/PsCqcFyhDu7FO7yknBfUCnMi7/ef3G/9Y7hz/fY3/TR9CFsiIkehGba7F0RSSymEVW63ASorla4DMCqu6LTU3kZ3am3Arg4u2Crx6ZUAYRTMX2q1tk3DVzAEA96CFqq8oEduj30FSl2FJDP098fB1K9PTPC1zdx8JsmwvsPPorzi2wUzsLSFtKwu9ROEPg11BsiFsYHizDz7sQ3AMftmznesRjavPABw/suZHmn55xAqWUDBx157ZO9T/nGs3a+V01o9Sho9vwGrG3hdYXculFugFD8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I57zayg0fQtT5jQqOxnin4xtJhUFc4J96VL5DUN6hU8=; b=anavvplFsq1SM/0ELD9PuvvZGwvDb2fUNmJLUNU/+4LjYibeyKa16LQysOyoJ8r0ZQV/uxqn6lQQdUoMlrepBPetk4DUhT7KHuEGftUazbSiS7WjMRyYUT12HSVpEKiVUMIYFpSCfw9hUSmah2DPj9U5N/bJZjALV1A2YxnvdDFPQt9D30C9M0IaBhj4GgefKW4PVupkQX/bpODiDWUZs2ac9cYfCwmlZ4W7N6MjmybQ8CB7u1U2QC05D9iMn09zU/8HO8nrxzgY0uaRE1PkZz8XtfnYTR5e5rXVeYE1Dojukf/+EDfm2G5OOe8iZJUI+wLhqoJ8fYYM4VotEpI/uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I57zayg0fQtT5jQqOxnin4xtJhUFc4J96VL5DUN6hU8=; b=dUVdSko6tGIL6Ja/yLRZXKwABgz+sMdRh6pPVNF+Zsw4NAXB9nGuoqAMBZHxo1BOJzapuWfGgd6Tc4WmGL3eHf64ApgTN18tMenqdyfRTQ2oOVlwXzb3i3/jxDEEzGtFK2UTLuSR2NAKJJK4sc8UzdhZcmTluzUxQySIYH2hQaY= Received: from VI1PR04MB6816.eurprd04.prod.outlook.com (2603:10a6:803:12d::18) by VI1PR04MB5582.eurprd04.prod.outlook.com (2603:10a6:803:ca::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct 2021 10:22:52 +0000 Received: from VI1PR04MB6816.eurprd04.prod.outlook.com ([fe80::19a4:1404:5f97:ff4d]) by VI1PR04MB6816.eurprd04.prod.outlook.com ([fe80::19a4:1404:5f97:ff4d%7]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021 10:22:52 +0000 From: Apeksha Gupta To: Ferruh Yigit , "david.marchand@redhat.com" , "andrew.rybchenko@oktetlabs.ru" CC: "dev@dpdk.org" , Sachin Saxena , Hemant Agrawal Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver Thread-Index: AQHXpbtgnSeLbkrXsUOYWqvWGsyylauxetKAgAyQ4VA= Date: Fri, 1 Oct 2021 10:22:51 +0000 Message-ID: References: <20210909204314.1826-1-apeksha.gupta@nxp.com> <20210909204314.1826-2-apeksha.gupta@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9861d34d-a6e0-4b17-ac9d-08d984c56ce7 x-ms-traffictypediagnostic: VI1PR04MB5582: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fA2iNbaTSEvqlS5kPc6J5ENuw3Iqw8jr7FlKJbm2CaQ9KZrz7X6wQ7A6HCnXReHOMBrag+kgVnQOIompMLHL0n7eqrBC6ahjAAKqdFmNj7043SBRvYXFvh08GPY2SzcbwgXDZ7xo1vgUlZK/ljqwcvpagBUACXtEHpJ1UKX3p5WCIucBfazkcKXizXOBW3hnvuX3ib6BexnOtHKbER6A9w+fyCXvqbrCLGppOI678OdsX/0EOx4NKUYDJLID7oDNIUie5MpFs61ExnZJQ0DhKAG18K4GZCIDj7uDI4Y60B2jC10rhD9Y03ZZSQ8RDC+HvxGkRHmyLJNSUFQQdpVkwboVyGbt5PS07ubS1exhMtZn39w+FRXQbvW7g0of7DTY0Djs8QaxGq0QARJE48EfnAbcAnsGIm7o69IVubp/xvtrFk94z1UsCa1tj5N41pgAJFu8TJ8NZD4fM5RmVfCFUkyOMpQWRl+GBF07h4jVV5VwF+l0wYDbRGiO4sHGhv06ndiecuKlUWNkk35tbZgBT308HFqFCkSm5soJLXT9Nrt07qox0lZq/oK1N+MHc9R5M7k2ZTV24aPNzVWcz77JKWeuy8r3grhVjhdtcKDEzWecrcyAx2UFAAGSAg78iDFdq3jwELayYf62ZvnvVT3DhfPI4/2N8YnqwMfvuzk3aoAWAD/IQQAjDx/eSpfOz6kbwfd3oucAUK14rSzT+VWvtY0qqSBmjPFVHo8BxItHE92IZ9OKfsNXdu7CsBVLe2XXQPMNCCPLE0QyTwaPNVxcboVvjpkqvqmfDRfjujefyyOk4osEq1IUyn4H9Z4ThqBBJiYMeomYNAqBpbeV91kKKg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB6816.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(66946007)(8676002)(76116006)(6506007)(66446008)(8936002)(4326008)(83380400001)(7696005)(186003)(26005)(33656002)(38070700005)(5660300002)(53546011)(64756008)(55016002)(9686003)(66476007)(66556008)(508600001)(38100700002)(122000001)(44832011)(2906002)(52536014)(110136005)(71200400001)(54906003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uOX2uSb4wA8+TUWMfaGWmEFjDTNwQMF90Nn759ivAhsmq45OdXhiieAMcgRR?= =?us-ascii?Q?XaMqEYZUj8NimsvfAXuQvXKl6xRL1E4MopPEKsZtqabzzi8Un/MXrl1wK9il?= =?us-ascii?Q?9Z/hBZcjW6Uo5Y+ixxKzi6TOLDocO2Wm9Bg/J6UDlbSYXINCkbQyVFZfsC1V?= =?us-ascii?Q?wQv64Wpc0Xgka1xyFfpaKd2o9Y7Bt9TKpVpN8PnWVGqzHAqM71TNcVZio8RG?= =?us-ascii?Q?0XZLxCHloJkfYa6EzT1d9iqOEnpPI0pK2EXTlTk7iEkOIhbq2jrPOEb9vajH?= =?us-ascii?Q?brDwueLEyQ3hKvkaRnYB+4iK0zL5546VUxQ6mAelcGqftBgmkREduCSE0bEg?= =?us-ascii?Q?JNFFxNo6nZKKRgbt+rJ/j4g+RegOP0haJw2UxqBL/eeYeqtuXgoLbjmhjRPO?= =?us-ascii?Q?bNgB/H4AX6oVV9PVlBLspzgFIsREhmw6sK4Otl4+aIxVadpBQH0SN8xaV6jm?= =?us-ascii?Q?JXUAqIdn9JAQvuEwxtohHUaeAq0WePjvnZ5VFWvyXELRznGmzOZ4x/3FuUcI?= =?us-ascii?Q?BkTi8P1u5MVbkJnVrth+oB9uOmwCeEjxg9quDyJy3Ku2dVA/K64ooMb6EKDN?= =?us-ascii?Q?/1OngEGclg6/QqSlUPu0LUO5M0aDGf1+Gs7su4DJ4PZZlJziJhsNq9EjSAf0?= =?us-ascii?Q?hu/IQDn1mbwNEaXemTVV4sfM0gPnHfcEQUrWJf1cmtmwpc/3ac0YYZKhB9tk?= =?us-ascii?Q?t8CsEFLSZG974E8Jqq/gNc0Or4cwVO6obPvCF/LSnizZ9JJDMIj+Lp9GIz5Q?= =?us-ascii?Q?s1ZwhuiG9ypi4kbrLuMa6aoA/7yfMuzwlS80EmgGRfpgg/Y63wazHhvOFLlI?= =?us-ascii?Q?GvVq9rIfUysNEifPPs5gCSk6HFuZui9xXAqImTRBN5KbEwKf+Jq5v6lG8SI2?= =?us-ascii?Q?5TykZqeLnXmlPtg2CpUMjN+9zinagwa1P4JFyBjAMGJ+F78Zf7kYAtcgZxPD?= =?us-ascii?Q?7o1e7Ogu2STYB5PhLxysxx9C4PTOyZKy70RydOEVMyLl32RY91Z5xLGcxVeY?= =?us-ascii?Q?kzPtGv9x29ZVarRfcY/hpgZBMUXtOXMIPoZuQpmNu+DRDqKcYm9VqiU77pDD?= =?us-ascii?Q?QGDxXTWqJTBbnGKyAt2OWbNfd4sFTCuFgc3SO+FHL+TXvCoNpNVkrHCNb4su?= =?us-ascii?Q?khSNoB0VMbyPiywV1ej4roYUQ9NSbNezu1xoWCaVKb/ppw0swKt+XLVLmU9S?= =?us-ascii?Q?crvVMZ0LYH9/wEZ0gcuUeSZ6DavWK6z8pH+mK4jsFOQRPJJl9jQndv67OepL?= =?us-ascii?Q?EM0aZ26FdbXEcw/SMVqjhtzTS7Rvpoh/BC32urOFHpI/3+PEwa2MibkA6E6l?= =?us-ascii?Q?dpy49Kk9lxmIdnTI1OSt+ldO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB6816.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9861d34d-a6e0-4b17-ac9d-08d984c56ce7 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2021 10:22:51.9156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 31O6k07KdLRoKi9RyfICqL4Svnhc2sQBWr2B1YqcYBnrMFZdMMDZmg5MF+oxEk5qVpM+Nw0fKv33a8+whh++zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5582 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, September 23, 2021 3:40 PM > To: Apeksha Gupta ; > david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru; > ferruh.yigit@intel.com > Cc: dev@dpdk.org; Sachin Saxena ; Hemant > Agrawal > Subject: [EXT] Re: [dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce NXP > ENETFEC driver >=20 > Caution: EXT Email >=20 > On 9/9/2021 9:43 PM, Apeksha Gupta wrote: > > ENETFEC (Fast Ethernet Controller) is a network poll mode driver > > for NXP SoC i.MX 8M Mini. > > >=20 > Hi Apeksha, >=20 > Before going into details, I have some high level comments to start with, > please > find comments below. >=20 > > This patch adds skeleton for enetfec driver with probe function. > > > > Signed-off-by: Sachin Saxena > > Signed-off-by: Apeksha Gupta >=20 > <...> >=20 > > +++ b/doc/guides/nics/enetfec.rst > > @@ -0,0 +1,122 @@ > > +.. SPDX-License-Identifier: BSD-3-Clause > > + Copyright 2021 NXP > > + > > +ENETFEC Poll Mode Driver > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > > + > > +The ENETFEC NIC PMD (**librte_net_enetfec**) provides poll mode > driver > > +support for the inbuilt NIC found in the ** NXP i.MX 8M Mini** SoC. > > + > > +More information can be found at NXP Official Website > > > + ww.nxp.com%2Fproducts%2Fprocessors-and-microcontrollers%2Farm- > processors%2Fi-mx-applications-processors%2Fi-mx-8-processors%2Fi-mx- > 8m-mini-arm-cortex-a53-cortex-m4-audio-voice- > video%3Ai.MX8MMINI&data=3D04%7C01%7Capeksha.gupta%40nxp.com > %7C74fdc59c47574d828f7608d97e7a4df3%7C686ea1d3bc2b4c6fa92cd99c5c30 > 1635%7C0%7C1%7C637679886024819097%7CUnknown%7CTWFpbGZsb3d8ey > JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > 7C3000&sdata=3DTjuqIfC8yXwBa3DLCgA7djItfV0UmZ6lA3uLDQ7TFwY%3D > &reserved=3D0> > > + > > +ENETFEC > > +------- > > + > > +This section provides an overview of the NXP ENETFEC and how it is > > +integrated into the DPDK. > > + > > +Contents summary > > + > > +- ENETFEC overview > > +- ENETFEC features > > +- Supported ENETFEC SoCs > > +- Prerequisites > > +- Driver compilation and testing > > +- Limitations > > + > > +ENETFEC Overview > > +~~~~~~~~~~~~~~~~ > > +The i.MX 8M Mini Media Applications Processor is built to achieve both > high > > +performance and low power consumption. ENETFEC is a hardware > programmable > > +packet forwarding engine to provide high performance Ethernet interfac= e. >=20 > It has 1Gbps interface, right? It can be good to give more details on the > Ethernet interface. [Apeksha] Okay. >=20 > > +The diagram below shows a system level overview of ENETFEC: > > + > > + > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D+=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + US +-----------------------------------------+ | Kernel Space > > + | | | > > + | ENETFEC Driver | | > > + +-----------------------------------------+ | > > + ^ | | > > + ENETFEC RXQ | | TXQ | > > + PMD | | | > > + | v | +----------+ > > + +-------------+ | | fec-uio | > > + | net_enetfec | | +----------+ > > + +-------------+ | > > + ^ | | > > + TXQ | | RXQ | > > + | | | > > + | v | > > + > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D+=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D > > + +----------------------------------------+ > > + | | HW > > + | i.MX 8M MINI EVK | > > + | +-----+ | > > + | | MAC | | > > + +---------------+-----+------------------+ > > + | PHY | > > + +-----+ > > + > > +ENETFEC Ethernet driver is traditional DPDK PMD driver running in the > userspace. > > +The MAC and PHY are the hardware blocks. 'fec-uio' is the UIO driver, > ENETFEC PMD > > +uses UIO interface to interact with kernel for PHY initialisation and = for > mapping > > +the allocated memory of register & BD in kernel with DPDK which gives > access to > > +non-cacheable memory for BD. >=20 > Why a specific uio driver, 'fec-uio', is required? I think this is the ma= jor > issue to clarify to proceed. >=20 > In DPDK we have full framework to support uio, to do the all memory > mapping, > interrupt configuration etc..., common to all drivers. > But in this case driver is implemented as virtual driver and it handles i= ts own > uoi handling itself. Why the driver can't use existing support and > implemented > as physical driver? [Apeksha] Yes you are correct. As per our knowledge, UIO framework is there= for VM & PCI bus devices and not for vdev bus devices.=20 That is why we are using standard UIO framework in DPDK to access with kern= el 'fec-uio' driver. In document description I will update the details more precisely. >=20 > btw, what is 'BD'? [Apeksha] BD is Buffer Descriptor. we will update it in v4 patch series. >=20 > > net_enetfec is logical Ethernet interface, created by > > +ENETFEC driver. > > + >=20 > It is confusing to draw 'net_enetfec' as middle man between HW and driver= , > isn't > it same entity as driver? Why the Rx/Tx notation is reverse before and af= ter > net_enetfec, as HW --TX--> net_enetfec --RX--> driver? [Apeksha] yes I do agree. We will update the figure in v4 patch series. >=20 > > +- ENETFEC driver registers the device in virtual device driver. > > +- RTE framework scans and will invoke the probe function of ENETFEC > driver. > > +- The probe function will set the basic device registers and also setu= ps BD > rings. > > +- On packet Rx the respective BD Ring status bit is set which is then = used > for > > + packet processing. > > +- Then Tx is done first followed by Rx via logical interfaces. > > + > > +ENETFEC Features > > +~~~~~~~~~~~~~~~~~ > > + > > +- Linux > > +- ARMv8 > > + > > +Supported ENETFEC SoCs > > +~~~~~~~~~~~~~~~~~~~~~~ > > + > > +- i.MX 8M Mini > > + > > +Prerequisites > > +~~~~~~~~~~~~~ > > + > > +There are three main pre-requisites for executing ENETFEC PMD on a i.M= X > 8M Mini > > +compatible board: > > + > > +1. **ARM 64 Tool Chain** > > + > > + For example, the `*aarch64* Linaro Toolchain > ases.linaro.org%2Fcomponents%2Ftoolchain%2Fbinaries%2F7.4- > 2019.02%2Faarch64-linux-gnu%2Fgcc-linaro-7.4.1-2019.02-x86_64_aarch64- > linux- > gnu.tar.xz&data=3D04%7C01%7Capeksha.gupta%40nxp.com%7C74fdc59c > 47574d828f7608d97e7a4df3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7 > C1%7C637679886024819097%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w > LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am > p;sdata=3DLun43hJqB%2Fw%2Bd07v9hOn3NrsRdlmeyoesiRrJLt81p8%3D& > reserved=3D0>`_. > > + > > +2. **Linux Kernel** > > + > > + It can be obtained from `NXP's Github hosting > ce.codeaurora.org%2Fexternal%2Fqoriq%2Fqoriq- > components%2Flinux&data=3D04%7C01%7Capeksha.gupta%40nxp.com% > 7C74fdc59c47574d828f7608d97e7a4df3%7C686ea1d3bc2b4c6fa92cd99c5c3016 > 35%7C0%7C1%7C637679886024819097%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > 7C3000&sdata=3D0EFI%2ByEZB1PvYGt%2BemrLA2poBMdgPFTti9S7CO0qP > X4%3D&reserved=3D0>`_. > > + >=20 > There are multiple branches in that repo, is there more detail on which > branch > to use? [Apeksha] lf-5.10.y branch, will add it in v4 patch series. >=20 > > +3. **Rootfile system** > > + > > + Any *aarch64* supporting filesystem can be used. For example, > > + Ubuntu 18.04 LTS (Bionic) or 20.04 LTS(Focal) userland which can be > obtained > > + from `here > age.ubuntu.com%2Fubuntu- > base%2Freleases%2F18.04%2Frelease%2Fubuntu-base-18.04.1-base- > arm64.tar.gz&data=3D04%7C01%7Capeksha.gupta%40nxp.com%7C74fdc5 > 9c47574d828f7608d97e7a4df3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C1%7C637679886024819097%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000& > amp;sdata=3D18AItEAX8Yp6bsyDdrGmVCu%2BQ9%2FJroX%2BS9CadeKsS%2Bw > %3D&reserved=3D0>`_. > > + > > +4. The Ethernet device will be registered as virtual device, so ENETFE= C has > dependency on > > + **rte_bus_vdev** library and it is mandatory to use `--vdev` with v= alue > `net_enetfec` to > > + run DPDK application. > > + > > +Driver compilation and testing > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Follow instructions available in the document > > +:ref:`compiling and testing a PMD for a NIC ` > > +to launch **dpdk-testpmd** > > + > > +Limitations > > +~~~~~~~~~~~ > > + > > +- Multi queue is not supported. > > +- Link status is down always. >=20 > This seems a big limitation, it can prevents some application to use the = NIC. > What prevents the having proper link status? [Apeksha] I agree this is a bug. 'link change status' support is planned to= be implemented in future. Meanwhile we will set link default status to UP so all other applications w= ork seamlessly. >=20 > > +- Single Ethernet interface. >=20 > What does 'Single Ethernet interface' means, can you please elaborate? [Apeksha] Your observation is correct, this is mistake from our side. This is hardware feature i.e. only one Ethernet interface available on i.MX 8M Mini. We realize that this is not a limitation. We will update it. >=20 > <...> >=20 > > + > > +#define ENETFEC_NAME_PMD net_enetfec > > +#define ENETFEC_VDEV_GEM_ID_ARG "intf" >=20 > Is this devarg used at all? [Apeksha] No, I will update in v4 patch series. >=20 > <...> >=20 > > +/* Common log type name prefix */ > > +#define ENETFEC_LOGTYPE_PREFIX "pmd.net.enetfec." > > + >=20 > Is this macro used at all? [Apeksha] No, I will update in v4 patch series. >=20 > <...> >=20 > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright 2021 NXP > > + > > +if not is_linux > > + build =3D false > > + reason =3D 'only supported on linux' > > +endif > > + > > +deps +=3D ['common_dpaax'] > > + >=20 > Why there is a dependency to dpaax? [Apeksha] There was some common MACROs that we are using & are part of dpaa= x (drivers/common/dpaax/compat.h). As per suggestion we will remove this dependency in v4 patch series.