From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13C6BA0C41; Tue, 5 Oct 2021 07:24:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8B25410DC; Tue, 5 Oct 2021 07:24:24 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130050.outbound.protection.outlook.com [40.107.13.50]) by mails.dpdk.org (Postfix) with ESMTP id 0DF4D4068F for ; Tue, 5 Oct 2021 07:24:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ngbOwA2R9xKDPNdCwO1dw7KivRkf8lep6iNPuxoCdtXQzVW/BBaE/UzLMEFxqArJLN3Yuk0VgTpee3VRgW8Wi45LL2boJMjAoNx8p6C3NVFZIphr5j5BQrAX7W+ffGSwpFW6n1/kd0dEgv9640Pl5nT3BZGVqrXD8TYK5CWftQrbQQVMrG0A0mp0OlrgMUKPXXuL057lXa8illIS23z7qOU76RbE2zhIC+RIGkFVW5c6WzH0KOG2d4LYMT8btpOYbM2EPruaqYxM4nXvFoYOHhCXv1T7mAlF7+aokF86bAV64lPmB5ZJ4+02+JtqqemT76WE5HbJETC+xe8A+csRWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0GoqJQ9Oa9kxxFeqsjkQ3d+WKnA8dOo+FqNYO8nEp8A=; b=jHCxQlmNBGAyDRDihVNu1kixzDdd7L2L3NUKCjNeO0J/uZcH5CQ3N4O/UrfziAuzlb+pYvEGwC85P9StHLmNUbTu+m38be2NF0eqlW5IXJGZK6wA7uRUX6WkwDSpOVDTwEXxfVAc6b+rk9L3OlzR1valp7zjcrpz9+S0Lwb01Ee1A1bWBiAD5z/h8Mw5dnv7qygpN7S6Np7Rpk3Yyw4Vlrm7HrK97pIKIhc6ELb628G/bLxOv4yrQcwJjDz0mcWLTC9ioqLVASfuUkBJ/GBDM0t1KGKjNRAGYFyPSYmnp5su5JjTDQcmJ1MddysRXX2T6ZcfbOa5vOpGaGmE8vQz0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0GoqJQ9Oa9kxxFeqsjkQ3d+WKnA8dOo+FqNYO8nEp8A=; b=sDYgo23iRLFHFI79l+7C9MybnUMeSeUczHHtUlenVo9eawAE3AXjF08r5Jg481LNyIliBOAAZZ3WL+qWJCFgEn1Ls1MFAu0+9rTiNeCepXXWo+b82eb8rvYUt0FLY3nOT0nj47U/9h0jdC9uYoWQGwGguKurIcGDk8tpVGXhElw= Received: from VI1PR04MB6816.eurprd04.prod.outlook.com (2603:10a6:803:12d::18) by VI1PR04MB4655.eurprd04.prod.outlook.com (2603:10a6:803:72::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 5 Oct 2021 05:24:21 +0000 Received: from VI1PR04MB6816.eurprd04.prod.outlook.com ([fe80::19a4:1404:5f97:ff4d]) by VI1PR04MB6816.eurprd04.prod.outlook.com ([fe80::19a4:1404:5f97:ff4d%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 05:24:21 +0000 From: Apeksha Gupta To: Ferruh Yigit , "david.marchand@redhat.com" , "andrew.rybchenko@oktetlabs.ru" CC: "dev@dpdk.org" , Sachin Saxena , Hemant Agrawal Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver Thread-Index: AQHXpbtgnSeLbkrXsUOYWqvWGsyylauxetKAgAyQ4VCAAE7DgIAFq27Q Date: Tue, 5 Oct 2021 05:24:20 +0000 Message-ID: References: <20210909204314.1826-1-apeksha.gupta@nxp.com> <20210909204314.1826-2-apeksha.gupta@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6fc891a1-dc0d-4331-477c-08d987c062da x-ms-traffictypediagnostic: VI1PR04MB4655: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wHG62NBRmW4kKznWeBYfauNg4e3ZU2mazDLLucVwD9u0nREeEecexoFgqDc0PpyDfMGFC7z7cOT5HP/vqBKdslA1rxGK7zoJxZ11Md3aC5q5yrxR+jZ73hTKtZ4zBHJ0AbjENcPlqZE0VJyFqHgBMC/wZ7FmpJNnShqcD6JFb/mYc4z1PgYkSy1ML/fZo8hdKQPVKczTdkN2qKwBPp1pQeeG5+jg2YBfl2vis7zeVI0ozGGTipIPa2PO9yAfp0W6OnbQV8y4OvJEKkKezYzvr+8jyb2+dXhOn+Bu6GObADBqJVtoMJ0UsvXIYV9s3L+FJuNlJo9vCXx6nXB69hKJRavVnRbsbDC5flYq3lKJJ50Gwe5xXjWC9Qefqr6Pqbe/ZXUrBF1YMpWjoWA21yMd0LKqkkBbuylIRD+9I671GnaGEbmknk3jHAiX4jFFGUzy1ZB2iLGzoObhqIHWT9mAp4KrUAa+poT8q17GCtErzOlWbd6KpEn5Lg5W7FzYnd2uyDeUJb+PS5WNZZKktSTSjY3iuC49hxWk4nwOR43AQnKIQmfbz1x/tE8/P5RSG/4xamvb8WNKA0H0Sxgx997Qfag1b8MsKYyPVq1U3ttI2yRZkkiG8IzHdLwozxkYCWByCUeKZc19eN1XVF7NyEaKmt/+wcf0VXWOjnBeoBMzmf/0BT5Aw0hZJgvcaf92xFJ1YAFEM94qi8z5fz/eO5BFFpPDNMhyhsy5LxZlQXOsJ3IGkUFCagBLv9zQH+bZaiSk1CBnEZCNePjAALKnWIPRf+4BmWx8hRuE/Pocz9muf08= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB6816.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(9686003)(53546011)(110136005)(7696005)(122000001)(54906003)(71200400001)(2906002)(83380400001)(6506007)(33656002)(8936002)(52536014)(55016002)(4326008)(86362001)(66946007)(64756008)(76116006)(66446008)(66476007)(316002)(44832011)(186003)(508600001)(26005)(5660300002)(66556008)(8676002)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ebHzsEYnKqgnguotP3hiHS3eq8ArKPxjXUDi6Lxh4hgEaOFJ9o4JUhO6NPzk?= =?us-ascii?Q?p0CG4zA4LLMjrGQM16x8phu1FKejHK/G49GNTrKOevTOTjcFHr2sqSnis9HJ?= =?us-ascii?Q?ykDJBCIJmCEuvxzC2mOU1k+AiRkfhAt9W5Pa3PSW99R/2bxPchFygzQbWPFX?= =?us-ascii?Q?13iNxaOaVyiJYFaOqjz5ErYgFtNTUYyhtV3QIkSk9B+IJoDv7WGCaeOSzuHv?= =?us-ascii?Q?DvE+jAVo/JfKpdCxp1mPpmCd2sGbpKITTcRCvzHM3yc652hp/sFqQpp+fZMQ?= =?us-ascii?Q?CcDPWomdVGrl23DJPDR92+dTMAPyAI1JGjZ8p+0+m4fDmdi4obGBJocuJsF6?= =?us-ascii?Q?s053lvh3JhA4RHh0Aqs+X1T0k9vZTXqiNyB3U664k/k+AhKyw10PatqmEAa1?= =?us-ascii?Q?wFvBb8e2DtlLlCFEKHcEcAHTOCB9I7HX82WK4pT5YcpMZaS1BvLMMht8SLIH?= =?us-ascii?Q?qFVSz3b13IL/viU0rFfwJtX95ky88rxujRrNl9JX6mM1d9rnKzTr81BRGwxI?= =?us-ascii?Q?c2o9Rt9CqIWLPy4hUfSqOuWsZmFY/GsIKoVv0oGlrbKkCSFT+IrFg/2k01Wm?= =?us-ascii?Q?CwCtOrFpLfjyP420oX2R0JXL1233Aa8nj9l2/GNqdItphx3CwqI9AbtmROKp?= =?us-ascii?Q?+16Apzv2L66M5uRz+yFKh4I16ENXayjR3MgK1J0mN0z8AiKgdpLJSkZjGMtP?= =?us-ascii?Q?z+8vhvbKDtIfNFU3ZIpfuDyehePNv/hjkAgUT5EwupdVE3VpncNkXwaUMf+E?= =?us-ascii?Q?qQ1jBkCEPRGFL0hdD8Kgq7rxNTFL2oOG0JYQgPoGvK/KBsjC3Zr9lD54u5My?= =?us-ascii?Q?BEeIwZKttKvoT9YcmfVzlSr/1w020lVsemRvyqA86pQn1vfE2CtvdJ5zsOrl?= =?us-ascii?Q?SVjssqsm6pT7DwHb6I5OIki780Z4IBqEuqz4HRqVETFFiJHu7By/fcjqRcFp?= =?us-ascii?Q?6jj2YIDB5Kz/je3oHstA2FmJcYrx1diIBJCJKrWQDTBlnawrGuCqclWFuTr1?= =?us-ascii?Q?hHhK/aJZ/UAP+IvzPQlF9Zar7GfKmOQA/lX/jnYICHjXMiUJKgNB9Mw6MyYR?= =?us-ascii?Q?AetmcsDBaplts81VcepisPr6+tPQOgWQufGf79aJ2Trdi+H7KpH506Z/GGsj?= =?us-ascii?Q?paIKcvHxIIicCQmLXUrR1dbSyRNM3Bkhy2gnRG8paJ/LlOysBYJn+6AKK9IR?= =?us-ascii?Q?M4x6bqfxlFQXnJWiPijcs1eYznefWiKmK4BkO/xjO450JFXn1FlIszZfKzUX?= =?us-ascii?Q?dy7s/epf+J8Oc1jMXnhH5rY4CDUG0/DMVWQGW3i7Kiv1li4WJ/iyiv3YpTp/?= =?us-ascii?Q?4tM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB6816.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc891a1-dc0d-4331-477c-08d987c062da X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2021 05:24:20.9677 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YNZh/r+9gCLy2EGf3oZSz+AtbEhZkZlS7KVFP1eA0CpekOSkOyYKBg1QXO9Pbbi7e0BD0uJMlfUcxJeim2IBeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4655 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ferruh Yigit > Sent: Friday, October 1, 2021 8:15 PM > To: Apeksha Gupta ; > david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru > Cc: dev@dpdk.org; Sachin Saxena ; Hemant > Agrawal > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce N= XP > ENETFEC driver >=20 > Caution: EXT Email >=20 > On 10/1/2021 11:22 AM, Apeksha Gupta wrote: > >> -----Original Message----- > >> From: Ferruh Yigit > >> Sent: Thursday, September 23, 2021 3:40 PM > >> To: Apeksha Gupta ; > >> david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru; > >> ferruh.yigit@intel.com > >> Cc: dev@dpdk.org; Sachin Saxena ; Hemant > >> Agrawal > >> Subject: [EXT] Re: [dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce NX= P > >> ENETFEC driver > >> > >> Caution: EXT Email > >> > >> On 9/9/2021 9:43 PM, Apeksha Gupta wrote: > >>> ENETFEC (Fast Ethernet Controller) is a network poll mode driver > >>> for NXP SoC i.MX 8M Mini. > >>> > >> > >> Hi Apeksha, > >> > >> Before going into details, I have some high level comments to start wi= th, > >> please > >> find comments below. > >> > >>> This patch adds skeleton for enetfec driver with probe function. > >>> > >>> Signed-off-by: Sachin Saxena > >>> Signed-off-by: Apeksha Gupta > >> > >> <...> > >> > >>> +++ b/doc/guides/nics/enetfec.rst > >>> @@ -0,0 +1,122 @@ > >>> +.. SPDX-License-Identifier: BSD-3-Clause > >>> + Copyright 2021 NXP > >>> + > >>> +ENETFEC Poll Mode Driver > >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D > >>> + > >>> +The ENETFEC NIC PMD (**librte_net_enetfec**) provides poll mode > >> driver > >>> +support for the inbuilt NIC found in the ** NXP i.MX 8M Mini** SoC. > >>> + > >>> +More information can be found at NXP Official Website > >>> > >> > + >> ww.nxp.com%2Fproducts%2Fprocessors-and-microcontrollers%2Farm- > >> processors%2Fi-mx-applications-processors%2Fi-mx-8-processors%2Fi- > mx- > >> 8m-mini-arm-cortex-a53-cortex-m4-audio-voice- > >> > video%3Ai.MX8MMINI&data=3D04%7C01%7Capeksha.gupta%40nxp.com > >> %7C74fdc59c47574d828f7608d97e7a4df3%7C686ea1d3bc2b4c6fa92cd99c5 > c30 > >> > 1635%7C0%7C1%7C637679886024819097%7CUnknown%7CTWFpbGZsb3d8ey > >> > JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > >> > 7C3000&sdata=3DTjuqIfC8yXwBa3DLCgA7djItfV0UmZ6lA3uLDQ7TFwY%3D > >> &reserved=3D0> > >>> + > >>> +ENETFEC > >>> +------- > >>> + > >>> +This section provides an overview of the NXP ENETFEC and how it is > >>> +integrated into the DPDK. > >>> + > >>> +Contents summary > >>> + > >>> +- ENETFEC overview > >>> +- ENETFEC features > >>> +- Supported ENETFEC SoCs > >>> +- Prerequisites > >>> +- Driver compilation and testing > >>> +- Limitations > >>> + > >>> +ENETFEC Overview > >>> +~~~~~~~~~~~~~~~~ > >>> +The i.MX 8M Mini Media Applications Processor is built to achieve bo= th > >> high > >>> +performance and low power consumption. ENETFEC is a hardware > >> programmable > >>> +packet forwarding engine to provide high performance Ethernet > interface. > >> > >> It has 1Gbps interface, right? It can be good to give more details on = the > >> Ethernet interface. > > [Apeksha] Okay. > >> > >>> +The diagram below shows a system level overview of ENETFEC: > >>> + > >>> + > >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D+=3D=3D=3D=3D=3D > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >>> + US +-----------------------------------------+ | Kernel Spac= e > >>> + | | | > >>> + | ENETFEC Driver | | > >>> + +-----------------------------------------+ | > >>> + ^ | | > >>> + ENETFEC RXQ | | TXQ | > >>> + PMD | | | > >>> + | v | +----------+ > >>> + +-------------+ | | fec-uio | > >>> + | net_enetfec | | +----------+ > >>> + +-------------+ | > >>> + ^ | | > >>> + TXQ | | RXQ | > >>> + | | | > >>> + | v | > >>> + > >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D+=3D=3D=3D=3D=3D=3D > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D > >>> + +----------------------------------------+ > >>> + | | HW > >>> + | i.MX 8M MINI EVK | > >>> + | +-----+ | > >>> + | | MAC | | > >>> + +---------------+-----+------------------+ > >>> + | PHY | > >>> + +-----+ > >>> + > >>> +ENETFEC Ethernet driver is traditional DPDK PMD driver running in th= e > >> userspace. > >>> +The MAC and PHY are the hardware blocks. 'fec-uio' is the UIO driver= , > >> ENETFEC PMD > >>> +uses UIO interface to interact with kernel for PHY initialisation an= d for > >> mapping > >>> +the allocated memory of register & BD in kernel with DPDK which give= s > >> access to > >>> +non-cacheable memory for BD. > >> > >> Why a specific uio driver, 'fec-uio', is required? I think this is the= major > >> issue to clarify to proceed. > >> > >> In DPDK we have full framework to support uio, to do the all memory > >> mapping, > >> interrupt configuration etc..., common to all drivers. > >> But in this case driver is implemented as virtual driver and it handle= s its > own > >> uoi handling itself. Why the driver can't use existing support and > >> implemented > >> as physical driver? > > [Apeksha] Yes you are correct. As per our knowledge, UIO framework is > there for VM & PCI bus devices and not for vdev bus devices. >=20 > That is part of the comment, why driver implemented as vdev instead of > physical > device? > What is the actual device bus? [Apeksha] Actual bus is 'platform' bus which is not supported in DPDK.