From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50057.outbound.protection.outlook.com [40.107.5.57]) by dpdk.org (Postfix) with ESMTP id B3EC41C743; Mon, 14 May 2018 12:39:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CRVQsbVRql/eSY4VLIzRKhm46tJ3O5trqZMwBKFnYeQ=; b=QElt4g0HcdeqoliLutcMjFaEbSg+1PZ33RG7mg5l/dpY8hosOSz7Hz4OjF4AwrtjGxWAtDRr5WgPBWGUHZqcJPqeLbL6aF9vhP9de8JtY/y2Alyr18f7sk2xf4SxCqxbUlmMgNbIeq6rxx8hz69Wls3a0IJQWq4YAezvGjdjI2I= Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com (10.168.137.20) by VI1PR0501MB1951.eurprd05.prod.outlook.com (10.166.44.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Mon, 14 May 2018 10:38:57 +0000 Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::49ca:b540:8f36:c063]) by VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::49ca:b540:8f36:c063%17]) with mapi id 15.20.0755.018; Mon, 14 May 2018 10:38:57 +0000 From: Matan Azrad To: "zhiyong.yang@intel.com" , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name Thread-Index: AQHT6zKbc7Z531fT80CQ1G+KFx7J26QvCEeQ Date: Mon, 14 May 2018 10:38:56 +0000 Message-ID: References: <20180514032048.34896-1-zhiyong.yang@intel.com> In-Reply-To: <20180514032048.34896-1-zhiyong.yang@intel.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB1951; 7:ZhS6YIEoR3MR5AbNk7FpPtTZN/7JhBSJbIFUiXjYpD/pkYg/btuFik9xTXLDxPv4bPd78Kz9jqPNfJ0F5srI2YsHYSqPLK2hNG6rM6w9NZI2A/2Oam22UhVydp5MTGHSoP0EyBdmPsa4NALoSVCCBSR9cPqT5PUiT96mg50+Ofhj6cJYTpxkduGVAIz0oapYoSBGU0V/ssK+1FeH44WN+LSRYufvnUTuDdNumeiz37O/xK1qpcGRkWmZ8xM94jpR x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB1951; x-ms-traffictypediagnostic: VI1PR0501MB1951: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0501MB1951; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB1951; x-forefront-prvs: 067270ECAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(39860400002)(396003)(376002)(346002)(199004)(189003)(99286004)(7696005)(2906002)(5250100002)(6436002)(74316002)(14454004)(2900100001)(3660700001)(110136005)(54906003)(59450400001)(4326008)(186003)(6506007)(105586002)(3280700002)(229853002)(26005)(102836004)(76176011)(6246003)(5660300001)(2501003)(86362001)(106356001)(81166006)(305945005)(55016002)(81156014)(66066001)(8676002)(8936002)(7736002)(11346002)(476003)(3846002)(6116002)(53936002)(9686003)(486006)(478600001)(33656002)(316002)(68736007)(97736004)(25786009)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB1951; H:VI1PR0501MB2608.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:3; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /ADJ6Ytwp1QMRSJJsJUUMQ3a/W+Pot+QvIC4t2YtDkzXH7fbM4gfNJvYJdrXjlbsIT/NYQT1dsnbkZb06qHShoW/aWZXuhPdN4vk4o/ZV5SG3NlKnQPFwjHOkxVw+KSHj7Le/vWe/AraidrqOM3pdzDZbzUuBnXj6QBWZbkXh7yDoddwsc5IscDTOqNQ0MJI spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 41a1e8b6-1102-44c7-5e07-08d5b986e58c X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41a1e8b6-1102-44c7-5e07-08d5b986e58c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2018 10:38:56.9324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1951 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 10:39:00 -0000 Hi=20 From: zhiyong.yang@intel.com > The second parameter "name" in the function rte_eth_dev_detach has been > already redefined as "char *name __rte_unused", "port_id" is printed inst= ead > of "name" in testpmd. >=20 > Fixes: b65ecf199324 ("devargs: rename legacy API") > Cc: stable@dpdk.org Really minor : Missing empty line here. > Signed-off-by: Zhiyong Yang Acked-by: Matan Azrad > --- > app/test-pmd/testpmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 664c43554..02a28199b 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1985,7 +1985,7 @@ detach_port(portid_t port_id) > port_flow_flush(port_id); >=20 > if (rte_eth_dev_detach(port_id, name)) { > - TESTPMD_LOG(ERR, "Failed to detach port '%s'\n", name); > + TESTPMD_LOG(ERR, "Failed to detach port %u\n", port_id); > return; > } >=20 > @@ -1993,8 +1993,8 @@ detach_port(portid_t port_id) >=20 > update_fwd_ports(RTE_MAX_ETHPORTS); >=20 > - printf("Port '%s' is detached. Now total ports is %d\n", > - name, nb_ports); > + printf("Port %u is detached. Now total ports is %d\n", > + port_id, nb_ports); > printf("Done\n"); > return; > } > -- > 2.14.3