From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70044.outbound.protection.outlook.com [40.107.7.44]) by dpdk.org (Postfix) with ESMTP id 7CD17288C for ; Thu, 26 Jul 2018 16:35:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xOHsniKJF21WkuzDSnHH+Q/TBixsW6271f4b0yhMVH8=; b=sZY2qyyflEDd9SEXM6e2qntKGU1j+48iQG7CV3oxtGrtg+MjYi+X37R7ucBC/0I4ISxFXBUjK1OfVU0e3jrRSFuctYpvDHFYiNLzppFDbq5stGd/yt3XRmwmw4ylIiV+7Ba/hqyp+kgqpD9QqmWuBpGTlDxxdrIQ9APY4OonYSs= Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com (10.168.137.20) by VI1PR0501MB2847.eurprd05.prod.outlook.com (10.172.11.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.17; Thu, 26 Jul 2018 14:35:42 +0000 Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::dd44:4544:a34b:7e1d]) by VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::dd44:4544:a34b:7e1d%9]) with mapi id 15.20.0995.014; Thu, 26 Jul 2018 14:35:42 +0000 From: Matan Azrad To: Mordechay Haimovsky CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx4: verify RSS supports num Rx Qs being used Thread-Index: AQHUJCZ44EhOOgClPkO2z43V6/fSbqShktXw Date: Thu, 26 Jul 2018 14:35:42 +0000 Message-ID: References: <1532530059-7319-1-git-send-email-motih@mellanox.com> In-Reply-To: <1532530059-7319-1-git-send-email-motih@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2847; 6:Zid3O8iEiAjAE4S1UpI3y8gLPUsIz99l2qnGemc+DU4ET5tu6E6r95mgP5fkmIToqbhMui07yEt0J8NSvgRmLETuwwPqHeHWgcIPb68dq2ZI1kvudg0kncGnap8ZMWGtdRhXBxNC1XSdGLyk0yfW5vXwOp+A/qF4UQqyMpymGjSVorn4Ip8XQr5zv3Qd9TrD0+fQHSVf4K9g1cVHt4FUsz+oHi6ZVe/0NiA/gZuf/F4iHcmKpxwuicO7p+X2eRA1fT+GTuQSfGkzVCVer8lQnNUBNYUDok88xcABZjQ5AG56H7PNgfgkWEny5PANMb2EtVyUYWl/ljBmxGYJBRsneDn53133GPRZnDLKisDKt1gkg1s/BJ95boJRMry2gmQggB4mmbwQF8Y6LomoYT4V1LfGlf4zUzVRKfVSMbKOBkIfMNvoBkGZsWus2XC15C5V+yB6/g2CZ+tfcqUSJoX2lQ==; 5:1/5jcN2pervmdqSCit9BXU9zBhyPue+WOZt46bpmUlCeAtlOKVa8pX7w9BCDiHa0fFpvnzdRkwgBnfeZJSqsVMteje8YxCP6AMUfCeFoypUKUbTn5iCknQGve/zofq2rv7B7B/+6AAaCfCG6RjrSUJ3DmYnu24IB6mo1AQGz9x4=; 7:E74BomoQe4DFVN9ldbyombmQZhzL8JEmuqblWmHtk8KUpVwa6IlQ0Lq9Gr71fsSeCYNvqCOwvJh9cLuXxaLzry/q9Xpku6V5rBFz06pRvB0YUTK606Is5WNpHxfMmPzbxqT9H8sPnx4FWG/yPlQUfVwKQdQlLYD6rw9Lc9AFxaFUkdKiB4xWrDDp4K+ismymXWCxbIFHmrdxb/8uTZRpZvAtyJqtuz8PTgxre8k0xY+MI+z2dT0b1DWH+8OCQaDc x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 5dfd1510-c124-4ea8-a888-08d5f30510f9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2847; x-ms-traffictypediagnostic: VI1PR0501MB2847: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2847; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2847; x-forefront-prvs: 07459438AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(366004)(376002)(346002)(136003)(189003)(199004)(8936002)(74316002)(25786009)(11346002)(2906002)(6436002)(81156014)(81166006)(8676002)(7736002)(305945005)(9686003)(55016002)(476003)(3846002)(14454004)(6116002)(97736004)(256004)(478600001)(4326008)(6862004)(229853002)(486006)(6246003)(53936002)(5660300001)(7696005)(6636002)(76176011)(99286004)(5250100002)(106356001)(446003)(6506007)(102836004)(105586002)(26005)(33656002)(66066001)(86362001)(575784001)(2900100001)(316002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2847; H:VI1PR0501MB2608.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Mf4lMrogWOJVilt78uR5DtSFZGgWtIbzSGN6awP68YJDLu4XSpVtLYZ6/jY/P+KDh3tqn+DcZ8GErnvZFZCi5KgBqq/KNkrIDwxvEyav3vAhJKEM24vlPEeAizfz130x7mX5bV8YOl9mUJiH5och8pBo1IZCdETswqwfoyhxyzLgzEY8xvjRvvZ0X1MNYA3BF4cqoyI4dAqBgTj89de+JoQWswScBrsR7UUCZhhQdfa9HU1YClUrT6zIr8WYrC1foNO0xWofHd5OKNmM5nYt0qPDjiZ+Qwm+UfXHOgZwR/4Idhexz1cPFHg0rlq58rjMziHOvrvyRNScuHDDW5mzSN5UCZKzg3MSNeSMo1Ue5VA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dfd1510-c124-4ea8-a888-08d5f30510f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2018 14:35:42.6882 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2847 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 14:35:44 -0000 Hi Moti Small comment below. From: Mordechay Haimovsky > This patch verifies that the number of Rx queues configured for RSS is > supported by the device hardware. > RSS support in mlx4 requires contiguous chunk of QPs to be reserved, ther= e is a > hardware limitation on the amount of contiguous QPs which is reported by = the > hardware. Ignoring this value will cause Rx queues creation to fail. >=20 > Signed-off-by: Moti Haimovsky > --- > drivers/net/mlx4/mlx4.c | 3 +++ > drivers/net/mlx4/mlx4.h | 1 + > drivers/net/mlx4/mlx4_rxq.c | 6 ++++++ > 3 files changed, 10 insertions(+) >=20 > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index > c67d2c0..defc0d4 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -673,6 +673,9 @@ struct mlx4_conf { > &device_attr_ex); > DEBUG("supported RSS hash fields mask: %016" PRIx64, > priv->hw_rss_sup); > + priv->hw_rss_max_qps =3D > + > device_attr_ex.rss_caps.max_rwq_indirection_table_size; > + DEBUG("MAX RSS queues %d", priv->hw_rss_max_qps); > priv->hw_fcs_strip =3D !!(device_attr_ex.raw_packet_caps & >=20 > IBV_RAW_PACKET_CAP_SCATTER_FCS); > DEBUG("FCS stripping toggling is %ssupported", diff --git > a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h index 89d8c38..e6fb93= 4 > 100644 > --- a/drivers/net/mlx4/mlx4.h > +++ b/drivers/net/mlx4/mlx4.h > @@ -95,6 +95,7 @@ struct priv { > uint32_t hw_fcs_strip:1; /**< FCS stripping toggling is supported. */ > uint32_t tso:1; /**< Transmit segmentation offload is supported. */ > uint32_t tso_max_payload_sz; /**< Max supported TSO payload size. > */ > + uint32_t hw_rss_max_qps; /**< Max Rx Queues supported by RSS. */ > uint64_t hw_rss_sup; /**< Supported RSS hash fields (Verbs format). */ > struct rte_intr_handle intr_handle; /**< Port interrupt handle. */ > struct mlx4_drop *drop; /**< Shared resources for drop flow rules. */ > diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c in= dex > 0cd9560..e8bef1d 100644 > --- a/drivers/net/mlx4/mlx4_rxq.c > +++ b/drivers/net/mlx4/mlx4_rxq.c > @@ -338,6 +338,12 @@ struct mlx4_rss * >=20 > if (priv->rss_init) > return 0; > + if (priv->dev->data->nb_rx_queues > priv->hw_rss_max_qps) { > + ERROR("RSS does not support more than %d queues", > + priv->hw_rss_max_qps); > + rte_errno =3D EINVAL; What's about E2BIG ? > + return -rte_errno; > + } > /* Prepare range for RSS contexts before creating the first WQ. */ > ret =3D mlx4_glue->dv_set_context_attr > (priv->ctx, > -- > 1.8.3.1 Besides that; Acked-by: Matan Azrad