From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0087.outbound.protection.outlook.com [104.47.2.87]) by dpdk.org (Postfix) with ESMTP id 7298F1C01 for ; Sun, 29 Jul 2018 10:12:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bQz8CRVR6axtzzUw8l4Shr3mnZzQuxnjWnphwRTgyLw=; b=EX8yw9Pn9/Bh8YnKslG1cjrSpj7zIl3c7/jQy7iATMNltyrWXUApu25ehPID8s9RnKdaqCbCOdBQ9/Diyt2k0iiCJqqEoUtp4s2vwwQ6vd5QE/eq1F0rePo9rN1Kc3cj2ivgAQo6zgsjvjYpVSUQfnNHSIDGHf4y5tjrwmVPrxA= Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com (10.168.137.20) by VI1PR0501MB2046.eurprd05.prod.outlook.com (10.167.195.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Sun, 29 Jul 2018 08:11:59 +0000 Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::dd44:4544:a34b:7e1d]) by VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::dd44:4544:a34b:7e1d%9]) with mapi id 15.20.0995.020; Sun, 29 Jul 2018 08:11:59 +0000 From: Matan Azrad To: Matan Azrad , Mordechay Haimovsky CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used Thread-Index: AQHUJxPSGOgSEsnh9U2+jUUH5vA3PA== Date: Sun, 29 Jul 2018 08:11:58 +0000 Message-ID: References: <1532530059-7319-1-git-send-email-motih@mellanox.com> In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2046; 6:wPI+ji3uay8pQ5cgqxdPohlL59GPr2+ED6kqyzFZft448FcdoyA/PwvYNmHEd18nSMB/IFGHMMQYER7KAc/HP+QyZr1Gg+oCMCvyKFDJL9Z2FzMNPEeFtPgrRZCW+pxJn5j7QXFSkT2NV5Z5nIzY1r+DIlHjH7gW3ZLuYMDqEwZjleCEemuULBHHLcJOKUwreskGEJ7Ynk4t27oWuWVUjknurnNDr9jWwQT5jCZ6OT4ZKbzyRA8ckh1PbqCrx734/mt8JOmhcxa0SLizIC62cwiLGvVMBhzxKLL9WoKat/rS+q/tPjGBFl3HEtOST/vb2G6AzIfYs1eTI1uM53diaM9BSWrO5HwsS94CceUgmFm7Afwn287GxieeUpNtEpSK07vGWtBb5ahrpeIuB+VRBLy8nlD9PAxG5MzqyP1QPxUVb7IxzCwhXnIZNcmoexS3D5mFha+xySn9Qmw8Mlqcow==; 5:7TOuII8BLX60B5DD14s71Nq3I2j0KXTOQJ+P3nIKnXTgF9ZkAv8rGQptQHPipc6pnO4V1v6htq+R2HndA48evcteP0zyilX8kxDkjPXj77Fx0prMcKxgYoFDc5RUtlV2AHO2h3JVVQvLFHdCUqycZW/ou8Ls05gI51eqiSr2FUo=; 7:IRXZOWZzLpSzZl9vGZFFGQvUQgm92v5LMrPaXujq8JzI7pswfy4HmXX0Tq3ReSKc40ni5FM55mapeCGaIGALVIXSaSPtbWpFxG0Ge/LsLr2DZ33O5bqdXcUOqYgrSvnvNz9U4+LbsqvIOMYRwDh4/+hiuXDiRsijc/JjZ5e3/jUbzmCcKfPOKUCZS5c2A0ufUgisNgzJ8rNNiaqhDlL0GnLQl5g4q6J1wYriuYXsnFOP8ZYiaHxPEawRrjDCER1U x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 03f47d6b-4a3f-44db-7a2a-08d5f52af50b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2046; x-ms-traffictypediagnostic: VI1PR0501MB2046: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2046; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2046; x-forefront-prvs: 0748FF9A04 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(39860400002)(136003)(376002)(189003)(199004)(13464003)(9686003)(68736007)(66066001)(97736004)(2906002)(6436002)(5250100002)(25786009)(74316002)(305945005)(53936002)(7736002)(575784001)(105586002)(86362001)(486006)(7696005)(446003)(99286004)(26005)(102836004)(476003)(76176011)(14454004)(256004)(11346002)(14444005)(53546011)(478600001)(106356001)(6506007)(15650500001)(110136005)(4326008)(316002)(5660300001)(6246003)(3846002)(6116002)(6636002)(55016002)(8936002)(33656002)(81156014)(2900100001)(229853002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2046; H:VI1PR0501MB2608.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Rv+l853wPF8cLuhoeDXND/JIF6j203BJx8GtlXBMX9Vm+JI4BIUGFMFUkyqwq9GgQrAbyAmSf82/6R0tDm0PC9PUgUcKflB67JXibMbDdppUoDkmSFW0cwHxF2yfXlvboLK7qpnYPD0RISbpiOa2y6xO4ZwQbAT1HRIpXfk2/OMv64zCq6+jgFMnpcMweAt9C0IGMPL+7q29gMpF6I4nD+m1VcDQ6HuIfOMT7RRYHl3H5hRcs82+nOoXpY1LWdKCD1GQSMmvSefDY0NdRRrJcVpNPuObBV0ffZLq5ZZibd/tW11CnqIttc53paARy5Yz117E11kWLnM/0bEbrGZF2J2S81NDRyq84IEOAREaD8g= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03f47d6b-4a3f-44db-7a2a-08d5f52af50b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2018 08:11:59.0457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2046 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 08:12:00 -0000 Hi > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matan Azrad > Sent: Thursday, July 26, 2018 5:36 PM > To: Mordechay Haimovsky > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs b= eing > used >=20 > Hi Moti >=20 > Small comment below. >=20 > From: Mordechay Haimovsky > > This patch verifies that the number of Rx queues configured for RSS is > > supported by the device hardware. > > RSS support in mlx4 requires contiguous chunk of QPs to be reserved, > > there is a hardware limitation on the amount of contiguous QPs which > > is reported by the hardware. Ignoring this value will cause Rx queues c= reation > to fail. > > > > Signed-off-by: Moti Haimovsky > > --- > > drivers/net/mlx4/mlx4.c | 3 +++ > > drivers/net/mlx4/mlx4.h | 1 + > > drivers/net/mlx4/mlx4_rxq.c | 6 ++++++ > > 3 files changed, 10 insertions(+) > > > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index > > c67d2c0..defc0d4 100644 > > --- a/drivers/net/mlx4/mlx4.c > > +++ b/drivers/net/mlx4/mlx4.c > > @@ -673,6 +673,9 @@ struct mlx4_conf { > > &device_attr_ex); > > DEBUG("supported RSS hash fields mask: %016" PRIx64, > > priv->hw_rss_sup); > > + priv->hw_rss_max_qps =3D > > + > > device_attr_ex.rss_caps.max_rwq_indirection_table_size; > > + DEBUG("MAX RSS queues %d", priv->hw_rss_max_qps); > > priv->hw_fcs_strip =3D !!(device_attr_ex.raw_packet_caps & > > > > IBV_RAW_PACKET_CAP_SCATTER_FCS); > > DEBUG("FCS stripping toggling is %ssupported", diff --git > > a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h index > > 89d8c38..e6fb934 > > 100644 > > --- a/drivers/net/mlx4/mlx4.h > > +++ b/drivers/net/mlx4/mlx4.h > > @@ -95,6 +95,7 @@ struct priv { > > uint32_t hw_fcs_strip:1; /**< FCS stripping toggling is supported. */ > > uint32_t tso:1; /**< Transmit segmentation offload is supported. */ > > uint32_t tso_max_payload_sz; /**< Max supported TSO payload size. > > */ > > + uint32_t hw_rss_max_qps; /**< Max Rx Queues supported by RSS. */ > > uint64_t hw_rss_sup; /**< Supported RSS hash fields (Verbs format). *= / > > struct rte_intr_handle intr_handle; /**< Port interrupt handle. */ > > struct mlx4_drop *drop; /**< Shared resources for drop flow rules. > > */ diff --git a/drivers/net/mlx4/mlx4_rxq.c > > b/drivers/net/mlx4/mlx4_rxq.c index 0cd9560..e8bef1d 100644 > > --- a/drivers/net/mlx4/mlx4_rxq.c > > +++ b/drivers/net/mlx4/mlx4_rxq.c > > @@ -338,6 +338,12 @@ struct mlx4_rss * > > > > if (priv->rss_init) > > return 0; > > + if (priv->dev->data->nb_rx_queues > priv->hw_rss_max_qps) { > > + ERROR("RSS does not support more than %d queues", > > + priv->hw_rss_max_qps); > > + rte_errno =3D EINVAL; >=20 > What's about E2BIG ? My mistake, The description of E2BIG related to the argument list and not generally for= too big parameters, so no need to change the EINVAL. > > + return -rte_errno; > > + } > > /* Prepare range for RSS contexts before creating the first WQ. */ > > ret =3D mlx4_glue->dv_set_context_attr > > (priv->ctx, > > -- > > 1.8.3.1 >=20 > Besides that; > Acked-by: Matan Azrad