From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20088.outbound.protection.outlook.com [40.107.2.88]) by dpdk.org (Postfix) with ESMTP id 8C6C34C91 for ; Wed, 14 Nov 2018 10:20:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZX3ZP+uTeWiro0wMCz9OKmN2p70Gz2MdqAG6DoWvtzk=; b=Gy8DopP4RX61jAAK9K4X4gDtvkf2v4EOup4u5jQ2INeDexqRh27Ls+jvYypr5HyrFkohbShxNuwhoZVJbvYHlxlCqxo5l+FLUEdUN2eWTGMuByvF6ecvUi2FljA/MOX/1d8u5QtFVJ7AjXiy+E6VfE07ZimDCuF+UwhA+wZQkMU= Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com (52.134.8.154) by VI1PR0502MB2910.eurprd05.prod.outlook.com (10.175.24.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.22; Wed, 14 Nov 2018 09:20:08 +0000 Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4]) by VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4%4]) with mapi id 15.20.1294.045; Wed, 14 Nov 2018 09:20:08 +0000 From: Ophir Munk To: "Zhao1, Wei" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "dev@dpdk.org" , "Peng, Yuan" CC: Asaf Penso , Shahaf Shuler , Thomas Monjalon , Olga Shern , Yongseok Koh Thread-Topic: [PATCH v1] app/testpmd: set default RSS key as NULL Thread-Index: AQHUc42KKl7n13UNvk+JpU+G+ZKXoKVOzRbQgAA/+ZA= Date: Wed, 14 Nov 2018 09:20:08 +0000 Message-ID: References: <1541260478-4621-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0502MB2910; 6:9zeZmPkZL2wYrk2+LyrP5Y6RbSo1IVYVlYHuAyO7UFGwesQcfdDgpnZmLPUEZQ+P6TMoH8vbneQjEAw+dqvQLOvwTQODzrwqHqVshoZWkGC0c37+SFzPleeDeRi+Y5AdIprtxYpDUcVm5NyIex+FVhdx+B0XMLev50kfXpDO5HCN+KC5IXUktUgLjSH64riUrfr1SsMOlbBWts/ZOToGOhxaf4ETXcbKdAx/8iGxex442Flm+DDh4/d1qWaZk3DsW5lMBAniJmmYRWfOY8lpEOC6KVzUTt6phmpaJUImqt4MtBPjioc7Xe+NriMRoVpNrouL7rlAZKUFm3j1JMdtEUL4/XtoA1ycxozvxY+d3kMfny+qjXL5PRMZzAsg/ug9OIEqj2EX3IqDX25HhK8PyANUA7n4slRm+v0JKfGWf6Tc/NtSCUjYAzP+KUuKLpiOoi+OOdXu5g6McUfHLSwOAQ==; 5:M8AvmsPBuSuHUOTd69p7zmpJxi41Vao4aAd6vcT4uIQhRnQJ55XicxrNlUa6SSGkdMSyXG8ZiS2xHobRi3B8meWAzitA6vmg1xSZH/3vvrvdwrEymhb7ejqdC9BxX44rSFy+VoPJ0R122mz37jWRRLEoo8tZaIs3z1F/n9sw0Os=; 7:DA3SVc9wxxfHRDTVYH4j/ajkUCziLwlLrt2SAgESvVESzPhldKRHFeX3fOTVQBlB4Pp3Sswdi7JYRdxGbgnQZJh+Kn1J7OVLuFqu8rz9w1JpEG+3lG4SzFMkWmoe64cocKqvZOK5vXvNbXRZb3HGUA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 6835cd5c-0dc6-4ac7-6f37-08d64a125f45 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0502MB2910; x-ms-traffictypediagnostic: VI1PR0502MB2910: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:VI1PR0502MB2910; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB2910; x-forefront-prvs: 085634EFF4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(136003)(366004)(199004)(189003)(13464003)(102836004)(8936002)(68736007)(26005)(186003)(25786009)(106356001)(105586002)(81156014)(4326008)(33656002)(81166006)(2501003)(8676002)(478600001)(2906002)(3846002)(6116002)(2900100001)(6246003)(229853002)(7696005)(99286004)(97736004)(5660300001)(316002)(76176011)(6436002)(71200400001)(14454004)(53936002)(9686003)(66066001)(486006)(256004)(14444005)(110136005)(55016002)(86362001)(476003)(107886003)(6506007)(11346002)(53546011)(305945005)(446003)(74316002)(71190400001)(54906003)(7736002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB2910; H:VI1PR0502MB3743.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 9jKVG3TVKK56wt57CZz+ihpLXUj13oihv0hxScG6+LZSCwsQNJt806S7S0O5Xf6vKugqBIE3B+rXOqA1B6WJUWYeh0SMKejZ/gBR9kuox9CTVsRpMcQzw/LJtNAAQGF+oMwRcBeLf/vvoXEYLRwFWrHT9vXgWjWLhRdGhTM0SkqhIQhTS23Yu3Q9hHu/3+upNnAxKgZiRLIl6n8pmCxLzIA4MZaR34TPlnWuahAjoPropyZiFAP625MePsMx340Iao3yqi9wNbvRvdKiG1UNhNQhaI5M7WI/dkIz4QwQHoshMnAuGb6YTIGrDwS6wS+VlZD9/+cBv5Uzz/0lPFnIfHkU1gdAyKl4shili2m4Y4E= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6835cd5c-0dc6-4ac7-6f37-08d64a125f45 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2018 09:20:08.6350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2910 Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: set default RSS key as NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 09:20:11 -0000 Hi Zhao, The patch which causes your crash is already reverted (see [1]).=20 You can find it with head of next-net or in RC3 (once it is issued). Please re-test your case after applying the reverting patch. Regards, Ophir [1] Commit 8773db152033 ("app/testpmd: revert setting default RSS") > -----Original Message----- > From: Zhao1, Wei [mailto:wei.zhao1@intel.com] > Sent: Wednesday, November 14, 2018 7:25 AM > To: Ophir Munk ; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard ; dev@dpdk.org; Peng, Yuan > > Cc: Asaf Penso ; Shahaf Shuler > ; Thomas Monjalon ; > Olga Shern ; Yongseok Koh > Subject: RE: [PATCH v1] app/testpmd: set default RSS key as NULL >=20 > Hi, Ophir Munk >=20 > Peng yuan has find this problem with patch , if you use the following > test step, You will find the problem. > She is using i40e nic. >=20 > ./x86_64-native-linuxapp-gcc/app/testpmd -c 1ffff -n 4 - -i --nb-cores=3D= 8 -- > rxq=3D4 --txq=3D4 --port-topology=3Dchained ............... > testpmd> start > testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp > testpmd> end key 67108863 / end > Segmentation fault (core dumped) >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ophir Munk > > Sent: Saturday, November 3, 2018 11:55 PM > > To: Lu, Wenzhuo ; Wu, Jingjing > > ; Iremonger, Bernard > > ; dev@dpdk.org > > Cc: Asaf Penso ; Shahaf Shuler > > ; Thomas Monjalon ; > Olga > > Shern ; Ophir Munk ; > > Yongseok Koh > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: set default RSS key as > > NULL > > > > When creating an RSS rule without specifying a key (see [1]) it is > > expected that the device will use the default key. > > A NULL key is uded to indicate to a PMD it should use its default key, > > however testpmd assigns a non-NULL dummy key (see [2]) instead. > > This does not enable testing any PMD behavior when the RSS key is not > > specified. This commit fixes this limitation by setting key to NULL. > > > > [1] > > RSS rule example without specifying a key: > > flow create 0 ingress / end actions rss queues 0 1 end / end > > [2] Testpmd default key assignment: > > .key=3D "testpmd's default RSS hash key, " > > "override it for better balancing" > > > > Signed-off-by: Ophir Munk > > --- > > v1: Initial version > > > > app/test-pmd/cmdline_flow.c | 15 ++------------- > > 1 file changed, 2 insertions(+), 13 deletions(-) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 23ea7cc..91e2e35 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -3248,26 +3248,15 @@ static int comp_vc_action_rss_queue(struct > > context *, const struct token *, > > .func =3D RTE_ETH_HASH_FUNCTION_DEFAULT, > > .level =3D 0, > > .types =3D rss_hf, > > - .key_len =3D sizeof(action_rss_data->key), > > + .key_len =3D 0, > > .queue_num =3D RTE_MIN(nb_rxq, > > ACTION_RSS_QUEUE_NUM), > > - .key =3D action_rss_data->key, > > + .key =3D NULL, > > .queue =3D action_rss_data->queue, > > }, > > - .key =3D "testpmd's default RSS hash key, " > > - "override it for better balancing", > > .queue =3D { 0 }, > > }; > > for (i =3D 0; i < action_rss_data->conf.queue_num; ++i) > > action_rss_data->queue[i] =3D i; > > - if (!port_id_is_invalid(ctx->port, DISABLED_WARN) && > > - ctx->port !=3D (portid_t)RTE_PORT_ALL) { > > - struct rte_eth_dev_info info; > > - > > - rte_eth_dev_info_get(ctx->port, &info); > > - action_rss_data->conf.key_len =3D > > - RTE_MIN(sizeof(action_rss_data->key), > > - info.hash_key_size); > > - } > > action->conf =3D &action_rss_data->conf; > > return ret; > > } > > -- > > 1.8.3.1