From: Matan Azrad <matan@mellanox.com> To: David Marchand <david.marchand@redhat.com> Cc: "Xueming(Steven) Li" <xuemingl@mellanox.com>, dev <dev@dpdk.org>, Asaf Penso <asafp@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: use master core Id for vhost thread Date: Tue, 28 Jul 2020 07:30:30 +0000 Message-ID: <VI1PR0502MB40309A7BA6EC4E11DB4A3DEBD2730@VI1PR0502MB4030.eurprd05.prod.outlook.com> (raw) In-Reply-To: <CAJFAV8zGxoCryCJgBnQ2FwA57V0L4fc-McjMmWvQJ5bVzUWVfg@mail.gmail.com> From: David Marchand > On Tue, Jul 28, 2020 at 9:20 AM Matan Azrad <matan@mellanox.com> wrote: > > > > > > > > From: David Marchand > > > On Tue, Jul 28, 2020 at 8:11 AM Xueming Li <xuemingl@mellanox.com> > > > wrote: > > > > > > > > With latest rte api, vdpa example failed on vq setup, the api to > > > > get event queue of specified core failed. > > > > > > > > The api to get event queue needs core id as input, but after > > > > commit > > > > 67ae5936c4fc36 ("eal: fix lcore accessors for non-EAL threads"), > > > > code of "vhost-event" thread to get current core returns -1, an > > > > invalid core id. > > > > > > > > As vhost thread created on same core of eal master core, this > > > > patch uses master core ID as a workaround. > > > > > > rte_lcore_to_cpu_id(-1) is supposed to return the current lcore id. > > > As explained in the commitlog of 67ae5936c4fc36, for a non-EAL > > > thread (which has no associated lcore by default) calling this > > > function means lcore_config[-1].core_id. > > > > Deosn't lcore mean core? > > No. So, it may be that we have more than one lcore working on a specific cpu_id? Can you extend here? > > > So, if the private thread run on a core that opened by EAL, Shouldn't > > the API return the lcore of the private thread core? > > vhost-events is a control thread. > Was it working just by chance and returning 0 before? Probably yes. > -- > David Marchand
next prev parent reply other threads:[~2020-07-28 7:30 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-28 6:11 Xueming Li 2020-07-28 6:22 ` [dpdk-dev] [v1] vdpa/mlx5: use control " Xueming Li 2020-07-28 7:08 ` [dpdk-dev] [PATCH] vdpa/mlx5: use master " David Marchand 2020-07-28 7:19 ` Matan Azrad 2020-07-28 7:25 ` David Marchand 2020-07-28 7:30 ` Matan Azrad [this message] 2020-07-28 7:53 ` David Marchand 2020-07-28 8:06 ` Xueming(Steven) Li 2020-07-28 8:27 ` Matan Azrad 2020-07-28 8:30 ` David Marchand 2020-07-28 8:24 ` Xueming(Steven) Li 2020-07-28 9:22 ` [dpdk-dev] [v2] vdpa/mlx5: fix event queue number query Xueming Li 2020-07-28 12:05 ` David Marchand 2020-07-28 12:26 ` Xueming(Steven) Li 2020-07-28 12:32 ` [dpdk-dev] [v3] " Xueming Li 2020-07-28 14:04 ` Maxime Coquelin 2020-07-28 15:55 ` Maxime Coquelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR0502MB40309A7BA6EC4E11DB4A3DEBD2730@VI1PR0502MB4030.eurprd05.prod.outlook.com \ --to=matan@mellanox.com \ --cc=asafp@mellanox.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=xuemingl@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git