From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1DEDA0093; Mon, 18 May 2020 11:44:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8DA421D16B; Mon, 18 May 2020 11:44:57 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2057.outbound.protection.outlook.com [40.107.22.57]) by dpdk.org (Postfix) with ESMTP id C883D1D156 for <dev@dpdk.org>; Mon, 18 May 2020 11:44:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JHypzHca/vR4a2d8h9Pt1HD0I3mK84n4+LZK6om1tyxr3Yhofs/dlfyYgJYnVTMSu5oo6QioOPPa7hM08jn/VWKxDmwCqLUKUuIiYqmgnfF/dLUp38aSxTL//YEDTjIXdLUUNPTgdkovfAGEa0Z78A+Qf9v5biKlKmNd+vGW8M781RwKxwaBhOPm3LL62KEPyIOQ9+QHGB/9wAutY4Hq1nXwP21bWzDRaZcKgUhSRjvPMpVeFRkM0Wh3C4IILyjGm41fluvjrMIImltbl1feQKsvOr4LuPEqdn25u+Uo5lxCUU4FSnT1fjU5Bfq3cbCKL8AF2L7/YodpptK+ejfhOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVzzciu1FRTnS7UV4SU2WcbqE0d7uvRJ56souCGsb6U=; b=ktYY48ebptvyASMoUJ7RPDUxD4DcrvAp5Ym59gCCy232zdC0CTIRIFsgJbbZt2raGFc55Wjyb+bWzepvxQndG9sO65fR8G3bdhRUx5LRMFnl1zR2Z7ADSepzb58duI1pPHh8ZHzqTWS1DyTqyG9kd3kYBqJu8ktgQBOgF0aQVEJNZDSSe/YubSuwvmCUYK+lY3iR9wqDESq74kNFLTF1W/zGo2rI1dYEfIzaxL1x10BznAZqUosA3Jzp+3kbjo6BjVZk/NRIjot6YffJSHOuHIz4yIDADkKBCotMCvmPa7AavIZMh0EKQlG3wII1uSa1vihTdo39TuGXzaGKkFb9qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVzzciu1FRTnS7UV4SU2WcbqE0d7uvRJ56souCGsb6U=; b=YJ3/1EIE3vUl+aj5SUNhj1NUm3M/+dtBOWslVdb6lR2qBNrab/PkYYp/qB3kGitFks1Z5g9+L9eC1jhDWqEQudAlot8314p5kKWB7RHIz2cU0FXUXiOxRwaz/tXZOi1cWDPEqKtoQYdHXUq3gpauFUUAXTBxNur1lqXNBzpN3T0= Received: from VI1PR0502MB4045.eurprd05.prod.outlook.com (2603:10a6:803:21::12) by VI1PR0502MB2943.eurprd05.prod.outlook.com (2603:10a6:800:b8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Mon, 18 May 2020 09:44:53 +0000 Received: from VI1PR0502MB4045.eurprd05.prod.outlook.com ([fe80::cdb1:5935:d420:edd7]) by VI1PR0502MB4045.eurprd05.prod.outlook.com ([fe80::cdb1:5935:d420:edd7%5]) with mapi id 15.20.3000.033; Mon, 18 May 2020 09:44:53 +0000 From: Fady Bader <fady@mellanox.com> To: "jerinj@marvell.com" <jerinj@marvell.com>, Olivier Matz <olivier.matz@6wind.com>, Andrew Rybchenko <arybchenko@solarflare.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>, "skori@marvell.com" <skori@marvell.com> Thread-Topic: [dpdk-dev] [PATCH v7 31/32] mempool: add tracepoints Thread-Index: AQHWGNmXrI3uGj/oW0S9uNC/yl9n7qitvPxg Date: Mon, 18 May 2020 09:44:53 +0000 Message-ID: <VI1PR0502MB40455E904731B66D1BE8B3F8BFB80@VI1PR0502MB4045.eurprd05.prod.outlook.com> References: <20200419100133.3232316-1-jerinj@marvell.com> <20200422190349.3768487-1-jerinj@marvell.com> <20200422190349.3768487-32-jerinj@marvell.com> In-Reply-To: <20200422190349.3768487-32-jerinj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [79.177.7.92] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e409d251-b63e-41df-e04e-08d7fb101dd1 x-ms-traffictypediagnostic: VI1PR0502MB2943: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <VI1PR0502MB2943297E9E7F35567AB24AFDBFB80@VI1PR0502MB2943.eurprd05.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 04073E895A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PnjXxtlT2GML1+uWWqQcDmgcZ/fkTtffQyOwYZ6x9FxGHjm0IvleOwBMieXaTVTPL5r3iORijCnNBzFZaPr3abcYcAgv4ML4gfCSOP8oroMmXRS8M8OqOrAt0Y4fT01YpK+YbAU53KHoJvNaTBdF6+8xVDSLlXofa9L8PGGXut6jdSQ5X3qfC4HpW8KVbntgSfE/AC6WnVetXdzlCP00ORBb/nI7pluAqjaYOaagb3ritbheUMpJFunNZxY3PzfRsSBMMK18yaoqSbCiiuR+oW/nsF6Hg6iM/p7P5be7kBRhnlLjuusQUPNs91zz8DBo10CeqsnvfMxsEhWWd3ylth8hg8DYU29bb62gMwOUbGOT4UaI2spxaHALYmSpqcPW83CpsPdmWfYmKCO7GC3WfnSPpV9pWpF4aWX+oWSTWXxmmrg+INB8AmNlSiUxmchW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0502MB4045.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(2906002)(86362001)(186003)(26005)(66446008)(64756008)(66556008)(76116006)(66476007)(66946007)(33656002)(71200400001)(52536014)(316002)(5660300002)(53546011)(8676002)(54906003)(6506007)(4326008)(110136005)(8936002)(9686003)(55016002)(7696005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: sK7pcu4QBW8Ixy2glsERab1o5alS3s/y9B90VVrsp+CgKQypg0ElufAApBrV5rB+i2TVb8OJ7K+f7iM3KUEp8iwfvOrpmdaJTWOxffl4BK1iXRJft6Esb8unHARMcwPEmeMY30ZT4z/XXKo2eIz6ScECCRrlmNsoBBW+7AGmakoqxnlRSOwonn5456pMoQy1CLzXArybicjQMr0VW7Py5Xb2yEtoIDm/LV4bShgHGl/EAcrAS1S7hTgKuRJ40Z8rbEHU70QwrIa+/XXbVzTPzvEkXAyXPyjHKbXTWW+9q77pQnvoqz9cpaSIgbvn4rfkP8aIN2Jg7MXhc1QOav+D3JkVZqiVw5Tf9wStsWAXVVqTWujKmkk5E4ym7fZxirGFITotiB7pKVjEXtAuL7hxM3tKzFu8XUje5mTiHiEB17DVBSk6aulhhxb5u7pjahWEcnsHXyRVxnkdM+/wJZEs78YSNQspK2DnaLvb2OzmYyw= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e409d251-b63e-41df-e04e-08d7fb101dd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2020 09:44:53.3617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ru/Yt9/QsEkm8jcR5fg8pDosrbx3JEX7Wy/In6oHK0K3AheNfbrTnmps7INXETPoKZWoaQNnT1dzxCIWFwhaLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2943 Subject: Re: [dpdk-dev] [PATCH v7 31/32] mempool: add tracepoints X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi, I'm trying to build this patch on Windows and I'm getting a compilation err= or because the sizes of long and size_t vary on Windows (see comments down = below). > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of jerinj@marvell.com > Sent: Wednesday, April 22, 2020 10:04 PM > To: Olivier Matz <olivier.matz@6wind.com>; Andrew Rybchenko > <arybchenko@solarflare.com> > Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; > bruce.richardson@intel.com; david.marchand@redhat.com; > mattias.ronnblom@ericsson.com; skori@marvell.com > Subject: [dpdk-dev] [PATCH v7 31/32] mempool: add tracepoints >=20 > From: Sunil Kumar Kori <skori@marvell.com> >=20 > Add tracepoints at important and mandatory APIs for tracing support. >=20 > Signed-off-by: Sunil Kumar Kori <skori@marvell.com> > --- > lib/librte_mempool/Makefile | 3 + > lib/librte_mempool/mempool_trace_points.c | 108 +++++++++++++ > lib/librte_mempool/meson.build | 5 +- > lib/librte_mempool/rte_mempool.c | 16 ++ > lib/librte_mempool/rte_mempool.h | 13 ++ > lib/librte_mempool/rte_mempool_ops.c | 7 + > lib/librte_mempool/rte_mempool_trace.h | 178 > +++++++++++++++++++++ > lib/librte_mempool/rte_mempool_trace_fp.h | 116 ++++++++++++++ > lib/librte_mempool/rte_mempool_version.map | 26 +++ > 9 files changed, 470 insertions(+), 2 deletions(-) create mode 100644 > lib/librte_mempool/mempool_trace_points.c > create mode 100644 lib/librte_mempool/rte_mempool_trace.h > create mode 100644 lib/librte_mempool/rte_mempool_trace_fp.h >=20 > diff --git a/lib/librte_mempool/rte_mempool_trace.h > b/lib/librte_mempool/rte_mempool_trace.h > new file mode 100644 > index 000000000..16b115a69 > --- /dev/null > +++ b/lib/librte_mempool/rte_mempool_trace.h > @@ -0,0 +1,178 @@ > +RTE_TRACE_POINT( > + rte_mempool_trace_populate_iova, > + RTE_TRACE_POINT_ARGS(struct rte_mempool *mempool, void > *vaddr, > + rte_iova_t iova, size_t len, void *free_cb, > + void *opaque), > + rte_trace_point_emit_ptr(mempool); > + rte_trace_point_emit_string(mempool->name); > + rte_trace_point_emit_ptr(vaddr); > + rte_trace_point_emit_u64(iova); > + rte_trace_point_emit_long(len); Long and size_t have different sizes in 64 bit Windows. Long is 4 bytes=20 while size_t is 8. I'm trying to make the code compatible for both Linux=20 and Windows, How do you recommend doing that ? > + rte_trace_point_emit_ptr(free_cb); > + rte_trace_point_emit_ptr(opaque); > +) > + Regards, Fady Bader