Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure

["Xueming(Steven) Li" <xuemingl@mellanox.com>]

Looks good, thanks.

How do you think rss_hf, normally people think it best effort.

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, May 1, 2018 9:34 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>; Xueming(Steven) Li <xuemingl@mellanox.com>
> Subject: [PATCH] ethdev: fix applications failure on configure
> 
> Many sample applications fail because of dev_info.flow_type_rss_offloads check in
> rte_eth_dev_configure()
> 
> The sample applications need to be fixed/updated before returning error on rte_eth_dev_configure()
> 
> This patch keeps the error log but removes returning error.
> 
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> Cc: xuemingl@mellanox.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  lib/librte_ethdev/rte_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index
> 59810dde8..5a67e6a7d 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -1148,7 +1148,6 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
>  				    port_id,
>  				    dev_conf->rx_adv_conf.rss_conf.rss_hf,
>  				    dev_info.flow_type_rss_offloads);
> -		return -EINVAL;
>  	}
> 
>  	/*
> --
> 2.14.3