From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0057.outbound.protection.outlook.com [104.47.2.57]) by dpdk.org (Postfix) with ESMTP id 7B5EE7CB3 for ; Mon, 11 Sep 2017 07:52:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zYwDKesW3zDgo8ui2WwrMCVjugH3kQcStpMlQYQaqvU=; b=yuHtx5IpBQNLHL9kLLMap/kFly1oNTz1qcvLhslH7ulthkQHKWVO7hiUjL268vcvjvDYxotgFbCQs3ypP5qV/45y0HB8nFZ6JrtvS3YHIfFtIm1TKK9wTv38Lo3zqMJGqIUcpertszXoJ/ijmUSbchRtf/datDle9voJTwAroZU= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1488.eurprd05.prod.outlook.com (10.164.85.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Mon, 11 Sep 2017 05:52:19 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0056.010; Mon, 11 Sep 2017 05:52:19 +0000 From: Shahaf Shuler To: Stephen Hemminger CC: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API Thread-Index: AQHTKi2DBuCZy0EdtkKBpDN66oo+k6KuZaiAgADHvZA= Date: Mon, 11 Sep 2017 05:52:19 +0000 Message-ID: References: <20170910104827.11da9230@xeon-e3> In-Reply-To: <20170910104827.11da9230@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1488; 6:pjZTkc2QS6DkHyXXvDgJlVIfX2AIABswoDq1monB5ZxA1fiTJS4la3wq5tXzaEq1k3rjne3m8ZFjOXSARdVa/EyWCWOOdcGukCC/iRUJscFVVn6Ue9TouPYOm0CUuji5Y3dxH4D9EToDb7LPh+GAUFv4ISlkcZpWlP2U9gTwA879zBBd9wEWJm26jWYafOzNNaJDPP7zABngb9ettZ3WKPiCJImpp7iDnL7EpJOCtTlKZKIfjk0xjwHDB+KVHfaoewcHh2gEsHz3u8YoeLMXb4x12S7UdfLU60PSRFy0iYcvu1VElvnn38fK3lLIJSgSVQJnzXeGA+myCUmvEqxi9g==; 5:9j5BRGedsRAXHPBqJ75qniLutUaPPSHj4bndTza9r/BM9JCq2ryzKHNvF85lB/9HLuq//yqhw1lDAbLNKgnm743Fie5o9dxhLd6iMtjtQMQ32X1Owo/Hdcit1Em/SXND/mX3Qv2+WjC7cU7WfoEqbA==; 24:/bSDfk0wvhl3eoUKcIhEmUsnfqrrOPawMoQH/RSRj14382YnZMdGTmsrNMKktB+Ft1qEkTm4UdyuvUefiyCr/vFnzhE8xsG6x8JoAT7wjE0=; 7:WXsGIwrqw50V+AF61cDHL/xRRb8AP56eyqTD0m3fmfMwQFNp6mN0Yfq1/85nQNNWJjqe6Eh67J8Q2NPamuviwvROudP8+CZVXdrrgDe15NXOw7rHM/szgcYXVoTzog5k4oKhJqWNE/A6Hq4gaqk4A3opguNYL2Efas+yNvECBvct0UP4mThCyyjDYF0GuWeLcUGv+JMrKp/Oe7rti8d60DyiIW8K6Djt4R1rWtlRUDQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 3580f136-e581-438c-3e2e-08d4f8d943d9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB1488; x-ms-traffictypediagnostic: VI1PR05MB1488: x-exchange-antispam-report-test: UriScan:(20558992708506)(278428928389397); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1488; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1488; x-forefront-prvs: 04270EF89C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(189002)(199003)(377454003)(24454002)(97736004)(305945005)(68736007)(55016002)(7736002)(8676002)(99286003)(54906002)(6306002)(9686003)(6246003)(3660700001)(8936002)(3280700002)(81156014)(229853002)(5250100002)(81166006)(53936002)(53376002)(2906002)(110136004)(6436002)(966005)(478600001)(50986999)(101416001)(54356999)(105586002)(86362001)(6506006)(4326008)(25786009)(66066001)(14454004)(76176999)(5660300001)(106356001)(6916009)(93886005)(7696004)(6116002)(102836003)(3846002)(2950100002)(74316002)(2900100001)(33656002)(189998001)(533714002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1488; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2017 05:52:19.5511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1488 Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 05:52:21 -0000 Sunday, September 10, 2017 8:48 PM, Stephen Hemminger: >=20 > On Sun, 10 Sep 2017 15:07:49 +0300 > Shahaf Shuler wrote: >=20 > > Introduce a new API to configure Tx offloads. > > > > In the new API, offloads are divided into per-port and per-queue > > offloads. The PMD reports capability for each of them. > > Offloads are enabled using the existing DEV_TX_OFFLOAD_* flags. > > To enable per-port offload, the offload should be set on both device > > configuration and queue configuration. To enable per-queue offload, > > the offloads can be set only on queue configuration. > > > > In addition the Tx offloads will be disabled by default and be enabled > > per application needs. This will much simplify PMD management of the > > different offloads. > > > > The new API does not have an equivalent for the below, benchmark > > specific, flags: > > > > - ETH_TXQ_FLAGS_NOREFCOUNT > > - ETH_TXQ_FLAGS_NOMULTMEMP > > > > Applications should set the ETH_TXQ_FLAGS_IGNORE flag on txq_flags > > field in order to move to the new API. > > > > The old Tx offloads API is kept for the meanwhile, in order to enable > > a smooth transition for PMDs and application to the new API. > > > > Signed-off-by: Shahaf Shuler > > --- >=20 > Agree on a conceptual and hardware level, that this is a property that co= uld > be per queue. But is there really an application that would want to have > refcounting on one queue and not another? If application is cloning mbuf= 's it > needs refcounting. One could even argue that for safety these should be > library wide. That way if an application tried to manipulate ref count o= n an > mbuf and refcountin was enabled it could be panic'd. Actually the refcount and multi mempool flags has no equivalent on this new= API. They are not counted as offloads rather some guarantees from applicat= ion side, which I agree that probably needs to by library wide.=20 In the current API you cannot set those per queue nor per port. I think the= re is intention to move those flags to some other location following this s= eries [1] [1] http://dpdk.org/ml/archives/dev/2017-September/074475.html