From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20057.outbound.protection.outlook.com [40.107.2.57]) by dpdk.org (Postfix) with ESMTP id 0944F1B8A6 for ; Thu, 1 Feb 2018 06:57:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ula4GVgVzxFzKftLth3RMiRKhPwrf286O/F7QBLhPh4=; b=KIdoHtNGvb0AkMmSWXw6cQazwVjxtBPbaflRx3F5GUhJ8xjjs5c/e1lalZyOzKIXUS5I6MBbjA0lTIOWZm5O9vm0pxgaCcL0s7/wIg9uSmeil8HCka9TRGPIebaybCP9UTNGbno2iCNSBu0Ss2lTVjt7HwDm6DeVkASR88UAaeU= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1485.eurprd05.prod.outlook.com (10.164.85.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 1 Feb 2018 05:57:53 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0444.016; Thu, 1 Feb 2018 05:57:53 +0000 From: Shahaf Shuler To: Yanglong Wu , "dev@dpdk.org" CC: "wenzhuo.lu@intel.com" Thread-Topic: [PATCH] app/testpmd:vlan filter fail Thread-Index: AQHTmvwSIo++AFhrr0eRXXyf34hhGKOPDMVQ Date: Thu, 1 Feb 2018 05:57:53 +0000 Message-ID: References: <20180201012653.173890-1-yanglong.wu@intel.com> In-Reply-To: <20180201012653.173890-1-yanglong.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1485; 7:T8t5w0otJGEJxYkZ0OSLbhIo96Ry0aYwVM2P52GcWFgn7jqTuYZ2iE0wgIC3rX2lEFN59uKv1mcqh5XmHXa+GqiPkviQi4lrCUuYuHJo4kN12z8neeWNgYjmUDKrNHd/wy7isXpBS1APtzulnqGxB57eCcFnM7EXmuwIIkycFr9cm4VnPrE+Zo30KJlE2xUGsiA32XfdW6Ltj3eXA1zmznA5sCxlZaRrPNqEKSM0/ND4C/xbaEg6pYuTdLoJknwD x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8ef920a8-4a76-45b0-f955-08d56938bbca x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1485; x-ms-traffictypediagnostic: VI1PR05MB1485: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(2400082)(944501161)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR05MB1485; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1485; x-forefront-prvs: 0570F1F193 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(346002)(39860400002)(366004)(376002)(199004)(189003)(3660700001)(74316002)(316002)(59450400001)(106356001)(3280700002)(55016002)(5660300001)(305945005)(25786009)(4326008)(6116002)(97736004)(26005)(3846002)(68736007)(229853002)(2950100002)(110136005)(2906002)(76176011)(86362001)(99286004)(6436002)(186003)(9686003)(7696005)(102836004)(8676002)(81156014)(33656002)(66066001)(8936002)(6506007)(478600001)(105586002)(81166006)(5250100002)(2501003)(2900100001)(53936002)(6246003)(7736002)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1485; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3vHGTge3yYcPjlOCnC/16SLfCade7FnsFlJWMkrDEkVkI1WZehTdhGbltSegRmecimWxpULwc95Tk0tq/JTvJQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ef920a8-4a76-45b0-f955-08d56938bbca X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2018 05:57:53.1894 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1485 Subject: Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 05:57:55 -0000 Thursday, February 1, 2018 3:27 AM, Yanglong Wu: > And-operartion with a constant will > always lead to fail for vlan filter. It will work after dev->data->dev_conf.rxmode.offloads |=3D DEV_RX_OFFLOAD= _VLAN_FILTER , right? I don't understand what this patch tries to fix.=20 >=20 > fix:0074d02fc(convert to new Rx offloads API) > Signed-off-by: Yanglong Wu > --- > lib/librte_ether/rte_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c > index f285ba278..d468bb4a1 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -2288,7 +2288,7 @@ rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t > vlan_id, int on) >=20 > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > dev =3D &rte_eth_devices[port_id]; > - if (!(dev->data->dev_conf.rxmode.offloads & > + if (!(dev->data->dev_conf.rxmode.offloads || > DEV_RX_OFFLOAD_VLAN_FILTER)) { > RTE_PMD_DEBUG_TRACE("port %d: vlan-filtering > disabled\n", port_id); > return -ENOSYS; > -- > 2.11.0