From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0053.outbound.protection.outlook.com [104.47.0.53]) by dpdk.org (Postfix) with ESMTP id A0CFA1B20F for ; Wed, 10 Jan 2018 16:19:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0fqR8l+NP+KqP0DXNO8ARkxqn9rv0G6RTuTrBfGIRYo=; b=OOXsMdosKBYGVY+Bg7Fd68F5BI9fcpPF+PN8BtsjOyimzxI72DrpwMOr7dmJ7EotD0jnJYsoA6T95LnSPyt1GTtKcwzKZWOWuSPs/TtrYw6+s2MjShYYC8m5pmSs6nQ/+j7Zqjjih1RwaLwTwcjC03+c8rJFO1JTVS0zr3iwQoQ= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3215.eurprd05.prod.outlook.com (10.170.237.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 15:19:04 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0386.009; Wed, 10 Jan 2018 15:19:03 +0000 From: Shahaf Shuler To: Adrien Mazarguil , Mordechay Haimovsky CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx4: verify Tx max sges Thread-Index: AQHThXbQQTZiqC7nQkOKL+5gk9EfO6NlgHCAgAfBGGA= Date: Wed, 10 Jan 2018 15:19:03 +0000 Message-ID: References: <1515082323-179525-1-git-send-email-motih@mellanox.com> <20180105165317.GV4256@6wind.com> In-Reply-To: <20180105165317.GV4256@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3215; 6:ZAUfmSngKn88e6IN39sDoPhfkLhXl7H/9XNn0uWPf3KneyJukejvwEyN18/np5ODa2r2U9DLh3B5KByuejSTG4nJcA1IYRWQpbOgbm5MksfdaI6NuZLQx2isdIH1MtGoHpd6jjZsoEi84LKa9OZay4LC+R6EZo0l5/3ZZ76efygbFPKoo9rEAp02CMVMX6J8V/Vfff1tFuR3uBsaWxMQjGXxUIpiCoQF02LZIs3M8pnCE7BrndSxhC1rz4GtGy2V8UPMyRSBCejITmYicJ5jrgR9QkNas3DExAvb+ONycZgbD/eiDCbjf1MsWhZYUHpmM5fcE++oXSKiMyaGlpg4VF1nFNbe8xOS9it62N/84lT01jmQtUmx7kaGiSTczfxU; 5:hxLMM5uJ/JTrB8PF+22htQjYzhVOX134YxIgjVD3aRLClFOj1TrnY9m2dDjYrWxpzM1pUUu/FUn6gnzCP/x5JCErlZRS22/UMocLlEVdjK7MqeQEmfirt/o8wTXOpto4BGb19OJ3edPO+WDAZ3YIxzzPKxYucWCuLBEZO6RzVIs=; 24:V45+Kr+30A5Ik7MafnRNjV8nta/7ItbjeEtsG6VGZsqiqAsHlyvgKHEYXgYuqzlgqu+SLVNTHEEu6Npv+235ESCvDd1q9oufZOsS5WHGyIs=; 7:mydyzCa/jfh/TkXgJvLGyffa91MFg5Y24OtDGqkxMrYyy1dbaVfRh9g33KjJSAv8T8Yog8Kw+rXKQk/XWCmDI0S8TdnJvxl6cUAnr7D6jCAAPXY4Y0Rqk8a3/83zF9bW0V/HG49PTbmZKON98EdLGybM6yLXhcv1vjIRgvx1YEVGYCpKkjz7CsV5ugREE0Rn94q0hNSnlrT/7Spj17NrGZNfdKrrCx6cxhnKKcMZtueis1GWMU1uzGRRR/yHZgSs x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5f25aab0-0f2a-4a06-b105-08d5583d7bfb x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3215; x-ms-traffictypediagnostic: VI1PR05MB3215: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231023)(944501075)(93006095)(93001095)(6055026)(6041268)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR05MB3215; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3215; x-forefront-prvs: 0548586081 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39380400002)(366004)(39860400002)(199004)(189003)(3660700001)(8936002)(2900100001)(305945005)(7736002)(3280700002)(14454004)(2906002)(86362001)(68736007)(5250100002)(81166006)(81156014)(8676002)(3846002)(6116002)(25786009)(74316002)(105586002)(6246003)(4326008)(106356001)(5660300001)(316002)(110136005)(99286004)(66066001)(97736004)(2950100002)(76176011)(7696005)(6636002)(33656002)(6436002)(53936002)(9686003)(6506007)(102836004)(59450400001)(478600001)(55016002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3215; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 1OwnxmViVar1PFyglwOAnaFzslrP2hR1P7O5keiaecJ0gy79btaIaoxfLZ5bYXQ1Zp+Vgh9YCsawH5AlVRDScA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f25aab0-0f2a-4a06-b105-08d5583d7bfb X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2018 15:19:03.6939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3215 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: verify Tx max sges X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 15:19:05 -0000 Friday, January 5, 2018 6:53 PM, Adrien Mazarguil: > > Signed-off-by: Moti Haimovsky >=20 > Except for a really minor nit below: >=20 > Acked-by: Adrien Mazarguil Applied to next-net-mlx with the suggested fix. Thanks=20 >=20 > > --- > > drivers/net/mlx4/mlx4.c | 1 + > > drivers/net/mlx4/mlx4_prm.h | 5 ++++- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index > > 4bc4a6f..61c5bf4 100644 > > --- a/drivers/net/mlx4/mlx4.c > > +++ b/drivers/net/mlx4/mlx4.c > > @@ -505,6 +505,7 @@ struct mlx4_conf { > > rte_errno =3D ENODEV; > > goto error; > > } > > + assert(device_attr.max_sge >=3D MLX4_MAX_SGE); > > for (i =3D 0; i < device_attr.phys_port_cnt; i++) { > > uint32_t port =3D i + 1; /* ports are indexed from one */ > > struct ibv_context *ctx =3D NULL; > > diff --git a/drivers/net/mlx4/mlx4_prm.h b/drivers/net/mlx4/mlx4_prm.h > > index 217ea50..b382d59 100644 > > --- a/drivers/net/mlx4/mlx4_prm.h > > +++ b/drivers/net/mlx4/mlx4_prm.h > > @@ -53,7 +53,10 @@ > > #define MLX4_TXBB_SIZE (1 << MLX4_TXBB_SHIFT) > > > > /* Typical TSO descriptor with 16 gather entries is 352 bytes. */ > > -#define MLX4_MAX_WQE_SIZE 512 > > +#define MLX4_MAX_SGE 32 > > +#define MLX4_MAX_WQE_SIZE \ > > + (MLX4_MAX_SGE * sizeof(struct mlx4_wqe_data_seg) + \ > > + sizeof(struct mlx4_wqe_ctrl_seg)) >=20 > One extra indent space is needed before sizeof to align with parenthesis > contents. >=20 > -- > Adrien Mazarguil > 6WIND