From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50086.outbound.protection.outlook.com [40.107.5.86]) by dpdk.org (Postfix) with ESMTP id 690851B895 for ; Wed, 25 Oct 2017 09:01:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3cjRUJK3Qg26b81z1MOr6yzidACCmq72ZTJz/Gm2zU8=; b=SdC+B0vJRHak4kBDjO8Vjnp+baEJsqu5tgmy+2JcQNGoPkj912Uk4wYJbfLUF8byRuRLU1QHLiCdoPHlmlLxcH8VzVHMXjiq4ivBeTVYuw2I2KYIYOh/nKqVQFiOo+vIhyJAZo42DN0mhBX7IXGT25ZknUXVOrERN+EZoRKWeww= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3181.eurprd05.prod.outlook.com (10.170.237.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Wed, 25 Oct 2017 07:01:34 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0077.023; Wed, 25 Oct 2017 07:01:33 +0000 From: Shahaf Shuler To: Akhil Goyal , "dev@dpdk.org" CC: "declan.doherty@intel.com" , "pablo.de.lara.guarch@intel.com" , "hemant.agrawal@nxp.com" , "radu.nicolau@intel.com" , Boris Pismenny , "Aviad Yehezkel" , Thomas Monjalon , "sandeep.malik@nxp.com" , "jerin.jacob@caviumnetworks.com" , "john.mcnamara@intel.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" Thread-Topic: [PATCH v5 06/11] ethdev: support security APIs Thread-Index: AQHTTUxgfppfbQ2w2kejFb1umDca4aL0IkZA Date: Wed, 25 Oct 2017 07:01:33 +0000 Message-ID: References: <20171014221734.15511-1-akhil.goyal@nxp.com> <20171024141545.30837-1-akhil.goyal@nxp.com> <20171024141545.30837-7-akhil.goyal@nxp.com> In-Reply-To: <20171024141545.30837-7-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3181; 6:0ztE1lvNpZ38XMuMag7UWOzgl76Fm2NxRqaXDmThL7IpcLKut7Y0y+pgEoS5ktcsGcOkCjPAQ7EROBwY7dVl7lH9NiO3p3YEMccW4dVGt6HLBpJWcwfCuvsCpdVkkihxHmlLBiptq0ZYDNQfzAP2zHruODOBirPkKyTBr+F4XBwI+QAKcrmLGj37zeB8fPlYco7wR3EGueV41UGFrzFm3/+lqTH8FCygJikqdWeNpU202JJboo6re7LubHp5pFaysTILT5UnSyQ7Ci/Bm8Kmwuy067v5incI51rrNdFX8mg2tY6v9awYvqgtOb9mbgXDBLPJA6gRT1IsaTsSefec1w==; 5:H20LDAB8PJfQw8l5U9RkxTVcAuF+6aLCNK5ttrXuN0y1MUVzZzf45pX1I1iB/Dnnr2xVl37MQR7r3YqcTKwW6sYFbc5yYAdaoOSkkF0Q8HIDKWJNTWmTBOqCBd1ta0aHP/Os3dtbjZ7qeHHvMadj1g==; 24:1myUW9IrFh3XqQeWZK+4rKHnzRkQ0qnXtGCZ7WzBYkqMZItlzlFULiHN9DdnAkrLnclxksCJpC2Fioza5IDoamRQqCXUmiCb6kBU/AUJ/Z4=; 7:oWlhmIX/G8Pduoi8ku3vZ6Y9B5flX5hekcRVZosIabZX2qdV9D3pmBsuvOHVKDexRUcgOeNbM+NPmWg5IEprt8fNxecXJZ5B3fwcvv8jR8L+EV98Z4QsmAU5sqLMr56amnSiOmyePLwhy7rccxRfX3N4Ph6QJa2t7BBptQPK3SFhXkfHjt/dZkzJHU3nTELiyWbvvQK2dFgexRzu1X33TqFA3wDlXIp25P7x+VQk310= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e21fdbbf-f0e5-4bd2-8aac-08d51b763a31 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:VI1PR05MB3181; x-ms-traffictypediagnostic: VI1PR05MB3181: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:(192374486261705)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231020)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3181; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3181; x-forefront-prvs: 0471B73328 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(189002)(199003)(229853002)(3846002)(25786009)(102836003)(6116002)(105586002)(5250100002)(478600001)(86362001)(106356001)(575784001)(15650500001)(4326008)(305945005)(81156014)(53936002)(8936002)(97736004)(81166006)(6246003)(3280700002)(7696004)(99286003)(3660700001)(55016002)(8676002)(14454004)(7736002)(74316002)(2906002)(2950100002)(101416001)(54906003)(54356999)(76176999)(6436002)(189998001)(50986999)(110136005)(68736007)(9686003)(2900100001)(316002)(33656002)(6506006)(7416002)(2501003)(5660300001)(66066001)(8656006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3181; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e21fdbbf-f0e5-4bd2-8aac-08d51b763a31 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2017 07:01:33.8271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3181 Subject: Re: [dpdk-dev] [PATCH v5 06/11] ethdev: support security APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 07:01:35 -0000 Hi, I know we are in a rush to put this patches in before RC2. however I still = see critical issue (below). Tuesday, October 24, 2017 5:16 PM, Akhil Goyal: > From: Declan Doherty >=20 > rte_flow_action type and ethdev updated to support rte_security sessions > for crypto offload to ethernet device. >=20 > Signed-off-by: Boris Pismenny > Signed-off-by: Aviad Yehezkel > Signed-off-by: Radu Nicolau > Signed-off-by: Declan Doherty > --- > lib/librte_ether/rte_ethdev.c | 7 +++++++ > lib/librte_ether/rte_ethdev.h | 8 ++++++++ > lib/librte_ether/rte_ethdev_version.map | 1 + > 3 files changed, 16 insertions(+) >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c > index 0b1e928..a3b0e4e 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -301,6 +301,13 @@ rte_eth_dev_socket_id(uint16_t port_id) > return rte_eth_devices[port_id].data->numa_node; > } >=20 > +void * > +rte_eth_dev_get_sec_ctx(uint8_t port_id) { > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, NULL); > + return rte_eth_devices[port_id].security_ctx; > +} > + > uint16_t > rte_eth_dev_count(void) > { > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.= h > index b773589..119f7fc 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -180,6 +180,8 @@ extern "C" { > #include > #include > #include > +#include > + > #include "rte_ether.h" > #include "rte_eth_ctrl.h" > #include "rte_dev_info.h" > @@ -963,6 +965,7 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_CRC_STRIP 0x00001000 > #define DEV_RX_OFFLOAD_SCATTER 0x00002000 > #define DEV_RX_OFFLOAD_TIMESTAMP 0x00004000 > +#define DEV_RX_OFFLOAD_SECURITY 0x00008000 How application will control this offload on 17.11 ?=20 The PMDs are not yet moved to the new API, so crypto offload is going to be= enabled by default with no way to disable?=20 > #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | > \ > DEV_RX_OFFLOAD_UDP_CKSUM | \ > DEV_RX_OFFLOAD_TCP_CKSUM) > @@ -998,6 +1001,7 @@ struct rte_eth_conf { > * When set application must guarantee that per-queue all mbufs comes > from > * the same mempool and has refcnt =3D 1. > */ > +#define DEV_TX_OFFLOAD_SECURITY 0x00020000 Same point here. >=20 > struct rte_pci_device; >=20 > @@ -1741,8 +1745,12 @@ struct rte_eth_dev { > */ > struct rte_eth_rxtx_callback > *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT]; > enum rte_eth_dev_state state; /**< Flag indicating the port state */ > + void *security_ctx; /**< Context for security ops */ > } __rte_cache_aligned; >=20 > +void * > +rte_eth_dev_get_sec_ctx(uint8_t port_id); > + > struct rte_eth_dev_sriov { > uint8_t active; /**< SRIOV is active with 16, 32 or 64 po= ols */ > uint8_t nb_q_per_pool; /**< rx queue number per pool */ > diff --git a/lib/librte_ether/rte_ethdev_version.map > b/lib/librte_ether/rte_ethdev_version.map > index 57d9b54..e9681ac 100644 > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librte_ether/rte_ethdev_version.map > @@ -191,6 +191,7 @@ DPDK_17.08 { > DPDK_17.11 { > global: >=20 > + rte_eth_dev_get_sec_ctx; > rte_eth_dev_pool_ops_supported; > rte_eth_dev_reset; > rte_flow_error_set; > -- > 2.9.3