From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0051.outbound.protection.outlook.com [104.47.2.51]) by dpdk.org (Postfix) with ESMTP id 1A2B71B2CA for ; Mon, 5 Feb 2018 09:59:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KXd4WEqu/8XJ+t24isyEiQI+SDv7vPZrgKqLB4gcWBI=; b=kT+xGv2jT6o3WJfaMqyubA+CsQ7mZ4gsBYsyEDUUCqh3qp0DcIQVhZPporZfPQShpAzIdwMmMo8c+muntfUr3LFOn+cWOqPpPhkDsob8z1PdP9vlGooqIiS6g/dUBCasqxB4w7WmMirne4+XeQkElfYUdqNVSLuv581KzII8DRU= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1149.eurprd05.prod.outlook.com (10.162.15.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 08:59:44 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0464.015; Mon, 5 Feb 2018 08:59:44 +0000 From: Shahaf Shuler To: Yanglong Wu , "dev@dpdk.org" CC: "wenzhuo.lu@intel.com" Thread-Topic: [PATCH v3] app/testpmd: fix port DCB configuration Thread-Index: AQHTnl6QcXleE6sZgEef0tyCFMfO1qOVgj2Q Date: Mon, 5 Feb 2018 08:59:44 +0000 Message-ID: References: <20180205023357.104418-1-yanglong.wu@intel.com> <20180205084820.5387-1-yanglong.wu@intel.com> In-Reply-To: <20180205084820.5387-1-yanglong.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1149; 7:Uic++3wgAaaqL7XYuNRh0V2rE7gsUFYBrNjVI331f81JQqhXc8Fvi4EedQY4fbV2XgaFJejNegqlZ43RyR3SSeWsYuih6ouONkj05/hN8j04/Vnuy2JtkCmECNYEmlY3yuiqejQ40J2PpRTaPYl3qhzRLvLLAcrRbEHvUC79SITBIkfSvVSJJwAVnAb4hZlOxuUlv2CBC5iCq6NoMl/h3f0JXEUdqFm8lfsMAG4HhNs7i9x1uel/B7YC+Z8MfdjL x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b78b72dc-1692-47c6-6c1b-08d56c76cd39 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1149; x-ms-traffictypediagnostic: VI1PR05MB1149: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231101)(2400082)(944501161)(10201501046)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR05MB1149; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1149; x-forefront-prvs: 0574D4712B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(376002)(39860400002)(366004)(199004)(189003)(33656002)(102836004)(105586002)(8676002)(99286004)(25786009)(110136005)(316002)(4326008)(3846002)(6246003)(2906002)(2501003)(6116002)(5250100002)(76176011)(9686003)(478600001)(74316002)(68736007)(7696005)(2950100002)(5660300001)(6436002)(229853002)(26005)(3280700002)(81166006)(81156014)(106356001)(55016002)(3660700001)(8936002)(53936002)(6506007)(305945005)(2900100001)(66066001)(7736002)(186003)(14454004)(86362001)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1149; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: kX/eJZqdPq5jxo9PDU3PRyvY7M3tqAbgAnS5LI8t++fGVyv98ArR1Osq5DdiZZyMjZM/qCQe/z+kgNaiFDioNw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b78b72dc-1692-47c6-6c1b-08d56c76cd39 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2018 08:59:44.6576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1149 Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 08:59:47 -0000 Monday, February 5, 2018 10:48 AM, Yanglong Wu: > Fix:0074d02fc("app/testpmd: convert to new Rx offloads API") The fix line is still wrong. Use the one I suggested. > Signed-off-by: Yanglong Wu > --- > v2: > changing patch accoding to review > --- > v3: > changing patch accoding to comments > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dc8ccac5..da1d9bd3a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, > /* Enter DCB configuration status */ > dcb_config =3D 1; >=20 > + port_conf.rxmode =3D rte_port->dev_conf.rxmode; > + port_conf.txmode =3D rte_port->dev_conf.txmode; > + > /*set configuration of DCB in vt mode and DCB in non-vt mode*/ > retval =3D get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, > pfc_en); > if (retval < 0) > -- > 2.11.0 Acked-by: Shahaf Shuler (please include this on the = next version if any).=20