DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd:vlan filter fail
@ 2018-02-02  5:09 Yanglong Wu
  2018-02-04  6:27 ` Shahaf Shuler
  2018-02-05  2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
  0 siblings, 2 replies; 13+ messages in thread
From: Yanglong Wu @ 2018-02-02  5:09 UTC (permalink / raw)
  To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu

Removing out port_conf.rxmode.hw_vlan_filter = 1
will let it equal to 0 and port_conf.rxmode.offloads
is assigned as 0 again if hw_vlan_filter = 1. So it
will always lead to fail for vlan filter setting

Fix:0074d02fc(convert to new Rx offloads API)
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
 app/test-pmd/testpmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 5dc8ccac5..0751e573c 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2328,7 +2328,7 @@ init_port_dcb_config(portid_t pid,
 	retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en);
 	if (retval < 0)
 		return retval;
-	port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
+	port_conf.rxmode.hw_vlan_filter = 1;
 
 	/**
 	 * Write the configuration into the device.
-- 
2.11.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2018-02-06 15:09 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02  5:09 [dpdk-dev] [PATCH] app/testpmd:vlan filter fail Yanglong Wu
2018-02-04  6:27 ` Shahaf Shuler
2018-02-05  1:51   ` Wu, Yanglong
2018-02-05  2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-02-05  6:14   ` Shahaf Shuler
2018-02-05  7:36     ` Wu, Yanglong
2018-02-05  7:53   ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu
2018-02-05  8:00     ` Yang, Zhiyong
2018-02-05  8:48   ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu
2018-02-05  8:59     ` Shahaf Shuler
2018-02-05  9:47     ` [dpdk-dev] [PATCH v4] " Yanglong Wu
2018-02-05  9:56     ` Yanglong Wu
2018-02-06 15:09       ` Zhang, Helin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).