From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80]) by dpdk.org (Postfix) with ESMTP id F0B057CBD for ; Wed, 13 Sep 2017 14:56:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zrjoknibizHdR4OX6uedpHAASYCa1LNREP1dMpaRKlo=; b=KyKlGK2HpVihEsn8pqHn3Nbgrbf4nKN5JWmeimPFprjltAb+pcA5ZAmfhl9HhAfDbCTCRwap+6TAHqgpyoUDuzdhOCkIpmZit44+1xshxhR4zPuiM3O9lWIprOJf68CMFOytwU0w36jvJ1Yx0nPC849KlH+/KAfHTZpVSUUeBEw= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1421.eurprd05.prod.outlook.com (10.162.124.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Wed, 13 Sep 2017 12:56:24 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0056.010; Wed, 13 Sep 2017 12:56:24 +0000 From: Shahaf Shuler To: Thomas Monjalon , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API Thread-Index: AQHTJYU1V12CwMiH90ScwHe7u4qjjKKkxkyAgAElSgCAAAYVAIAAJeMwgABVZwCAAOkvQIAARTuAgAr+v4CAABd4MIAAHrKAgAAC5xA= Date: Wed, 13 Sep 2017 12:56:24 +0000 Message-ID: References: <2632317.9dDdYF2F86@xps> <1868308.cPa78Soq0s@xps> In-Reply-To: <1868308.cPa78Soq0s@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1421; 6:mGto+BEMFIYjQ2FtjEJiEM+HCHd1jmsX25bH2uBlyW6/bV5vXNZPHqZnuSq4yDiCSihGyXYd7sCjGzK6RktzY2gnsaRuhRrvd4BEht8mX+PDzObrTIEHHumyspbXsk9DxrO4YWrzYXx3Td81YNFMT2Oii3l6kVEtgiivO10hTDmgVmn7UqjVkIMoJq11xgb/Hn66fLUyoecqYldI8Cd6WWto0GzG8B+DWYqrGbM3Z5pbJrHQNhGjqyZV+KcuN1Z4UmCIxut/2N5aFOfrOiu/QyGX049WtIWNmvmWW0aPteXNJ+t0kv6Uqjmb13fZTG/RlhyT2YUymjPwx3tc2HTjIQ==; 5:EuFpHFi7yqn8LHbyjxuhtaxgMMJj5RzSJR2AmhoSt2CMqe8lLPyq+S1sQ6RWjRRtQuf9kOMvrm574UPbk3A1TSrBN1VvjXQ63kfZA9yNYX7qtqpBXfyf5Zj+C9aLdNg806wJPPes0V9fL4PXGPvAGA==; 24:3plIU9YBayHVbQfBfldMBZyKN07MSCaRulKK983gIHWQaZ3k71IxZeFoZCkknXkfSoTDtCvSLVpfAy0I81nMNogQHHrfMpz67tJv2kiAxis=; 7:Pl2OhlUpT54pjvTXvj40miD4gmA7XSbgNA2wgYUIHyzJ5/C97T2Ki65ny7e66b5IDgj5Q7d1SM9JBkOC/VJydZe8q87/b/lpRfc0GfCyc1/Lxmvv06JFF+or42GJTTjU7ln1o+UCg3WwS+v9miZ7ooVMaMV0lSuo6vd0Wb3FgQO0qCGGavDc/qStfJbVWv5iVBDOkG9Z9PYc/u6HdlPavjoLlb29w7aIJvf5kjKAcOY= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: c6acdf1c-d261-45b6-1b4c-08d4faa6d6e3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB1421; x-ms-traffictypediagnostic: VI1PR05MB1421: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1421; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1421; x-forefront-prvs: 042957ACD7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(366002)(199003)(189002)(377454003)(74316002)(478600001)(2950100002)(102836003)(3846002)(7696004)(6116002)(3660700001)(86362001)(7736002)(189998001)(305945005)(2906002)(2501003)(316002)(5250100002)(5660300001)(93886005)(81156014)(81166006)(8676002)(66066001)(2900100001)(8936002)(99286003)(55016002)(54906002)(54356999)(76176999)(50986999)(6246003)(4326008)(9686003)(6436002)(229853002)(33656002)(106356001)(97736004)(3280700002)(6506006)(101416001)(14454004)(53936002)(105586002)(25786009)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1421; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2017 12:56:24.2024 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1421 Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 12:56:26 -0000 Wednesday, September 13, 2017 3:42 PM, Thomas MonjalonL > 13/09/2017 13:16, Shahaf Shuler: > > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > > > I still think we must streamline ethdev API instead of complexifying. > > > We should drop the big "configure everything" and configure offloads > > > one by one, and per queue (the finer grain). > > > > The issue is, that there is some functionality which cannot be achieved > when configuring offload per queue. > > For example - vlan filter on intel NICs. The PF can set it even without > creating a single queue, in order to enable it for the VFs. >=20 > As it is a device-specific - not documented - side effect, I won't consid= er it. > However I understand it may be better to be able to configure per-port > offloads with a dedicated per-port function. > I agree with the approach of the v3 of this series. >=20 > Let me give my overview of offloads: >=20 > We have simple offloads which are configured by just setting a flag. > The same flag can be set per-port or per-queue. > This offload can be set before starting or on the fly. > We currently have no generic way to set it on the fly. >=20 > We have also more complicate offloads which require more configuration. > They are set with the rte_flow API. > They can be per-port, per-queue, on the fly or not (AFAIK). >=20 > I think we must discuss "on the fly" capability. > It requires probably to set up simple offloads (flags) with a dedicated > function instead of using "configure" and "queue_setup" functions. > This new capability can be implemented in a different series. >=20 > Opinions? Agree about the on the fly configuration for Tx/Rx offloads.=20 Currently the vlan case is an exception, we should have a generic API to se= t such offloads.=20 I assume that we also don't want to have dev_op function on PMD for each "o= n the flight" configuration like we have with the vlan offloads.=20