From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50083.outbound.protection.outlook.com [40.107.5.83]) by dpdk.org (Postfix) with ESMTP id 1713D3772; Sun, 21 Jan 2018 07:37:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KlT2z5UJPT77r8JH9zVNMFdOU7tpT5jHMmZyLSZDlHw=; b=V9S2MLAeuMh4tkY03PcNoCJ6t+7XcYseL/nPB0xEh63q+4WpqNjc1Kv5TNW9mnb//p0BlaV12EC9PyKF6gauPudZI0ggXmZJzC+/RmyKJ6Cl74xNbMmRdc/LcpufB1pH/KmnVFzKINZI+Pf5DjV3Bkga+SxrNt+vUeJLtANxqnY= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1021.eurprd05.prod.outlook.com (10.162.11.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Sun, 21 Jan 2018 06:37:25 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0407.012; Sun, 21 Jan 2018 06:37:25 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Yongseok Koh" CC: Adrien Mazarguil , "dev@dpdk.org" , "Xueming(Steven) Li" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix Memory Region lookup Thread-Index: AQHTkQC8KI6w2vmPiUmWdKlhq4/TQaN94nRg Date: Sun, 21 Jan 2018 06:37:25 +0000 Message-ID: References: <20180119075255.2542-1-yskoh@mellanox.com> <20180119083709.p7p5p6xmlqp6eh6x@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180119083709.p7p5p6xmlqp6eh6x@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1021; 6:YwqF8CeIn0A0EzR+kUFjbr+GamdnFpDplmrpKiGoX/+I5r4IfoZgHkzi/sUo9lKaKxH5PLXVAJkq+7ScExcHME52Ugc/xRljcYDiss0iZZ8d+WZrL22uYalQJm9EbDfF7xvfGKyhya1XJjifq9YsvnswOACHSzxCmf/PDYNqq7Ir8ALLBYV/QNpdL79b3ZCx2zI9dDeVRSQBIFodF69iXA7bzxMJW4S/y1RKxHTc1EkZRW+BsRcdH3maekGybmONF+Mg7tIKbqW+jtZQHCC2R+DapIW78dguyzxWdX/muYb5Z+QN7r/ctTi9oHM1qAHwosBjm+9kHs9QNzyPHnfO+It69S15PaMXACoHjmkaHo2nQ/DL9a6bSVOmpreLcu9I; 5:XymbhGBWkZc0L6Soi6k37pCEe2cpa5oO2soELVzzBjHCjOo2AW4MyX0uLTEkmiIhGsvwHmrTKcvJy1/XrMXvZGhWiQ4Mhmd7rJquf8/ApCWZhU91/eOZDpPx3T83hy2GSTNJ+D8WNe+H5Aq5397bVeal7mbRVBZwJq5OJOCmC1s=; 24:gLTy5TPEdm6vOzKJ7/A76kdGMcewzsItiS50+xeacJptxGKR25qpo2BNq63aWHohn5q2gHAwGE7LJpeiS1MKMYoSyxnml2NMtp5fol4LzMg=; 7:FhCW4ezN9p1/H/q0mQeRfuPwqLrBWdcwRpdKPXgb0r5O9kP9gohXlvRpFtCHxnlh3XD5L2T1PnP9yS4dyjkDjC/YsfvnX+tgPGVTur8tKhkrx/gjlZcviKu/7I0kSXifSvz88NVpZ1FiOKIYib6IsvzkzY3Cb43Ps7jNZlrDSij6uC0fc5dNumKtf2VoRdgxmLeAS6U5NqpyBHF/fnw6XuFcmIBH5ORcVAU7NdjcaHpyEpaFVWp9ToTx/3W50udD x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 78acc23c-661b-4f95-63f8-08d560996f5b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1021; x-ms-traffictypediagnostic: VI1PR05MB1021: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR05MB1021; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB1021; x-forefront-prvs: 0559FB9674 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39860400002)(39380400002)(366004)(189003)(199004)(7696005)(102836004)(97736004)(2906002)(26005)(6506007)(53936002)(229853002)(2950100002)(55016002)(9686003)(6436002)(6636002)(3846002)(86362001)(575784001)(5660300001)(110136005)(54906003)(99286004)(6246003)(6116002)(5250100002)(76176011)(66066001)(3660700001)(14454004)(3280700002)(316002)(8676002)(81166006)(81156014)(106356001)(25786009)(2900100001)(105586002)(74316002)(305945005)(7736002)(68736007)(8936002)(33656002)(478600001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1021; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: AJm9VSlWV9FXsZlPPOuFmErpw0KmnSJLPh678Zd6/7pLa3LJIavKmgoi5KkNEBlYNWBAvDQOtLWBQuWD3twMcA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78acc23c-661b-4f95-63f8-08d560996f5b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2018 06:37:25.5753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1021 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Memory Region lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 06:37:28 -0000 Friday, January 19, 2018 10:37 AM, N=E9lio Laranjeiro: > On Thu, Jan 18, 2018 at 11:52:55PM -0800, Yongseok Koh wrote: > > This patch reverts: > > commit 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration") > > > > Although granularity of chunks in a mempool is a cacheline, addresses > > are extended to align to page boundary for performance reason in > > device when registering a MR (Memory Region). This could make some > > regions overlap, then can cause Tx completion error due to incorrect > > LKEY search. If the error occurs, the Tx queue will get stuck. It is > > because buffer address is compared against aligned addresses for > > Memory Region. Saving original addresses of mempool for comparison > doesn't create any overlap. > > > > Fixes: b0b093845793 ("net/mlx5: use buffer address for LKEY search") > > Fixes: 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration") > > Cc: stable@dpdk.org > > > > Reported-by: Xueming Li > > Signed-off-by: Xueming Li > > Signed-off-by: Yongseok Koh > Acked-by: Nelio Laranjeiro Applied to next-net-mlx, thanks.=20 >=20 > -- > N=E9lio Laranjeiro > 6WIND