From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0089.outbound.protection.outlook.com [104.47.2.89]) by dpdk.org (Postfix) with ESMTP id 683F06D45 for ; Mon, 11 Sep 2017 09:56:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7zN5aAIB180r8CLNEtmL0gKgds6tVlnXNswRjztkNSI=; b=VFBLYFLUoG5FKvJ3zBtsDlOsZPQtwB7o7IvJKEDA2iEdbuLDxQiCU13ynm24/H772q9ool/l6JyqlI4j89l+XFZUTGJdCMxvG6na+WetD9yrwzrCUeSHoeo+EAR2ZFpvZtSEBgfwA0YGdgqZ9w6LJhcarX/JcDGRs4IoIjaVqG0= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1405.eurprd05.prod.outlook.com (10.162.123.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Mon, 11 Sep 2017 07:56:05 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0056.010; Mon, 11 Sep 2017 07:56:05 +0000 From: Shahaf Shuler To: Jerin Jacob CC: Stephen Hemminger , Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API Thread-Index: AQHTKi2DBuCZy0EdtkKBpDN66oo+k6KuZaiAgADHvZCAAAqdAIAAGXzw Date: Mon, 11 Sep 2017 07:56:05 +0000 Message-ID: References: <20170910104827.11da9230@xeon-e3> <20170911062119.GA9342@jerin> In-Reply-To: <20170911062119.GA9342@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1405; 6:9vOHVdARK5NaIzB5rqPA5Yib13Jx7XZJeKtEhBpnRHce8MosoyTVfjn29Wukfq3/tr6egzxP2Od3qEs0HCuA41BmJk19CPqfYDAfdm1mpKoIVpQZRWOKfQH1XLsWBQgk482VRVpv+eKKk+ho81QhmM0hMz0Fxu43s+qkoKhvZyD23TbU6r0kpmAVQpnSasQMzGZR4CpcycIxBPkgyLHRN+NOuGebBedQ1nwAoFP+VOrNizwmPXt3AECS1LY2h3Pr6hvzvF28pd1yHL3OAY33eP06e6zAoLFddpTv/ymf0pd3GtgoiDIDhUnKPVFXuyw2bfZm+Sl7iaGh6rbJZjzygg==; 5:ev8pe8uaRyu4HiF+eUfVsA/n6osaXGTFM8P9xqFA2rGYqJdnq6IWhLg2QeAfdmeBmZoCIjowcKDRQYKKG5yED0wekMiq82JnbxjGOpIXOGhmr3zleq2o96jlX8+KqaX9vRH9sgI6nhWr33O4joA9bw==; 24:WblXqVebP++1nXNI5ynhSAkqlAKAkStfVQSJMLAQ+5AAIqj7plMXDoKfrWYVVVyjNbxku01+uGSF+PJAoN5UXPXoLkf2np26m1F7iDiBOx8=; 7:nT97X+Di/4MFgHyAUpqJo5mXLF+9yUmq3uZMY3p2fMz740f5p2sAHJ2trTMKko+zJQH54aoF3vXs9rB0jvQ/w3zNj2XXK9mVmS7T/L5fpkhcGX5ztUuhAK27UNXikcGXlGP3RXCven76cmOjT3gbN/czCKyy1HBw7PUzmkGRjVpKajfSDXA7XFb/Mku1/2lYZHITMfC/u7U67oCu3HZR07xR7/CYveFJNzHcBUywfiM= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: ea4eb5b8-adc7-43ae-bbef-08d4f8ea8dfc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB1405; x-ms-traffictypediagnostic: VI1PR05MB1405: x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1405; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1405; x-forefront-prvs: 04270EF89C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(189002)(199003)(377454003)(2906002)(86362001)(2900100001)(25786009)(14454004)(68736007)(105586002)(53936002)(97736004)(6116002)(6506006)(6436002)(9686003)(33656002)(55016002)(45080400002)(54906002)(6306002)(478600001)(99286003)(229853002)(102836003)(3846002)(305945005)(3280700002)(7736002)(66066001)(50986999)(6916009)(4326008)(2950100002)(54356999)(76176999)(8676002)(110136004)(3660700001)(81166006)(81156014)(6246003)(966005)(5250100002)(189998001)(101416001)(8936002)(7696004)(106356001)(93886005)(74316002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1405; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2017 07:56:05.3800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1405 Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 07:56:07 -0000 Monday, September 11, 2017 9:21 AM, Jerin Jacob: >=20 > I don't think that is in following this series. It should be in this seri= es, if we are > removing a feature then we should find a way to fit that in some location= as > there is a use case for it[1]. Without an alternative, this patch is NACK= from > me. >=20 > [1] > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2017- > September%2F074475.html&data=3D02%7C01%7Cshahafs%40mellanox.com%7 > C6ce00422e1db4075f9f808d4f8dd5f39%7Ca652971c7d2e4d9ba6a4d149256f46 > 1b%7C0%7C0%7C636407077062635613&sdata=3DINJMOfiL9iwSboWuTVhnVvllu > e2gS1%2FVB4Aj9XP09No%3D&reserved=3D0 I don't understand. >>From the exact link above, you explicitly say that *you* will move this fla= gs once the series is integrated. Quoting: "=20 > Please Jerin, could you work on moving these settings in a new API? Sure. Once the generic code is in place. We are committed to fix the PMDs by 18.02. " What has changed?