From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20055.outbound.protection.outlook.com [40.107.2.55]) by dpdk.org (Postfix) with ESMTP id B2086199AC; Thu, 25 Jan 2018 17:00:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Bhx7ayfbJctsGP9naLRGytcAlivIbmI7RKcjiYXwyys=; b=Bb1JLHS+9KPctAOIYkD1W7kh0DAL8hMtf/gRi41fR+Qz0cbjZekbAnXVaL8D63zJgc1uTtJ7mJKI3adbHr8kxm3LKQHDkBkfdRmJNOHYDsSXATVSRDL9Z4Bj4UUZxSxRbn5VCy+9VX5M4aVYme9tM8tc/IT3BQ9ydVhH2mixvk0= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1550.eurprd05.prod.outlook.com (10.164.85.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 25 Jan 2018 16:00:10 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0428.019; Thu, 25 Jan 2018 16:00:10 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" CC: "dev@dpdk.org" , Yongseok Koh , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix reception of multiple mac addresses Thread-Index: AQHTlbWi1uDWK7/NwUm3SSE+BN7Yx6OEv3Uw Date: Thu, 25 Jan 2018 16:00:10 +0000 Message-ID: References: <8d4931d99cd295d8779aefa21900a4e2779e7000.1516868517.git.nelio.laranjeiro@6wind.com> In-Reply-To: <8d4931d99cd295d8779aefa21900a4e2779e7000.1516868517.git.nelio.laranjeiro@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1550; 7:z8drjCIhnAynBmoLbBiVY8TiiHJvtOunS+aPWofCPcfJHXXK9cb4T/6br0Kwk3zhg35ycE4NZkFtQVeHA+ICdX/EaQAbvUPnQMPsN4eir8RRleB+9v8n/2KpWFfW4evvPEkQhn6nKGDWDEacO+tz3sdRDoNqHGhdNpOSBX5KqIZKlFf9XiOU6yWHys03qYz9jR1jeYteCgIO2cSIo9N+MxngPVPqaVDaXRRhpNexjxZYLOI/dFSDuht3QKx1wzrJ x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ad98ae6f-6186-4512-8f4c-08d5640cb6a1 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1550; x-ms-traffictypediagnostic: VI1PR05MB1550: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231023)(2400081)(944501161)(3002001)(6055026)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR05MB1550; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1550; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(396003)(39380400002)(366004)(199004)(189003)(26005)(33656002)(97736004)(105586002)(55016002)(66066001)(6116002)(106356001)(2950100002)(4326008)(2906002)(6436002)(186003)(2900100001)(14454004)(5660300001)(478600001)(5250100002)(53936002)(305945005)(59450400001)(8936002)(25786009)(3280700002)(81156014)(99286004)(74316002)(102836004)(81166006)(8676002)(7736002)(6246003)(9686003)(110136005)(316002)(3660700001)(3846002)(54906003)(86362001)(6506007)(76176011)(7696005)(229853002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1550; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: a5/5J7roW+Mh2kPsOc3whvqmOKjmsvJ0L826izTbSSspW564vC98O3LlBdFNqKpcRH1ogLzfAsaHjmVCCalVHw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad98ae6f-6186-4512-8f4c-08d5640cb6a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 16:00:10.7969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1550 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix reception of multiple mac addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 16:00:12 -0000 Thursday, January 25, 2018 10:22 AM, Nelio Laranjeiro: > Subject: [PATCH] net/mlx5: fix reception of multiple mac addresses >=20 > When promiscuous is disabled, adding/removing a mac address is ignored > causing the packet to not be received or still being received correspondi= ng to > the add or remove request. >=20 > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > Cc: stable@dpdk.org >=20 > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_mac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c > index a5e78ec8d..a1cb987cb 100644 > --- a/drivers/net/mlx5/mlx5_mac.c > +++ b/drivers/net/mlx5/mlx5_mac.c > @@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev, > uint32_t index) { > assert(index < MLX5_MAX_MAC_ADDRESSES); > memset(&dev->data->mac_addrs[index], 0, sizeof(struct > ether_addr)); > - if (!dev->data->promiscuous && !dev->data->all_multicast) > + if (!dev->data->promiscuous) > mlx5_traffic_restart(dev); > } >=20 > @@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct > ether_addr *mac, > return EADDRINUSE; > } > dev->data->mac_addrs[index] =3D *mac; > - if (!dev->data->promiscuous && !dev->data->all_multicast) > + if (!dev->data->promiscuous) > mlx5_traffic_restart(dev); > return ret; > } > -- Acked-by: Shahaf Shuler Applied to next-net-mlx, thanks.=20 > 2.11.0