* [dpdk-dev] [PATCH] net/mlx5: fix reception of multiple mac addresses
@ 2018-01-25 8:22 Nelio Laranjeiro
2018-01-25 16:00 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Nelio Laranjeiro @ 2018-01-25 8:22 UTC (permalink / raw)
To: Adrien Mazarguil; +Cc: dev, Shahaf Shuler, Yongseok Koh, stable
When promiscuous is disabled, adding/removing a mac address is ignored
causing the packet to not be received or still being received corresponding
to the add or remove request.
Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
Cc: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c
index a5e78ec8d..a1cb987cb 100644
--- a/drivers/net/mlx5/mlx5_mac.c
+++ b/drivers/net/mlx5/mlx5_mac.c
@@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)
{
assert(index < MLX5_MAX_MAC_ADDRESSES);
memset(&dev->data->mac_addrs[index], 0, sizeof(struct ether_addr));
- if (!dev->data->promiscuous && !dev->data->all_multicast)
+ if (!dev->data->promiscuous)
mlx5_traffic_restart(dev);
}
@@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac,
return EADDRINUSE;
}
dev->data->mac_addrs[index] = *mac;
- if (!dev->data->promiscuous && !dev->data->all_multicast)
+ if (!dev->data->promiscuous)
mlx5_traffic_restart(dev);
return ret;
}
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix reception of multiple mac addresses
2018-01-25 8:22 [dpdk-dev] [PATCH] net/mlx5: fix reception of multiple mac addresses Nelio Laranjeiro
@ 2018-01-25 16:00 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-01-25 16:00 UTC (permalink / raw)
To: Nélio Laranjeiro, Adrien Mazarguil; +Cc: dev, Yongseok Koh, stable
Thursday, January 25, 2018 10:22 AM, Nelio Laranjeiro:
> Subject: [PATCH] net/mlx5: fix reception of multiple mac addresses
>
> When promiscuous is disabled, adding/removing a mac address is ignored
> causing the packet to not be received or still being received corresponding to
> the add or remove request.
>
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_mac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c
> index a5e78ec8d..a1cb987cb 100644
> --- a/drivers/net/mlx5/mlx5_mac.c
> +++ b/drivers/net/mlx5/mlx5_mac.c
> @@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev,
> uint32_t index) {
> assert(index < MLX5_MAX_MAC_ADDRESSES);
> memset(&dev->data->mac_addrs[index], 0, sizeof(struct
> ether_addr));
> - if (!dev->data->promiscuous && !dev->data->all_multicast)
> + if (!dev->data->promiscuous)
> mlx5_traffic_restart(dev);
> }
>
> @@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct
> ether_addr *mac,
> return EADDRINUSE;
> }
> dev->data->mac_addrs[index] = *mac;
> - if (!dev->data->promiscuous && !dev->data->all_multicast)
> + if (!dev->data->promiscuous)
> mlx5_traffic_restart(dev);
> return ret;
> }
> --
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to next-net-mlx, thanks.
> 2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-25 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-25 8:22 [dpdk-dev] [PATCH] net/mlx5: fix reception of multiple mac addresses Nelio Laranjeiro
2018-01-25 16:00 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).