From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0043.outbound.protection.outlook.com [104.47.0.43]) by dpdk.org (Postfix) with ESMTP id 35BC92B84 for ; Tue, 12 Sep 2017 10:03:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UbRC21O1+/qtqxa9PzEsEhs3ZzNkPupfBGNmZEJcO/8=; b=LB6UaRR1fAshT97oSBD3ekaUbxglimlHDcLe4b23TatdT+IVficFR1GBAStAogyHI/NuJrDc+3guU9qaH53YON65I0yxSIX7LQY1J2W9vwZMZYRHwOcLTkJH2pAQbZklcMvEkp7dgSRfxnYCDBRyZ2qkrd+2qLMBH+NhxsF2WFQ= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3455.eurprd05.prod.outlook.com (10.170.239.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Tue, 12 Sep 2017 08:03:31 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0056.010; Tue, 12 Sep 2017 08:03:31 +0000 From: Shahaf Shuler To: Jerin Jacob CC: "Ananyev, Konstantin" , Stephen Hemminger , Thomas Monjalon , "dev@dpdk.org" , "Zhang, Helin" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API Thread-Index: AQHTK3vU0az8vg6wSEi8rTEyl6rvcKKwtC+ggAALQICAAAW8gIAAEkmAgAAJUTA= Date: Tue, 12 Sep 2017 08:03:31 +0000 Message-ID: References: <20170911062119.GA9342@jerin> <20170911080621.GA15867@jerin> <20170911090543.GA9965@jerin> <2601191342CEEE43887BDE71AB9772584F2497DC@irsmsx105.ger.corp.intel.com> <20170912040107.GA8081@jerin> <20170912055137.GA24921@jerin> <20170912071735.GA29366@jerin> In-Reply-To: <20170912071735.GA29366@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3455; 6:jORCX0NaK2iaHkKaZ3A9UaobsTV3G2jXV/aCAN+0w9HbK0Z1Ng6E1W6wCbQG+PcQP+UC4K9bLq8ZiYazwqTLgL4wC6y2yoLHxp/pca8SB8GRzHQVdhTVDC26CbdYynbAX+G78XGXn65B7poJKEgdMx7+4t/3L8HZGQV1YJlSC/gx8MIUnzsuVWhtI1BcXMUirkY+xqcIFofgOyCJnP5n2u6tGIZLd7Q/wHiKeqgVn3bZrhdH4mOKyLY+wzP3VIrCIiI6PyFJz01MmxXkckZEvRT5IASBSDWFqqp3MrDloHDN+n5SmbDu2UKHZumReZOdFVX7V6qeXDPq3RnRc78Ksg==; 5:iCU8sQCCXmQ8mM1EADAOMFRtjX4rA87TA9sJIaVy+B0sEa8my4G/2BEBn6Jp0HMnBkSxYP7/ofhWu40tuP6alVV5+6ZiCGGofw1D3F278EwaawS/E5P90dUnTq082yaQ1VGRbf2ueCYFTHJNI1XGmA==; 24:oPVoLXx8OjlJTw1GiPUKCQ+lZrCQrYa6y27V/Y29Pp/LRx2/c+xorc6f3PJxTY8qiCf5fNXbLN6yFMb/ZJEDFwYn8icNIkIuWPpdakLJgYQ=; 7:fl0x5xi+vxB987vO5slmVy2f9EWOM6HhMnGtnHqjp1Up+KXEQirYot95vFTxghRBni9WKy2fXT5b8hE+YTY+yMYuVgBge1Hmojv2Iv9ti+GXCkWj+Z5wCSi0sKY/ZlmeRy0A7Ue4J47jMohyd2LdV+wcPaN9Rs2sFmi99hRvIMBRXFF8A7aN4Wi6fpKYM8AgEFJxV9cNOFmxqvnPfHq3Hkn/jjTOXv23N+dfZHxTSD4= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 7cb0ac96-88f7-4eb8-5c19-08d4f9b4c26c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB3455; x-ms-traffictypediagnostic: VI1PR05MB3455: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3455; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3455; x-forefront-prvs: 042857DBB5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(39860400002)(377454003)(199003)(51444003)(189002)(6116002)(66066001)(105586002)(106356001)(33656002)(68736007)(97736004)(102836003)(478600001)(74316002)(7736002)(86362001)(305945005)(3846002)(6436002)(5250100002)(93886005)(14454004)(6246003)(81166006)(54906002)(8676002)(2950100002)(81156014)(6916009)(110136004)(55016002)(189998001)(6506006)(229853002)(8936002)(53936002)(9686003)(99286003)(2906002)(5660300001)(2900100001)(7696004)(3280700002)(25786009)(4326008)(3660700001)(54356999)(50986999)(101416001)(316002)(76176999)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3455; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2017 08:03:31.6143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3455 Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 08:03:34 -0000 Tuesday, September 12, 2017 10:18 AM, Jerin Jacob: > > Tuesday, September 12, 2017 8:52 AM, Jerin Jacob: > > > > I understand the use case, and the fact those flags improve the > > > performance on low-end ARM CPUs. > > > > IMO those flags cannot be on queue/port level. They must be global. > > > > > > Where should we have it as global(in terms of API)? > > > And why it can not be at port level? > > > > Because I don't think there is a use-case that application would want t= o > have recounting on one port and not on the other. It is either applicatio= n > clone/not clone mbufs. > > Same about the multi mempool. It is either application have it or not. >=20 > Why not? If a port is given to data plane and another port to control pla= ne. It > can have different characteristics. >=20 > Making it port level, we can achieve the global use case as well. but not > another way around. >=20 > MULTISEG flag also has the same attribute. But some reason you are OK to > include that in flags. >=20 > > > > If there is a strong use-case for application to say on port X it clone= s mbufs > and and port Y it don't then maybe this is enough to have it per-port. > > We can go even further - why not to have guarantee per queue? it is > possible if application is willing to manage. > > > > Again those are not offloads, therefore if we expose those this should = on > different location the offloads field on eth conf. >=20 > What is the definition of offload? It is something we can offload to HW. > If so, then, reference count we can offload to HW with external HW pool > manager which DPDK has support now. OK, well understood the requirement for such flags. Thanks for your replies= . I think that for simplicity I will add two more flags on the Tx offloads ca= pabilities: DEV_TX_OFFLOADS _MULTI_MEMPOOL <** Device supports transmission of mbufs fr= om multiple mempools. */ DEV_TX_OFFLOADS_INDIRECT_MBUFS <** Device support transmission of indirect = mbufs. */ Those caps can be reported by the PMD as per-port/per-queue offloads. Appli= cation will choose how to set those. When not set - PMD can assume all mbuf= s has ref_cnt =3D 1 and the same mempool. Any objection?=20