From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0063.outbound.protection.outlook.com [104.47.0.63]) by dpdk.org (Postfix) with ESMTP id A69D17CFC; Wed, 6 Dec 2017 07:43:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ajaW4GL40BzaxBmMtpLEl+lfP6AQH19tbyD2Zix0Ee0=; b=xHTPaGknn3sIETlQu1IqtNaLiuSZmr5qpgR4Oux3PZwn+PP2f0k+QUHwRsDQpf8epUQXlqbRy9YWLM9KdpyaxYK9WeL6WDToq2RcCSpxZhcf9zTmgaxsVJtQ57OBa0IsvSBiZIeofQWW6BFaJgEPSw0N5HK8FSGfDUilFpAzMhU= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1231.eurprd05.prod.outlook.com (10.162.15.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Wed, 6 Dec 2017 06:43:07 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3905:ed70:f744:9dc6]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3905:ed70:f744:9dc6%13]) with mapi id 15.20.0260.008; Wed, 6 Dec 2017 06:43:07 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Raslan Darawsheh" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] net/mlx5: fix flow type for allmulti rules Thread-Index: AQHTbazBz1Pl0W4c2UaAYZggo4sA1aM0g1aAgAFb3UA= Date: Wed, 6 Dec 2017 06:43:07 +0000 Message-ID: References: <1512466670-19229-1-git-send-email-rasland@mellanox.com> <20171205095639.sebpze34rhlt5jdd@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20171205095639.sebpze34rhlt5jdd@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1231; 6:rQKu/wORuoONP6ApEIJa8YhmwQm1fyGCRgbodOxuokXwsaCsn7C4OxGVmlVOzzW4mPXivxpy+hXMnZEfN/Uz7jC2E0TIu9EWhwE/SpII4Vg/lX4ruzt4U0NXEgtFqUhnItYRXLgS3BmcbLn+S4qc0JLk9iVOwxkxVRRe8p67fq6wnWs0ST4uaHKCfdsG9slvhXqBqpUjSyHgTAFk8a5zCHWbtgypbpOI2hq5+KIpwl0T4idVyofdLw08T74pmRm5nfbOzvQoBl53xmDWUxEhvL2IehCCtjhQIpsd7cKZJG/717S3QiYrblX5xq9d/JGKZLxGHghWfu7zJt1S25WW3rl2qqZJAI2piHq4uPk1RLc=; 5:gcxnz3MJQuCu3kgjkGuRyCaxaX2BmW8wy5Jxw/bczwr2Q3oJHlxTrpk6YK9cAtsXsEXNdm+YBI7YnEN0w/+A/qd/5AbOg05UJyeqcgby80Ha4f/cXro8aEdrgFPcaYQs0ip/iw9Dseh0gvd7EQIcUhfW7QMn4eksKDgogVtLCwY=; 24:8huG9vNwlFp8ZLYb2NzZ3dVBsrqmqvFyOKs65JlLe8FGOFWb/V15cgszHDRxle3zYYzgA+9S3uM3mAn3BTYV1ZZoGE2myQ4QCm8T1ur+dqM=; 7:0dQL3UBJGDoTuJbCjw90aeLYpzacsMNhTRikOA+0TiTx9wr2Zc90nuGjr8cnyz/ndfj176eY1oy2T7p/ae6xFqkgm4VDnDFV/RypAK5SOrkrzmy/XSfFr7v5gDl51EbeFe3vG8QCwO0It41IHBX7uQ4RrpcmJba0LuhRSmG08ewqrEEojODEtQ86AjEM5orxUpb0ZMbyeo6P/ahseQniyurR9BNm8ffHc4ANKSmd7g4KY/3M2fdm760RrleGbfOj x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8681643b-2db2-4e76-3a29-08d53c749c0b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286); SRVR:VI1PR05MB1231; x-ms-traffictypediagnostic: VI1PR05MB1231: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3231022)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(201703131423075)(201703011903075)(201702281528075)(201703061421075)(20161123555025)(6072148)(201708071742011); SRVR:VI1PR05MB1231; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB1231; x-forefront-prvs: 05134F8B4F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7966004)(346002)(39860400002)(366004)(376002)(24454002)(199004)(189003)(86362001)(2950100002)(6636002)(2906002)(105586002)(101416001)(106356001)(110136005)(2900100001)(3660700001)(3280700002)(3846002)(5660300001)(316002)(33656002)(66066001)(102836003)(4326008)(74316002)(7736002)(68736007)(9686003)(55016002)(6246003)(76176011)(305945005)(99286004)(54906003)(8676002)(8936002)(53936002)(81166006)(6116002)(81156014)(6436002)(7696005)(97736004)(6506006)(508600001)(5250100002)(229853002)(14454004)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1231; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8681643b-2db2-4e76-3a29-08d53c749c0b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2017 06:43:07.3553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1231 Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix flow type for allmulti rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 06:43:12 -0000 Tuesday, December 5, 2017 11:57 AM, Nelio Laranjeiro: > On Tue, Dec 05, 2017 at 11:37:50AM +0200, Raslan Darawsheh wrote: > > Chnaged ibv_flow_attr type for allmulti rule to > > IBV_FLOW_ATTR_MC_DEFAULT instead of IBV_FLOW_ATTR_NORMAL, in > case allmulti was enabled. > > > > Fixes: 272733b5 ("net/mlx5: use flow to enable unicast traffic") > > > > Signed-off-by: Raslan Darawsheh > > --- > > drivers/net/mlx5/mlx5_flow.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > b/drivers/net/mlx5/mlx5_flow.c index 1eda836..eaa53e2 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -429,6 +429,7 @@ static const struct mlx5_flow_items > > mlx5_flow_items[] =3D { > > /** Structure to pass to the conversion function. */ struct > > mlx5_flow_parse { > > uint32_t inner; /**< Set once VXLAN is encountered. */ > > + uint8_t allmulti:1; /** Set once allmulti dst MAC is encountered. */ Changed comment to /**< Set once allmulti dst MAC is encountered. */ to fit= doxygen style.=20 > > uint32_t create:1; > > /**< Whether resources should remain after a validate. */ > > uint32_t drop:1; /**< Target is a drop queue. */ @@ -1165,6 > +1166,17 > > @@ priv_flow_convert(struct priv *priv, > > } > > } > > } > > + if (parser->allmulti && > > + parser->layer =3D=3D HASH_RXQ_ETH) { > > + for (i =3D 0; i !=3D hash_rxq_init_n; ++i) { > > + if (!parser->queue[i].ibv_attr) > > + continue; > > + if (parser->queue[i].ibv_attr->num_of_specs !=3D 1) > > + break; > > + parser->queue[i].ibv_attr->type =3D > > + > IBV_FLOW_ATTR_MC_DEFAULT; > > + } > > + } > > return ret; > > exit_enomem: > > for (i =3D 0; i !=3D hash_rxq_init_n; ++i) { @@ -1262,6 +1274,7 @@ > > mlx5_flow_create_eth(const struct rte_flow_item *item, > > eth.val.ether_type &=3D eth.mask.ether_type; > > } > > mlx5_flow_create_copy(parser, ð, eth_size); > > + parser->allmulti =3D eth.val.dst_mac[0] & 1; > > return 0; > > } > > > > -- > > 2.7.4 >=20 > It also concerns DPDK 17.11, adding stable@dpdk.org >=20 > Acked-by: Nelio Laranjeiro Applied to next-net-mlx with the Cc:stable@dpdk.org addition, thanks.=20 >=20 > -- > N=E9lio Laranjeiro > 6WIND