From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0089.outbound.protection.outlook.com [104.47.2.89]) by dpdk.org (Postfix) with ESMTP id C3C152B84 for ; Sat, 27 Jan 2018 19:14:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oH0SJ90c6n1vIH9CJgtbAUEFPfjuF3+26Khz140XxPA=; b=U8PvPxhR7SG3+7Au/ZRN5lzTpR4sCyrzxPlMuS5GeAzE+oMuYWj6SZiKF0Xbq0Gv/bZlR6BfHCaDC0Wp8vL5+utqYEdbidvt2kWr330GMICVR0+AUATJzyPbEa51ZoM+oRZMlWAHjg3wy23rWUb03Yxs7PVz26ZoSS9A7UTjAO8= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1662.eurprd05.prod.outlook.com (10.165.235.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Sat, 27 Jan 2018 18:14:35 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0444.016; Sat, 27 Jan 2018 18:14:35 +0000 From: Shahaf Shuler To: Thomas Monjalon , "Lu, Wenzhuo" CC: Mordechay Haimovsky , "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [PATCH] app/testpmd: do not enable Rx offloads by default Thread-Index: AQHTlbuSf5ZLiFZu2UOlNPkW46o9u6OFw7KAgAAE3YCAAAU8gIAACBGAgAIxtDA= Date: Sat, 27 Jan 2018 18:14:35 +0000 Message-ID: References: <1516695081-178919-1-git-send-email-motih@mellanox.com> <6183373.cbWzoGE1aT@xps> <6A0DE07E22DDAD4C9103DF62FEBC09093B721D05@shsmsx102.ccr.corp.intel.com> <4518250.zEhSojeenl@xps> In-Reply-To: <4518250.zEhSojeenl@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1662; 7:VdJpl+Dowmqf/Cd3e744F5axPUjWn6NHMOeX6hEXgznlCnmduwHx77j3e03BX3621wjRWGB39BMYl+SezAkVwIQuP/HMQOueNA9TIASfxL+AqhbG32BCBlgY+YzlxfNhwDaihDDxyqnv0aAp/CesRoX+zX9m03y0q55+rpyI3WkJ7btGdk/8NTRcwiU61JWaMweA2FKlR9eIb5ddBmg8v1sFA/fZ7LKFdx/eAlxlhqKYy5XPBDyAhS4dIKlk2+ib x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a9cb0ec8-7f99-4157-fbc3-08d565b1d241 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1662; x-ms-traffictypediagnostic: VI1PR05MB1662: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR05MB1662; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1662; x-forefront-prvs: 056544FBEE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(396003)(39380400002)(366004)(376002)(199004)(189003)(51444003)(52294003)(3660700001)(99286004)(97736004)(7736002)(105586002)(66066001)(305945005)(9686003)(5250100002)(316002)(55016002)(2906002)(14454004)(3846002)(6116002)(68736007)(2950100002)(3280700002)(2900100001)(5660300001)(478600001)(76176011)(229853002)(4326008)(6506007)(81166006)(93886005)(186003)(7696005)(6246003)(74316002)(53936002)(26005)(8676002)(86362001)(102836004)(8936002)(81156014)(110136005)(25786009)(6436002)(106356001)(59450400001)(33656002)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1662; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: aeVaaxn0TszSe209Uf5qHTUxJ6iHEK66vHxDBGt0I6jDgbdxLhpWx2gxF1KDbtojf6bVa4kVglaFYtqCzXBxOw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9cb0ec8-7f99-4157-fbc3-08d565b1d241 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2018 18:14:35.3480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1662 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 18:14:40 -0000 Friday, January 26, 2018 10:36 AM, Thomas Monjalon: > 26/01/2018 09:06, Lu, Wenzhuo: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 26/01/2018 08:30, Lu, Wenzhuo: > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > > Why these offload flags are silently enabled? > > > > > > > > I don't think it's silently. It's a global configuration. In this > > > > case, testpmd is > > > the user, it does request it explicitly. If it's not so explicit, > > > maybe we can consider moving all the configuration to a specific > configure file. > > > > Talking about why it's enabled by default. Hard to figure out the h= istory. > > > To my opinion, the original designer wants to simulate the common cas= e. > > > > > > Please do not justify a design mistake by history. > > > > > > This is a test tool, so we don't care about the common case. > > > A test tool should not try to guess the best configuration. > > > Only the user should decide the configuration to apply, and the > > > default should be empty, as the API is. > > > > I see the divergence. You think testpmd is a tool, so it should be whit= e > paper as the tool users may suppose it is. > > I think testpmd is an example to let the APP developers know how to use > DPDK. So any pre-configuration is acceptable. If so, then what this patch shows that it is not such a good example to app= lication writers.=20 Application should not set offloads that are not supported by the PMD. Pre-= configuration is OK, but adjustment is a must according to the PMD caps.=20 I think that many PMD have a wrong behavior due to it. They are forced to s= ilently drop un-supported offload configuration (to enable testpmd to run o= n top of them). This will end up, for example, in application which expects to have the VLA= N tag in the mbuf (because the configuration passed successfully), while in= fact it will be always in the packet headers.=20 I didn't change it on my series because I wanted to convert the application= "as is" from the old to the new offloads API, however I do think a change= is needed here. =20 >=20 > Ah ah ah :) > No > Examples are in examples/ directory.