From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) by dpdk.org (Postfix) with ESMTP id A3C0C1B668 for ; Tue, 6 Feb 2018 12:31:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dMpD+m0H0fFpCw6hnH/jIhrHavRmFyMgDUs9EGtnVLg=; b=yciFpIFT+XqPMITirG1BsxhNdNZAAdOguB7L2dp6xsO4WwyKWfl/zrR9f7dlOLDr45QW0IbOqJp+Xiyabn5n+Fw+uS1MbtkjjKDnUnvmgC8XBlkd8G3EG+gees6AaFSqyEvD1857R5Md9gTkOs122ml/s57jZB4fI67DlsqszTw= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1279.eurprd05.prod.outlook.com (10.162.122.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Tue, 6 Feb 2018 11:31:24 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0464.015; Tue, 6 Feb 2018 11:31:24 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Marcelo Ricardo Leitner Thread-Topic: [PATCH v2 0/4] net/mlx: enhance rdma-core glue configuration Thread-Index: AQHTnEVd2iuTZb7b/0iOXUs9Tq2SxqOXQ0NA Date: Tue, 6 Feb 2018 11:31:24 +0000 Message-ID: References: <20180202144736.8239-1-adrien.mazarguil@6wind.com> <20180202164050.13017-1-adrien.mazarguil@6wind.com> In-Reply-To: <20180202164050.13017-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1279; 7:QDXW4wZz3Ev+hUsVXwSegpgv8VnceJekcFhcnOjtgw+zw6zQj6qnPA9iTP40+vzZh+Jxr1SOyEHoHB17GQQQbLf/0JK7WBa8wXOUa94kfeApAk6WJ4pJHC8Ij7dRiRX/CuZiTy1iNxz0Ngr7Fy98aDJwfW2thPNezWEMrI6qS7RoIzyEvk7CUpN8w3JHMIO/nbEwiujk0js+qCg+rcLdgBs7YJgfk1+0iKzHz2JSgGybdXEDhGU8WWHJ8uiXLDCP x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 141aa209-fda3-4f9b-954a-08d56d5527ac x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1279; x-ms-traffictypediagnostic: VI1PR05MB1279: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(192374486261705)(189930954265078)(45079756050767); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR05MB1279; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1279; x-forefront-prvs: 0575F81B58 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(376002)(396003)(39380400002)(189003)(199004)(2900100001)(7736002)(305945005)(4326008)(105586002)(2906002)(5250100002)(5660300001)(26005)(6246003)(186003)(68736007)(6116002)(3846002)(8676002)(81166006)(8936002)(81156014)(74316002)(66066001)(3280700002)(3660700001)(99286004)(966005)(53936002)(76176011)(106356001)(7696005)(59450400001)(97736004)(25786009)(6506007)(6436002)(14454004)(102836004)(55016002)(33656002)(2950100002)(54906003)(6916009)(478600001)(6306002)(9686003)(45080400002)(86362001)(229853002)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1279; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ciHQTrUyxlb85vUAhNjLsobaPpyxP5ZMJykeIVJmybCb7XIstkSCt/NfFtoWyvWJjHvb99z2bX4vA6eIx3Jvaw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 141aa209-fda3-4f9b-954a-08d56d5527ac X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2018 11:31:24.6812 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1279 Subject: Re: [dpdk-dev] [PATCH v2 0/4] net/mlx: enhance rdma-core glue configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 11:31:26 -0000 Friday, February 2, 2018 6:46 PM, Adrien Mazarguil: > The decision to deliver mlx4/mlx5 rdma-core glue plug-ins separately inst= ead > of generating them at run time due to security concerns [1] led to a few > issues: >=20 > - They must be present on the file system before running DPDK. > - Their location must be known to the dynamic linker. > - Their names overlap and ABI compatibility is not guaranteed, which may > lead to crashes. >=20 > This series addresses the above by adding version information to plug-ins > and taking CONFIG_RTE_EAL_PMD_PATH into account to locate them on the > file system. Series applied to next-net-mlx, with the following diff in patch 3/4: diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index cc9db9977..cc800493b 100644 =20 --- a/drivers/net/mlx4/Makefile =20 +++ b/drivers/net/mlx4/Makefile =20 @@ -35,7 +35,7 @@ include $(RTE_SDK)/mk/rte.vars.mk =20 LIB =3D librte_pmd_mlx4.a =20 LIB_GLUE =3D $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) =20 LIB_GLUE_BASE =3D librte_pmd_mlx4_glue.so =20 -LIB_GLUE_VERSION =3D 18.02.1 =20 +LIB_GLUE_VERSION =3D 18.02.0 =20 =20 # Sources. =20 SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) +=3D mlx4.c =20 diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index 4086f2039..3bc9736c9 100644 =20 --- a/drivers/net/mlx5/Makefile =20 +++ b/drivers/net/mlx5/Makefile =20 @@ -35,7 +35,7 @@ include $(RTE_SDK)/mk/rte.vars.mk =20 LIB =3D librte_pmd_mlx5.a =20 LIB_GLUE =3D $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) =20 LIB_GLUE_BASE =3D librte_pmd_mlx5_glue.so =20 -LIB_GLUE_VERSION =3D 18.02.1 =20 +LIB_GLUE_VERSION =3D 18.02.0 =20 Thanks.=20 >=20 > [1] > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2018- > January%2F089617.html&data=3D02%7C01%7Cshahafs%40mellanox.com%7C6d > 6d87b37a574c15f41808d56a5c7eae%7Ca652971c7d2e4d9ba6a4d149256f461b > %7C0%7C0%7C636531867854846685&sdata=3D9Bc7lEnU%2Fq4E5PxgOkEvgwDN > zc46%2BZ1B5boHyxg1Cuo%3D&reserved=3D0 >=20 > v2 changes: >=20 > - Fixed extra "\n" in glue file name generation (although it didn't break > functionality). >=20 > Adrien Mazarguil (4): > net/mlx: add debug checks to glue structure > net/mlx: fix missing includes for rdma-core glue > net/mlx: version rdma-core glue libraries > net/mlx: make rdma-core glue path configurable >=20 > doc/guides/nics/mlx4.rst | 17 ++++++++++++ > doc/guides/nics/mlx5.rst | 14 ++++++++++ > drivers/net/mlx4/Makefile | 8 ++++-- > drivers/net/mlx4/mlx4.c | 57 > ++++++++++++++++++++++++++++++++++++++- > drivers/net/mlx4/mlx4_glue.c | 4 +++ > drivers/net/mlx4/mlx4_glue.h | 9 +++++++ > drivers/net/mlx5/Makefile | 8 ++++-- > drivers/net/mlx5/mlx5.c | 57 > ++++++++++++++++++++++++++++++++++++++- > drivers/net/mlx5/mlx5_glue.c | 1 + > drivers/net/mlx5/mlx5_glue.h | 7 +++++ > 10 files changed, 176 insertions(+), 6 deletions(-) >=20 > -- > 2.11.0