From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48]) by dpdk.org (Postfix) with ESMTP id 3732A1B28D for ; Thu, 21 Dec 2017 15:26:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=twyAP1kMhComRn94pQkIllOZ9sgAwfoLLmuN6LUvn/I=; b=EaSwcqkl3qAeNx1Isuftt1IZTYuIJdbLCYV6/OBlLUVMn7k6J1YeGUHTIxrXzXIad6chaXuWtreKG5ls/AQnIP3gAEUtjdjoQ7h77YBf9quzNgudZ1C1wLfVIdOBctNt2bcsd/51VbSiiaBApBDE47lBWSYBuVT3oyFOi13RqMw= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3150.eurprd05.prod.outlook.com (10.170.237.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Thu, 21 Dec 2017 14:26:52 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::355f:857b:fdfd:afd9]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::355f:857b:fdfd:afd9%13]) with mapi id 15.20.0323.018; Thu, 21 Dec 2017 14:26:52 +0000 From: Shahaf Shuler To: Jerin Jacob , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Nicolau, Radu" , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API Thread-Index: AQHTc2xfFKcCfr6+OE+dZzgKGG66zaNA3lNggAAKRICAAEdIAIAAWd0AgAxdLXA= Date: Thu, 21 Dec 2017 14:26:52 +0000 Message-ID: References: <20171123121419.144132-1-shahafs@mellanox.com> <2601191342CEEE43887BDE71AB9772585FAC8AEB@irsmsx105.ger.corp.intel.com> <20171213075518.GA18228@jerin> <2601191342CEEE43887BDE71AB9772585FAC9140@irsmsx105.ger.corp.intel.com> <20171213173203.GA3462@jerin> In-Reply-To: <20171213173203.GA3462@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3150; 6:AJnvAXixcE8WrzMTVo/cElzapTiHX5hSj1e/pwerXNYnrJ45NFhEOHHTlOF5GmaBXahBkvUfnogFdfk52oOU9yuVlcXA9lqixO3dk9MED5/2sMRAThN4wVviq7s0oSvS2j88tuYpLIIfl+cuD3Af/a+xe0RR6zCU8YjKiTiA5HRV+ZTO0ap7Gg80k0yu0sB5MqpK7KWxpqEV+KR8xXqGy/rsQ7fn4fLDgsv/LMtrTc3UzMlOK95JqH512YBfde9toR3ajIflJ5XKcvnIGmPylITNdlc9e4HH4OoctR/Bx0o2OPUXDWGnVhLVSmHdKpoIIus9GbpK7er+q/BTHsPA4gf7s3bf1bAiTKvZRWEa00I=; 5:acCEPORahUgwA8XvkrMC1ImTGkZYIjWnOJHzl9Boyhmts/nv1yfts8XA3iTybfqPDDOJDeMnU0ZOmS/UAclCs7xh516d1KlFmIUiIM41gM6WwbcDJpn6tIMU0z6EzoBMC8BIFIkNA/Ag5ZgMqATebS6Nt5bcoSxyNAkcefS87To=; 24:evgs49+VCRQs3kklzBEuHnU2EHZPxSnpEKwy+xt6Sv8kTI+Me5rIF/GechexYX4inIeGDWeFKLJc9F5y/SgAngxaEs+0CfjWZWVLAl06xtc=; 7:d6eItQOUJJ024gQsMBV/8xR7chSHePVtUoJbF8ygV7dTLhE49w4ZjpuTaIsvdHmy+huKb74NIihqTbxX5JQHZEOcnUZr7YrZya3NaMRSS9LRm1mXv/k3T9cWlgYnCGXRNkKsZLVTQe39CoTPjRtm32dEToBT9zuoKAHrSxA0aA7IW9os4B3mueLLvwJC1W6K3Fy9WXViP7udswbIRgUOgEokVmzSUDZ2feK918he4rcbqzMK+hHxE73Y+NY3riHN x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 21759697-5763-4bb1-e383-08d5487ee182 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008031)(2017052603307)(7153060); SRVR:VI1PR05MB3150; x-ms-traffictypediagnostic: VI1PR05MB3150: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041268)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR05MB3150; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3150; x-forefront-prvs: 0528942FD8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(346002)(366004)(376002)(39860400002)(199004)(189003)(81156014)(14454004)(76176011)(74316002)(59450400001)(5660300001)(6506007)(6116002)(3846002)(102836004)(66066001)(2950100002)(55016002)(99286004)(7696005)(2900100001)(229853002)(93886005)(9686003)(478600001)(2906002)(97736004)(6436002)(5250100002)(86362001)(3280700002)(3660700001)(33656002)(81166006)(106356001)(8936002)(105586002)(25786009)(4326008)(54906003)(316002)(305945005)(53936002)(6246003)(110136005)(8676002)(68736007)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3150; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21759697-5763-4bb1-e383-08d5487ee182 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2017 14:26:52.8386 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3150 Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 14:26:54 -0000 Wednesday, December 13, 2017 7:32 PM, Jerin Jacob: >=20 > OK. I just suggested because adding the flag in PMD is harmless and we ca= n > avoid an extra check(setting the DEV_TX_OFFLOAD_MBUF_FAST_FREE only > when PMD supports it) in application to hide warning as you pointed out. > No strong opinion on the specifics, I am just cared only reaching the fla= g to > driver. Following some other comments from different examples I believe the way to = go is the following:=20 1. application will set the offloads it *must have* in order to properly fu= nction. PMD will fail the configuration if not supported. Such kind of offl= oads are basically all the offloads besides=20 DEV_TX_OFFLOAD_MBUF_FAST_FREE as it is an optimization.=20 2. application will set optional features only if supported (such as DEV_TX= _OFFLOAD_MBUF_FAST_FREE) 3. I will remove the redundant print for offloads set but not supported. Th= is can be done in the PMD level based on its implemented (as I understood s= ome PMDs don't set some offloads but do expect to have them enabled. This t= hough should be fixed IMO).=20 >=20 >=20