From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0048.outbound.protection.outlook.com [104.47.1.48]) by dpdk.org (Postfix) with ESMTP id A347E7CBA for ; Sun, 27 Aug 2017 08:05:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4XWgC0OoHLE8DLbHmDJPCDq8X0DAtD71gHy8cvC+tv0=; b=wdy60Rjlgpw4l+T+p/e/XsFoY/1YEcVSiwNJmBKKxnj3hFSI754Cl2hbxi3PQxNhaAdfyUHezWgerFM6IrV7pqWicr8cpvLIduyKYgjvvYX6BwvUItFDuGaCg/Pb3jgLTaYDr21eRgNsvhJYipFuGcR4xqggVBCNcZBednILZls= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3167.eurprd05.prod.outlook.com (10.170.237.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Sun, 27 Aug 2017 06:05:25 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::8450:1a86:2dd0:82c2]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::8450:1a86:2dd0:82c2%13]) with mapi id 15.01.1385.013; Sun, 27 Aug 2017 06:05:25 +0000 From: Shahaf Shuler To: Jerin Jacob CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH 0/4] ethdev new offloads API Thread-Index: AQHTD2uaGNU7ibdyEkuA1RENoHWbR6KU+9GAgALVRkA= Date: Sun, 27 Aug 2017 06:05:25 +0000 Message-ID: References: <20170825103136.GD9774@jerin> In-Reply-To: <20170825103136.GD9774@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3167; 6:k8iE8PxhgXglKt0WYvehYIUtg/YD3btw5DxE84C7Ae6+wn57uksvV9h+pk2X/iAQaNq/pSYmfxZODj+E0CTshsz9Qg1n7GSVDqmZMXa8bDuoStkRCyJs3qogCJ40350ET9zoS/zXc/kM+30YHSG1sW95JeiNM6+PUWfpeDjvBYMffeKDD82yjZNj7yT/wb1ZtG6Ot1UWQKeWhBjwWkf6y961iGKZHfertIIyHW3mu1kpnqsBZdCzxd0KI6+X1ZU+OlgCyloCs7CUzRAjPG3xoK1fE0WKDMGjghF0jsL6W8DAIoBfjjyacP6TbkvAX5uc80QgJ+GxvOujcdD15dRHaQ==; 5:idYoD0Uw89q88i07J140aoba/R8g1Y/2QwS+J+aXEcjpAd88o/RAR0oF7ASRF7feVJlblzh6AA3HjGKvpvN6JUJrnTMoSGfdw8iAseMh3UanFrJNTNExhQrUnKFTYo/EwcZ5L8ejg9mkt/zrkBmxew==; 24:LwnmyDlYifjYiRnYBxrmr9iUz2Ck1AojnMx3ly4mc8nhiqIiJTyZ4PWs1TJkCCkhgnwQ7QSVFvN3G9IkUqqc8jKRpUcvdYk03NzD9NncKUY=; 7:xP68Mql9Kb05SAfo5/xkJSVRwLZj+MbhmnkeGa1+h1FPiwjs80e2owUTtiD99/AJF7yeXuIo6lSyka44IJkuRuSSDIiLQlL/nRuqv0KtZCx6tpev+3CNUh0sL6a02ecFsdWaMiGoHTsNlj4Yik1CulcYZF8EWLoHn10vAjGl1VdN/uHTYnMm+1iRVECnai4wYuKfN/j58PyL2Qx2wm2UKvI+TE+gZgOp9BZI2IZbvQk= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 3fe7f627-975a-4089-c468-08d4ed119c09 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB3167; x-ms-traffictypediagnostic: VI1PR05MB3167: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3167; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3167; x-forefront-prvs: 0412A98A59 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(377454003)(199003)(189002)(189998001)(2900100001)(6436002)(25786009)(5250100002)(66066001)(9686003)(101416001)(76176999)(54356999)(50986999)(478600001)(3660700001)(3280700002)(106356001)(105586002)(2906002)(6506006)(6246003)(14454004)(8936002)(2950100002)(229853002)(8676002)(7736002)(53936002)(6916009)(110136004)(68736007)(33656002)(55016002)(305945005)(97736004)(102836003)(81166006)(74316002)(3846002)(6116002)(81156014)(86362001)(7696004)(4326008)(5660300001)(99286003)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3167; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2017 06:05:25.3257 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3167 Subject: Re: [dpdk-dev] [RFC PATCH 0/4] ethdev new offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Aug 2017 06:05:26 -0000 Friday, August 25, 2017 1:32 PM, Jerin Jacob: > > > > The new API does not have an equivalent for the below Tx flags: > > > > * ETH_TXQ_FLAGS_NOREFCOUNT > > * ETH_TXQ_FLAGS_NOMULTMEMP >=20 > IMO, it make sense to keep those flags as PMD optimization if an applicat= ion > does not need reference count and multi mempool in the application. > As example, An non trivial application like l3fwd does not need both of t= hem. The l3fwd application is yet another simple example from DPDK tree. Am not = sure that a complete vRouter/vSwitch implementation is with the same charac= teristics. Moreover, I think the fact there is an application which is able to use it = is not enough. IMO there needs to be some basic functionality always provi= ded by the PMDs and not controlled by flags. For example, let's say we have an application which always sends the mbufs = with the same ol_flags, or even with the same length. Will it make sense to add more flags to control it? Will it makes sense to run RFC2544 benchmark with testpmd io forwarding wit= h those flags?=20 If the answer is yes, maybe those flags (and others to follow) belong on di= fferent location on ethdev. However for sure they are not offloads.