From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0040.outbound.protection.outlook.com [104.47.2.40]) by dpdk.org (Postfix) with ESMTP id 7CD411B53 for ; Tue, 12 Sep 2017 08:35:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8nRje8UXZQYADSS3h86yxu8H/hV+p8Gi5xh4ONqIsHg=; b=yfj++gxRbt0CwvEJBSgf6vxrk1/8Z/MQ/7ZbIdprZWZb9aVxjHxEWlaYtTC32WR/tErDbBIH56krECn5z9HWzBaK2VtGNfnyj11a5nJTjC7+DOBHGueRttdbENyjoxpms5hZrpRSyO5uv2iPV1/9ts205AfXabxA3fsp40n6ExM= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1311.eurprd05.prod.outlook.com (10.162.122.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Tue, 12 Sep 2017 06:35:16 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0056.010; Tue, 12 Sep 2017 06:35:16 +0000 From: Shahaf Shuler To: Jerin Jacob CC: "Ananyev, Konstantin" , Stephen Hemminger , Thomas Monjalon , "dev@dpdk.org" , "Zhang, Helin" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API Thread-Index: AQHTK3vU0az8vg6wSEi8rTEyl6rvcKKwtC+ggAALQICAAAW8gA== Date: Tue, 12 Sep 2017 06:35:16 +0000 Message-ID: References: <20170910104827.11da9230@xeon-e3> <20170911062119.GA9342@jerin> <20170911080621.GA15867@jerin> <20170911090543.GA9965@jerin> <2601191342CEEE43887BDE71AB9772584F2497DC@irsmsx105.ger.corp.intel.com> <20170912040107.GA8081@jerin> <20170912055137.GA24921@jerin> In-Reply-To: <20170912055137.GA24921@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1311; 6:ALPtVJCwAsMAf6IU1zgfVOfDiZbDXVVWUEEmPx1GXnmf+rZ1KHG281qFGqZSDUqUHaOcjeDjYkQnEYOqbJ2t4feK3a+JqAhiWzuFEhi/ZgRUOuWWc7oA5a1Gz3MPzDScw+oP1F/Yw/Zx6FoTtWGteCql8Hi20IM8BHL8Yy1UHCcDL1rXE1E1foGtsjAYaAAdxhFSL/FQMw5V9ec6vznbWrar4lkadbp/xaoqXQjE/PTE0LZhMPKoAkcQuo3eZtGB3LGg+TnoiyzpGZV1thr63gZEiu/moS4eMvPpUmzMX1eXzQo3Kp+oWnzI8wXSOdvzVFM/GrBuuPTVdJqYj2jBZQ==; 5:Rur2o9pFiY4UMeLVstoW4MzoL0EyOC6UUYyxpnIvwdMD/1Oz72ekpKnVNyO1tdFcD4zesMzgR5M4v6218MgG3JokGKRixNrp/H9T+QOowsX0WKnDSp0pPqByiVPhV47V0JLueCef15h/MCDwmF7vaQ==; 24:QQgz7bm0qVl3qp2WoOAW2Wz0eKi5rMAiCPLyBKnYezOBNp6dHJAbVodzEDYMMp0TpfuhpxWNfuWqyst+yP1ays19tvET0urh5C1MMCxaQ6s=; 7:q9gJUCTGDxf+JPsm4pzTjyEFabhsVCVU8PKG31j+rxHpTpci6KUGEn9Ncq7+/rBFBfQTKh5+SH7hGDtcodLdwIum9ZqCpRemKUagYDsweZYIY3xlFCDaArHv1vF6aQl+TTGUc9PGhiVX/moai46vsmc5kagva+ML4fBzb3bLapTLh8SsDdj+utGN/uBVURoQTWTR/giiH4P/aDakU2exYEfnPG1U4SjxuTkhjqCqqTA= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: f0eabb0b-6cb6-4140-68d9-08d4f9a86e6c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB1311; x-ms-traffictypediagnostic: VI1PR05MB1311: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1311; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1311; x-forefront-prvs: 042857DBB5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(199003)(377454003)(189002)(33656002)(7736002)(7696004)(14454004)(5660300001)(2950100002)(189998001)(68736007)(3660700001)(102836003)(55016002)(5250100002)(6116002)(3846002)(99286003)(66066001)(316002)(8936002)(25786009)(305945005)(54906002)(3280700002)(2900100001)(86362001)(74316002)(6436002)(9686003)(2906002)(105586002)(478600001)(4326008)(106356001)(110136004)(6916009)(97736004)(229853002)(101416001)(93886005)(81166006)(6246003)(6506006)(8676002)(81156014)(50986999)(54356999)(76176999)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1311; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2017 06:35:16.7096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1311 Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 06:35:19 -0000 Tuesday, September 12, 2017 8:52 AM, Jerin Jacob: > > I understand the use case, and the fact those flags improve the > performance on low-end ARM CPUs. > > IMO those flags cannot be on queue/port level. They must be global. >=20 > Where should we have it as global(in terms of API)? > And why it can not be at port level? Because I don't think there is a use-case that application would want to ha= ve recounting on one port and not on the other. It is either application cl= one/not clone mbufs.=20 Same about the multi mempool. It is either application have it or not.=20 If there is a strong use-case for application to say on port X it clones mb= ufs and and port Y it don't then maybe this is enough to have it per-port. We can go even further - why not to have guarantee per queue? it is possibl= e if application is willing to manage.=20 Again those are not offloads, therefore if we expose those this should on d= ifferent location the offloads field on eth conf.=20 >=20 > > > > Even though the use-case is generic the nicvf PMD is the only one which= do > such optimization. > > So am suggesting again - why not expose it as a PMD specific parameter? >=20 > Why to make it as PMD specific? if application can express it though > normative DPDK APIs. >=20 > > > > - The application can express it wants such optimization. > > - It is global > > > > Currently it does not seems there is high demand for such flags from ot= her > PMDs. If such demand will raise, we can discuss again on how to expose it > properly. >=20 > It is not PMD specific. It is all about where it runs? it will applicable= for any > PMD that runs low end hardwares where it need SW based Tx buffer > recycling(The NPU is different story as it has HW assisted mempool > manager). Maybe, but I don't see other PMD which use those flags. Do you aware to any= plans to add such optimizations? You are pushing for generic API which is currently used only by a single en= tity.=20 > What we are loosing by running DPDK effectively on low end hardware with > such "on demand" runtime configuration though DPDK normative API. Complexity of APIs for applications. More structs on ethdev, more API defin= itions, more field to be configured by application, all valid for a single = PMD.=20 For the rest of the PMDs, those fields are currently don't-care.=20 >=20 >=20 > > > > > > > > > >