* [dpdk-dev] [PATCH v2] net/mlx4: fix no bcast rcv in promisc and allmulti
@ 2018-01-28 9:43 Moti Haimovsky
2018-01-28 10:13 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Moti Haimovsky @ 2018-01-28 9:43 UTC (permalink / raw)
To: adrienm, shahafs; +Cc: dev, Moti Haimovsky, stable
This patch fixes the issue of mlx4 not receiving broadcast packets
when configured to work promiscuous or allmulticast modes.
Fixes: eacaac7bae36 ("net/mlx4: restore promisc and allmulti support")
Cc: stable@dpdk.org
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
drivers/net/mlx4/mlx4_flow.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index fb84060..2c67105 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -1223,9 +1223,12 @@ struct mlx4_drop {
*
* Various flow rules are created depending on the mode the device is in:
*
- * 1. Promiscuous: port MAC + catch-all (VLAN filtering is ignored).
- * 2. All multicast: port MAC/VLAN + catch-all multicast.
- * 3. Otherwise: port MAC/VLAN + broadcast MAC/VLAN.
+ * 1. Promiscuous:
+ * port MAC + broadcast + catch-all (VLAN filtering is ignored).
+ * 2. All multicast:
+ * port MAC/VLAN + broadcast + catch-all multicast.
+ * 3. Otherwise:
+ * port MAC/VLAN + broadcast MAC/VLAN.
*
* About MAC flow rules:
*
@@ -1305,9 +1308,6 @@ struct mlx4_drop {
!priv->dev->data->promiscuous ?
&vlan_spec.tci :
NULL;
- int broadcast =
- !priv->dev->data->promiscuous &&
- !priv->dev->data->all_multicast;
uint16_t vlan = 0;
struct rte_flow *flow;
unsigned int i;
@@ -1341,7 +1341,7 @@ struct mlx4_drop {
rule_vlan = NULL;
}
}
- for (i = 0; i != RTE_DIM(priv->mac) + broadcast; ++i) {
+ for (i = 0; i != RTE_DIM(priv->mac) + 1; ++i) {
const struct ether_addr *mac;
/* Broadcasts are handled by an extra iteration. */
@@ -1405,7 +1405,7 @@ struct mlx4_drop {
goto next_vlan;
}
/* Take care of promiscuous and all multicast flow rules. */
- if (!broadcast) {
+ if (priv->dev->data->promiscuous || priv->dev->data->all_multicast) {
for (flow = LIST_FIRST(&priv->flows);
flow && flow->internal;
flow = LIST_NEXT(flow, next)) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/mlx4: fix no bcast rcv in promisc and allmulti
2018-01-28 9:43 [dpdk-dev] [PATCH v2] net/mlx4: fix no bcast rcv in promisc and allmulti Moti Haimovsky
@ 2018-01-28 10:13 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-01-28 10:13 UTC (permalink / raw)
To: Mordechay Haimovsky, Adrien Mazarguil; +Cc: dev, stable
Sunday, January 28, 2018 11:44 AM, Mordechay Haimovsky:
> This patch fixes the issue of mlx4 not receiving broadcast packets when
> configured to work promiscuous or allmulticast modes.
>
> Fixes: eacaac7bae36 ("net/mlx4: restore promisc and allmulti support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
> drivers/net/mlx4/mlx4_flow.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
As the v1 was already been Acked by Adrien, applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-28 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-28 9:43 [dpdk-dev] [PATCH v2] net/mlx4: fix no bcast rcv in promisc and allmulti Moti Haimovsky
2018-01-28 10:13 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).