From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10077.outbound.protection.outlook.com [40.107.1.77]) by dpdk.org (Postfix) with ESMTP id A327925E5 for ; Tue, 12 Sep 2017 07:25:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PSCqA5OuHIOVlp1N1wsVSoA/Bz4FqWjRQSATb17/1ro=; b=kCKpSX7yqO0wARCUPboA7jA0S5id7PhSRTjcPorbgZnd4//rDzqJmYEbjFMRZP5cBxsrR6JSNxWKzWDkIw9Bb4QEUn6VsXj5yX3IOj0Zr2keBIECfeBCjV8yFsafJ1fKS2JlALVs0V8rJGI9kRXXidLv8yVt2pCJy1CYcj2Azqc= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1486.eurprd05.prod.outlook.com (10.164.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Tue, 12 Sep 2017 05:25:42 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0056.010; Tue, 12 Sep 2017 05:25:42 +0000 From: Shahaf Shuler To: Jerin Jacob , "Ananyev, Konstantin" CC: Stephen Hemminger , Thomas Monjalon , "dev@dpdk.org" , "Zhang, Helin" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API Thread-Index: AQHTK3vU0az8vg6wSEi8rTEyl6rvcKKwtC+g Date: Tue, 12 Sep 2017 05:25:42 +0000 Message-ID: References: <20170910104827.11da9230@xeon-e3> <20170911062119.GA9342@jerin> <20170911080621.GA15867@jerin> <20170911090543.GA9965@jerin> <2601191342CEEE43887BDE71AB9772584F2497DC@irsmsx105.ger.corp.intel.com> <20170912040107.GA8081@jerin> In-Reply-To: <20170912040107.GA8081@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1486; 6:pxvoVtDivMDkHcb4AfXr4oKAfTUbOmU+I3H9Mn7OWh4nrhfadKTgnV72g2nCDQL/E4hDKINADzKO/46GtqQR3mNb48VBlXmCdNYtINQxjLwS5AQxQ3US+w/Yy0vZ/XmX2yPlTpk2McixbcEKuojrHM1uVNMmInAnMLICX9n1jAYBIjTDHvkEV43orn1tVNqOXNZDz2CT850J2ip+L58lINeRxw/M0V36UaFXQNj/VTPj0iDdjpTR83DCcuS0FNnGNBkstX1ei/hWASt4E9q82Pc0tg6JspmdkT5TMVahE18pwuEvtICcspx/0oD/hD7LdlJsQMR0YjqOkdemoYvVUQ==; 5:E7T01z0mt0BOHdE8TV3H+GaGvp6+Qef8IChVt1xMh51azNb4hE0mZH5oRXOL0RL0Sn7y7nLddHC4U9r6lLl120JhMe7+hYYEpM3WpGwh69h9DFSqL2+LIanh6blgeSYfPECQB9+pqWjrud0Nk6E6aw==; 24:s+6iMtHhznexZYggloU66X+AFFdH3iNZpVJ0Zj3+Rb8qaWg+ZZnwZ1zwLq3hrkwmQkpUw0tDapulMupSiViOPleFIx/1vytCMs/TNwB1Ids=; 7:DW/FkYmwXzbjQcju3N9/YX4D9TViSLaewshdLCMExXFjCGbBVmuJoO6pHuRCbt++YEFRH4Z8fTSZNWVyYGUjlLzHFee9lSlqzJFa1Y+E1C4lbxQKqJVzNfc94w1/xMVklSJkj+vQ42NGFx0wVeImg/DlhCTghf7fQVzbbbXiIu089iK1wYu8m81rQHt1lyID3tCpf8gwOGkyy871wPkFIxPhmH5UthEfpPEC726pFp0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 79303cde-2d5b-484c-4736-08d4f99eb645 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB1486; x-ms-traffictypediagnostic: VI1PR05MB1486: x-exchange-antispam-report-test: UriScan:(158342451672863); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1486; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1486; x-forefront-prvs: 042857DBB5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(199003)(377454003)(189002)(478600001)(68736007)(8676002)(101416001)(99286003)(33656002)(8936002)(5660300001)(4326008)(53936002)(97736004)(81156014)(81166006)(54906002)(55016002)(5250100002)(9686003)(2906002)(3280700002)(6246003)(3660700001)(86362001)(7696004)(229853002)(305945005)(74316002)(7736002)(14454004)(2900100001)(2950100002)(3846002)(189998001)(6116002)(102836003)(50986999)(76176999)(25786009)(6506006)(66066001)(54356999)(6436002)(316002)(105586002)(106356001)(93886005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1486; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2017 05:25:42.3443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1486 Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 05:25:45 -0000 Tuesday, September 12, 2017 7:01 AM, Jerin Jacob: > Yes, only when ETH_TXQ_FLAGS_NOMULTMEMP and > ETH_TXQ_FLAGS_NOREFCOUNT selected at tx queue configuration. >=20 > > > > So literally, yes it is not a TX HW offload, though I understand your > > intention to have such possibility - it might help to save some cycles. >=20 > It not a few cycles. We could see ~24% drop on per core(with 64B) with > testpmd and l3fwd on some SoCs. It is not very specific to nicvf HW, The > problem is with limited cache hierarchy in very low end arm64 machines. > For TX buffer recycling case, it need to touch the mbuf again to find out= the > associated mempool to free. It is fine if application demands it but not = all the > application demands it. >=20 > We have two category of arm64 machines, The high end machine where > cache hierarchy similar x86 server machine. The low end ones with very > limited cache resources. Unfortunately, we need to have the same binary o= n > both machines. >=20 >=20 > > Wonder would some new driver specific function would help in that case? > > nicvf_txq_pool_setup(portid, queueid, struct rte_mempool *txpool, > > uint32_t flags); or so? >=20 > It is possible, but how do we make such change in testpmd, l3fwd or ipsec= - > gw in tree application which does need only NOMULTIMEMP & > NOREFCOUNT. >=20 > If there is concern about making it Tx queue level it is fine. We can mov= e > from queue level to port level or global level. > IMO, Application should express in some form that it wants only > NOMULTIMEMP & NOREFCOUNT and thats is the case for l3fwd and ipsec- > gw >=20 I understand the use case, and the fact those flags improve the performance= on low-end ARM CPUs. IMO those flags cannot be on queue/port level. They must be global. Even though the use-case is generic the nicvf PMD is the only one which do = such optimization. So am suggesting again - why not expose it as a PMD specific parameter? - The application can express it wants such optimization.=20 - It is global Currently it does not seems there is high demand for such flags from other = PMDs. If such demand will raise, we can discuss again on how to expose it p= roperly.