* [dpdk-dev] [PATCH] net/mlx5: fix all multi verification code position
@ 2018-01-11 9:25 Nelio Laranjeiro
2018-01-17 23:02 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2018-01-11 9:25 UTC (permalink / raw)
To: dev, Yongseok Koh, Adrien Mazarguil; +Cc: rasland
All multi code should not be handled in exit part of the code but in the
mainline of the function.
Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules")
Cc: rasland@mellanox.com
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_flow.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 334a4f4ba..f050ea713 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1156,16 +1156,6 @@ priv_flow_convert(struct priv *priv,
attr->priority +
hash_rxq_init[parser->layer].flow_priority;
}
-exit_free:
- /* Only verification is expected, all resources should be released. */
- if (!parser->create) {
- for (i = 0; i != hash_rxq_init_n; ++i) {
- if (parser->queue[i].ibv_attr) {
- rte_free(parser->queue[i].ibv_attr);
- parser->queue[i].ibv_attr = NULL;
- }
- }
- }
if (parser->allmulti &&
parser->layer == HASH_RXQ_ETH) {
for (i = 0; i != hash_rxq_init_n; ++i) {
@@ -1177,6 +1167,16 @@ priv_flow_convert(struct priv *priv,
IBV_FLOW_ATTR_MC_DEFAULT;
}
}
+exit_free:
+ /* Only verification is expected, all resources should be released. */
+ if (!parser->create) {
+ for (i = 0; i != hash_rxq_init_n; ++i) {
+ if (parser->queue[i].ibv_attr) {
+ rte_free(parser->queue[i].ibv_attr);
+ parser->queue[i].ibv_attr = NULL;
+ }
+ }
+ }
return ret;
exit_enomem:
for (i = 0; i != hash_rxq_init_n; ++i) {
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix all multi verification code position
2018-01-11 9:25 [dpdk-dev] [PATCH] net/mlx5: fix all multi verification code position Nelio Laranjeiro
@ 2018-01-17 23:02 ` Yongseok Koh
2018-01-22 11:40 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-01-17 23:02 UTC (permalink / raw)
To: Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil, Raslan Darawsheh
> On Jan 11, 2018, at 1:25 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
>
> All multi code should not be handled in exit part of the code but in the
> mainline of the function.
>
> Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules")
> Cc: rasland@mellanox.com
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix all multi verification code position
2018-01-17 23:02 ` Yongseok Koh
@ 2018-01-22 11:40 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-01-22 11:40 UTC (permalink / raw)
To: Yongseok Koh, Nélio Laranjeiro
Cc: dev, Adrien Mazarguil, Raslan Darawsheh
Thursday, January 18, 2018 1:03 AM, Yongseok Koh:
> > On Jan 11, 2018, at 1:25 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> wrote:
> >
> > All multi code should not be handled in exit part of the code but in
> > the mainline of the function.
> >
> > Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules")
> > Cc: rasland@mellanox.com
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-22 11:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11 9:25 [dpdk-dev] [PATCH] net/mlx5: fix all multi verification code position Nelio Laranjeiro
2018-01-17 23:02 ` Yongseok Koh
2018-01-22 11:40 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).