From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20087.outbound.protection.outlook.com [40.107.2.87]) by dpdk.org (Postfix) with ESMTP id 465B81B1D0 for ; Thu, 25 Jan 2018 17:20:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NObruFmFUVZCV32h/XmUrVOTq+OyWXkRiGGOgVNlLyw=; b=Bbpgcu8i5DcVPi3ouwPtty852iGwIPixJYldQih81krPZI8RWXyzNkfxXyAh236nPVHQW2H/39u1T/f8pmt4HvB2LxFWgfqXCUSvDW7xplHcrM3avITilJ5Ft/ziYav/XDOtGZWosmVuZNKq1jjUrkGXfbnSy5Pv1dGN2mgCFGY= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1280.eurprd05.prod.outlook.com (10.162.122.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 16:20:10 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0428.019; Thu, 25 Jan 2018 16:20:10 +0000 From: Shahaf Shuler To: Shahaf Shuler , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Adrien Mazarguil , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: fix link state on device start Thread-Index: AQHTlfY+TQmUGu8oxka3PaanodZ3AqOEwbPw Date: Thu, 25 Jan 2018 16:20:09 +0000 Message-ID: References: <20180123170106.9047-1-shahafs@mellanox.com> <20180125160428.146069-1-shahafs@mellanox.com> In-Reply-To: <20180125160428.146069-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1280; 6:FLKtqsbKLuAEWNhVCC+WZCaQp3mAcXmyLezFlV5ynjY3PmBcNCIZ4go2cvMBOUDXT8JxsBBUVp7hONmFC5L4osdbLmFWWJkD0Pjf8urq5mEb5QVwsI2nyDvZmxpWvmoE+RIrtRqchetf49BmFA0z7F9W1cJi+bvxAKWQOFzWpKSh5GHMwpysfqJLpNqXQ0DmgX6e7lN7ehAgmAXyPgtB8rjCxzxXccDxdceteQXAmmlzmWlCw5PbFdRPTej6E9xWo9LqvHdI2rhDawxqiYQ7KhoETjpcaoBJ0/OC10vh6WSosuMCUiQtYiAU1IrdFD8IAkxKBdHjbP4pN9qhUOBOi9uC2F2CRBqyRahbuxni+5Yud9/NVShPWR7yMTCX6VPx; 5:iKwJ9WolyQJujQXlmP5TUns8+xyMxeWQGPHHA7dShEYO13ofRQ86hRuescfQggGcbyPMQkP81RfoTX1bdtO94rIb7de4fxpt4ZXav+BAm0cMiAhxOOted0Kb6uq2BSgRDlYhZF4dkTk2O6PXP4+uVDZfL34JFFanPujTlUo9GnU=; 24:vqA8CWxU359ADcnUpH02V5q+hn5A6T5I+y2t9pyZk21GL0h915EtO5WIuz1DDhBitsYp/cNrwxDki/+oFUs6J1cT2yq+/pjRnJqOdMDkbtY=; 7:DY2Iw362r+me2H8ImyTm1ODO+xLs4ojD6HjvPfxB4eUOnqC1jGUP2lIL7I+ayH3sK7UJ6XjgTUJBvoXl63wwe4YjFdtpoGhDNufZbglSNAIJFOOszsb6VQIQ8whRcrc/J/+76XehIeHAc3WEcFHEKgqZf8TByovleAaJGMBHX9bMGyKSVfSE7jaRdDuEQh2c+q++rm0QgpBZDhhJwKtCIGISxwBK8ez7grQnXGFiZbljoSLaHKu90CskqgkWavp3 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 600e0041-bbc3-4cb4-efdf-08d5640f815c x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1280; x-ms-traffictypediagnostic: VI1PR05MB1280: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231023)(2400081)(944501161)(3002001)(10201501046)(6055026)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR05MB1280; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1280; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(366004)(396003)(39380400002)(199004)(189003)(59450400001)(55016002)(97736004)(9686003)(8936002)(3280700002)(5660300001)(2950100002)(6436002)(7736002)(305945005)(2900100001)(66066001)(6506007)(26005)(229853002)(76176011)(86362001)(53936002)(7696005)(6636002)(6246003)(102836004)(5250100002)(2906002)(478600001)(99286004)(4326008)(105586002)(74316002)(81166006)(106356001)(3660700001)(25786009)(81156014)(8676002)(3846002)(33656002)(14454004)(6116002)(110136005)(316002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1280; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eAa3bLmjjEI8dvInknzvOw9uClnjFccSifYKRhtHIJGcWocqYClVX5JCsJIfK750ttaLWsIa13noddvwavmzzw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 600e0041-bbc3-4cb4-efdf-08d5640f815c X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 16:20:09.8869 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1280 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state on device start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 16:20:12 -0000 Thursday, January 25, 2018 6:04 PM, Shahaf Shuler: > Following commit c7bf62255edf ("net/mlx5: fix handling link status event"= ) > the link state must be up in order for the burst function to be set on th= e > device ops. >=20 > As the link may take time to move between down and up state it is possibl= e > the rte_eth_dev_start call will return with wrong burst function (either = null > or the empty burst function). >=20 > Fixing it by forcing the link to be up before returning from device start= . In > case the link is still not up after 5 seconds fail the function. > In addition initialize the burst function on device probe to prevent cras= hes > before the link is up. >=20 > Fixes: c7bf62255edf ("net/mlx5: fix handling link status event") > Cc: yskoh@mellanox.com >=20 > Signed-off-by: Shahaf Shuler > Acked-by: Nelio Laranjeiro > --- Applied to next-net-mlx, thanks