From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ABEAA0471 for ; Fri, 19 Jul 2019 06:29:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33C842BE5; Fri, 19 Jul 2019 06:29:54 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50084.outbound.protection.outlook.com [40.107.5.84]) by dpdk.org (Postfix) with ESMTP id DCB262082 for ; Fri, 19 Jul 2019 06:29:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OWl81pS9i//wvii+Gh9KzGUM333bc3lA6EX8p120g/NbczKk/h51NRIaplGZm7js4A6bl5navQz82LcTbnVl52/Nv3qIsEvLnP2aCgKPZ2VYCRSNSqtsrNu6DFeVi9k9e7MnopsGwEFIYnuhKl7FxssVMn4WLC3iJM4Zhmi4BrVpv+QQUhrShWfYoNiyrt1Vdz6CpPFLXIojsq2ogwzZrPrbwMbIJ3/E98IO8+eGB+DEh3PksIb9f4TMcS5uzg+stxJ8G5Tzl5qS6wHF9zJNNphQ1G567NgmXmzU9GkfgrDKaSflHvgJCeAxF8vHtMpcbTwvU4uZQpuBgTlllBBi7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vd+NkyP1q+QIG4vmHJQ9M3bMFOmooiF6fqLmgggNdGE=; b=EVOjc00NVX6+L3s77NjqF3hidyVH3ce5ccEuvPqOf76O3iW2jTXr1W1kCCjOsqOXZyMkRvPNgKjClxgylpvGFrfn66Fi/G2yPhzXNCNdnnLRgp/zCVKd1yHdeB7W1P8d3WDbfX5l1un10v3dRWyhuWgGSSzdqAmao3I4Dv++B/eD6p/GSYabHXYavpVRj7bME6VJI02upN81zRHCMKCQbZL2dLJumQ9loTr9cOnjAJ01XCqTuy5HMFm4gFR8tOLWJaQN7amFUuwv4iL8o9mbPrTx9ULw7JwOv5n0auNZTDVJebto2M9RuvE3RmXR9UMzKdBerS7OR0i/oz8maFvC1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vd+NkyP1q+QIG4vmHJQ9M3bMFOmooiF6fqLmgggNdGE=; b=BdAjpvy/KyMhCXqvpQcK9gqvN9XzAHKy4rQAX/z2JtcqpmvpcjE19m7wzAgAhBn+dsl2/zyrJp+ntUKTnYEpPFmi4mPYHKyk/szXroV9RH7F0TsZVOM7zGV5rpdQSDY0o4hwc0cquZ2G/G7wTIa+i3H/zbCioPqAbX6z1QPCw7c= Received: from VI1PR05MB3278.eurprd05.prod.outlook.com (10.170.238.23) by VI1PR05MB4799.eurprd05.prod.outlook.com (20.176.4.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Fri, 19 Jul 2019 04:29:52 +0000 Received: from VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::75a7:b54e:c238:5c21]) by VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::75a7:b54e:c238:5c21%5]) with mapi id 15.20.2094.011; Fri, 19 Jul 2019 04:29:51 +0000 From: Slava Ovsiienko To: Dekel Peled , Yongseok Koh , Shahaf Shuler CC: Jack Min , Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix setting of item flags bitmap Thread-Index: AQHVPaD67IuD/Hbofku46V/wmFk1MabRWekA Date: Fri, 19 Jul 2019 04:29:51 +0000 Message-ID: References: <17e97355b175364266eef4eb3ca959c4688f9a36.1563478206.git.dekelp@mellanox.com> In-Reply-To: <17e97355b175364266eef4eb3ca959c4688f9a36.1563478206.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54dc5c96-bf17-483f-f8a5-08d70c01be15 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR05MB4799; x-ms-traffictypediagnostic: VI1PR05MB4799: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 01039C93E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(39860400002)(366004)(376002)(136003)(13464003)(189003)(199004)(486006)(6436002)(229853002)(256004)(14444005)(33656002)(25786009)(53936002)(68736007)(55016002)(9686003)(3846002)(6116002)(6246003)(7696005)(14454004)(76176011)(102836004)(6506007)(53546011)(6636002)(4326008)(11346002)(476003)(26005)(446003)(86362001)(186003)(8936002)(66446008)(66476007)(66556008)(64756008)(52536014)(81156014)(81166006)(54906003)(110136005)(8676002)(99286004)(74316002)(5660300002)(316002)(7736002)(305945005)(66946007)(66066001)(2906002)(478600001)(71200400001)(76116006)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB4799; H:VI1PR05MB3278.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2y5X+GsYsTusB4NNrtmVe1qvHshX1mef+RL4etkurIc4OJGYRmYw0Rn1WBISpwkJdUnHxIoM3IaqessxWaLC15T5deKymKXPX6yvhO0FDfmOKuyfoURuws3LmwsFI8enIaXpC+PngI/nJQxfmsh9nkt/3Wfv8C7mNkCOSWFzTtmiblo5yriUo8IuAeLIK9wSJYYpcw/8qJY0kJ6r9RqsHJAN14On40PkmRtYklRpkcW/A2M51O9+x7I87Ok/tf+a4TXMHBmWUeTnUFNpj6teL2bzgq/DJIZfkijZvfPpX7B8DjBveTHG94lJpdlZdjhv48qeAtH4ESbIfkVg2wQ0ORJlP8T0tQjrYux+bYktHkbScAgkUodcuPM2Dh2mVL50sJiU3Ll6hv86/Aa9QwgeWP26pHxoWcs7rvWdodPsewg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54dc5c96-bf17-483f-f8a5-08d70c01be15 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2019 04:29:51.7357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4799 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix setting of item flags bitmap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Thursday, July 18, 2019 22:42 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Jack Min ; Ori Kam ; > dev@dpdk.org > Subject: [PATCH] net/mlx5: fix setting of item flags bitmap >=20 > In functions flow_dv_translate() and flow_dv_validate(), the flow items = are > scanned and each item is marked in item_flags bitmap. > The code handling some of the items was ported from another project, > where items are marked in a slightley different manner. >=20 > This patch fixes the setting of items in bitmap, adapting it to the requi= red > manner. >=20 > Fixes: d53aa89aea91 ("net/mlx5: support matching on ICMP/ICMP6") > Fixes: 1242041c5601 ("net/mlx5: match GRE key and present bits") > Fixes: 2e4c987aad91 ("net/mlx5: validate Direct Rule E-Switch") >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 45cd140..7240d3b 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -2883,7 +2883,7 @@ struct field_modify_info modify_tcp[] =3D { > (dev, items, attr, item_flags, error); > if (ret < 0) > return ret; > - last_item |=3D MLX5_FLOW_ITEM_PORT_ID; > + last_item =3D MLX5_FLOW_ITEM_PORT_ID; > break; > case RTE_FLOW_ITEM_TYPE_ETH: > ret =3D mlx5_flow_validate_item_eth(items, > item_flags, @@ -2979,7 +2979,7 @@ struct field_modify_info modify_tcp[] > =3D { > (items, item_flags, gre_item, error); > if (ret < 0) > return ret; > - item_flags |=3D MLX5_FLOW_LAYER_GRE_KEY; > + last_item =3D MLX5_FLOW_LAYER_GRE_KEY; > break; > case RTE_FLOW_ITEM_TYPE_VXLAN: > ret =3D mlx5_flow_validate_item_vxlan(items, > item_flags, @@ -3017,7 +3017,7 @@ struct field_modify_info modify_tcp[] > =3D { > error); > if (ret < 0) > return ret; > - item_flags |=3D MLX5_FLOW_LAYER_ICMP; > + last_item =3D MLX5_FLOW_LAYER_ICMP; > break; > case RTE_FLOW_ITEM_TYPE_ICMP6: > ret =3D mlx5_flow_validate_item_icmp6(items, > item_flags, @@ -3025,7 +3025,7 @@ struct field_modify_info modify_tcp[] > =3D { > error); > if (ret < 0) > return ret; > - item_flags |=3D MLX5_FLOW_LAYER_ICMP6; > + last_item =3D MLX5_FLOW_LAYER_ICMP6; > break; > default: > return rte_flow_error_set(error, ENOTSUP, @@ - > 5043,7 +5043,7 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ITEM_TYPE_GRE_KEY: > flow_dv_translate_item_gre_key(match_mask, > match_value, items); > - item_flags |=3D MLX5_FLOW_LAYER_GRE_KEY; > + last_item =3D MLX5_FLOW_LAYER_GRE_KEY; > break; > case RTE_FLOW_ITEM_TYPE_NVGRE: > flow_dv_translate_item_nvgre(match_mask, > match_value, @@ -5073,12 +5073,12 @@ struct field_modify_info > modify_tcp[] =3D { > case RTE_FLOW_ITEM_TYPE_ICMP: > flow_dv_translate_item_icmp(match_mask, > match_value, > items, tunnel); > - item_flags |=3D MLX5_FLOW_LAYER_ICMP; > + last_item =3D MLX5_FLOW_LAYER_ICMP; > break; > case RTE_FLOW_ITEM_TYPE_ICMP6: > flow_dv_translate_item_icmp6(match_mask, > match_value, > items, tunnel); > - item_flags |=3D MLX5_FLOW_LAYER_ICMP6; > + last_item =3D MLX5_FLOW_LAYER_ICMP6; > break; > default: > break; > -- > 1.8.3.1