DPDK patches and discussions
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Alexander Kozyrev <akozyrev@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Raslan Darawsheh <rasland@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly
Date: Fri, 12 Jun 2020 19:59:55 +0000
Message-ID: <VI1PR05MB3278EC494B3233C5574AAAC5D2810@VI1PR05MB3278.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1591897320-15192-1-git-send-email-akozyrev@mellanox.com>

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@mellanox.com>
> Sent: Thursday, June 11, 2020 20:42
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Slava
> Ovsiienko <viacheslavo@mellanox.com>
> Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly
> 
> The Legacy MPW (multi-packet write) should not be engaged implicitly.
> We should exclude this function form a Tx burst routine selection process
> unless it is requested specifically by setting the txq_mpw_en devarg.
> Exclude this function from the selection process the same way it is done for
> the Enhanced MPW in the mlx5_select_tx_function() routine.
> 
> Fixes: eb8121ab9dac ("net/mlx5: introduce Tx burst routine template")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 6a17a9a..df58af5 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -5542,6 +5542,9 @@ enum mlx5_txcmp_code {
>  			/* Does not meet requested offloads at all. */
>  			continue;
>  		}
> +		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_MPW)
> +			/* Do not enable legacy MPW if not configured. */
> +			continue;
>  		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_EMPW)
>  			/* Do not enable eMPW if not configured. */
>  			continue;
> --
> 1.8.3.1


  reply	other threads:[~2020-06-12 20:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 17:42 Alexander Kozyrev
2020-06-12 19:59 ` Slava Ovsiienko [this message]
2020-06-15  8:51 ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR05MB3278EC494B3233C5574AAAC5D2810@VI1PR05MB3278.eurprd05.prod.outlook.com \
    --to=viacheslavo@mellanox.com \
    --cc=akozyrev@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=rasland@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git