From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0089.outbound.protection.outlook.com [104.47.0.89]) by dpdk.org (Postfix) with ESMTP id 9EC8D1B13A for ; Wed, 24 Oct 2018 12:43:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FxkRGVy4yBnYkByFoMxbAKMZEq9aog3Md6EsF/z9gI=; b=Ku6hag7rgexLpwkeSZcCMTioscXkGIXad8dL7u7wQaUfvsjk4PDChrpRJB8U1f63EkBfoMyNWUQVcy66FbKVmwT/Kp6W9qg42bjXixrk+5G4j29+53GqA01ygZ3FjLZ2lDB8aZxHCFMin0Aiq6Z9RAqwZypUuuSuxObp9sLa5bk= Received: from VI1PR05MB3440.eurprd05.prod.outlook.com (10.170.239.18) by VI1PR05MB1920.eurprd05.prod.outlook.com (10.166.44.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.18; Wed, 24 Oct 2018 10:43:42 +0000 Received: from VI1PR05MB3440.eurprd05.prod.outlook.com ([fe80::fcd0:7d8f:ee3e:3a8d]) by VI1PR05MB3440.eurprd05.prod.outlook.com ([fe80::fcd0:7d8f:ee3e:3a8d%4]) with mapi id 15.20.1250.028; Wed, 24 Oct 2018 10:43:42 +0000 From: Ori Kam To: Dekel Peled , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "olivier.matz@6wind.com" , Adrien Mazarguil , Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" CC: Shahaf Shuler , "dev@dpdk.org" , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH v2 2/2] ethdev: fix metadata documentation Thread-Index: AQHUa2ISfx9TYpIuvEevS7f8y9J6I6UuNgDg Date: Wed, 24 Oct 2018 10:43:42 +0000 Message-ID: References: <1540301331-51065-1-git-send-email-dekelp@mellanox.com> <1540362120-14570-2-git-send-email-dekelp@mellanox.com> In-Reply-To: <1540362120-14570-2-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1920; 6:83kTKZ50eC1RDC3DwKAbfManJX+czREOdSAOSuVKX55cXcGPOoijDwWlmx/rjYIhIzBcEuHSFlptkzH7DKV2yYVSEIzU4gZPgzhtR/B0Po4YXj3I1PEjRPQBHrcYuTcLCOWKwaWux1/s3eZnJclRlTpIyw2qrE+ohbYrxGW4xYd4Hx3CTeeQTIWyB7TthORxorlX0+fhbqLe5rXXOBWQc3AfkleG2r09SMbWHAawrQPrECjoEmeCIaIxm/RsDI/XDiT2l3bhTVZj+gGRBVtur91Tg7ZSKacrkL1ofGwMXQqo/4oJtAYQTCU0LZ2lmLvIgdAwGyqXICQNzqV59uOhxKzHSqTMC70aI+9mCCEiJJFAAvq3DdL8S+NqRDrtBvgjqzKiBV0uM2onsIyJ6Twusod847OB3pljZnfRJFwKFP5I7yPk3i12BZ/On9ZdH0DQrWH2gyEMB8v0FXVnqyudLb9TAp+aYIZx+azWmpb/TQ0=; 5:M4QZ2UHhdptJymEBGpXN4Ld84hj1GE/o38Bej4Qw73lfoYOEaVAU13GauNAj/Ma5+kO+UhtsZxVJw5PaNJ0MjuEay4JuwlTeQrUc7dQmCJ+sbqMAbeeM8aYVr8+B98Sdt5PM7oRFEjN+SLy8ILjsxCHdYpH6gIA2/xtyVmcd3gM=; 7:o3yNtYqofdM06XiQlPLqjuUhbLBFVSAYOdTSaqcJK5v7cYtmPr4gAF9I1e/HCqYfpverKwoAIVvQr9resrervhPvVfFwAZwbg0rEYL0QJk/PvMqGL6JAeJqe6mg2ZexxuX/M5cEUwUSE1IAmM5WCig== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: e672065a-80f0-41f0-23a3-08d6399d90ea x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB1920; x-ms-traffictypediagnostic: VI1PR05MB1920: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:VI1PR05MB1920; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1920; x-forefront-prvs: 083526BF8A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(136003)(396003)(39860400002)(346002)(13464003)(189003)(199004)(8936002)(8676002)(2201001)(14444005)(256004)(5250100002)(2900100001)(14454004)(6436002)(81166006)(81156014)(68736007)(186003)(5660300001)(446003)(33656002)(4326008)(486006)(476003)(478600001)(11346002)(6246003)(66066001)(2501003)(25786009)(107886003)(9686003)(53936002)(55016002)(71190400001)(71200400001)(229853002)(105586002)(106356001)(6116002)(3846002)(2906002)(74316002)(305945005)(7736002)(575784001)(26005)(97736004)(53546011)(86362001)(6506007)(102836004)(76176011)(99286004)(7696005)(54906003)(316002)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1920; H:VI1PR05MB3440.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 1JLf8vTsXPvkyCsY3qUVVzVs43KvjWV8hWUguswovJZVwrXjHWyq4IDRQfU2v/RtTfgyiFHVmJfMwcgURmebn7VddT+osTU9aSv3Ncd0wCpMU6v//NXQQulVTox+6rb7bsQsPNMC6/VPxNxtauWe8XalWdA2rDSBXA0pzNvtxKzRF1PFHj0Kb5FZKQWctT49l/Di5UXs21kspcuIHnwSBTo8Mw+1MGrFMqCHvAuMynZSaukSafHNhiwdEAG7Q203yttXzOd19IKpQzo0HXVZjZcccOX95PqjJmzpQSVzBoguNzHYvgHSr3LWdCj4UYhzxZSupul6ZBelvsPYkxFJS3rMKUVRxJTC7+wgwNBeXZQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e672065a-80f0-41f0-23a3-08d6399d90ea X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2018 10:43:42.2634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1920 Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: fix metadata documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 10:43:44 -0000 > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, October 24, 2018 9:22 AM > To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com; olivier.matz@6wind.com; Adrien Mazarguil > ; Thomas Monjalon ; > ferruh.yigit@intel.com; arybchenko@solarflare.com > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > ; Dekel Peled > Subject: [dpdk-dev] [PATCH v2 2/2] ethdev: fix metadata documentation >=20 > Previous patch introduced the Tx metadata feature, with unnecessary > restrictions on data entry. >=20 > This fix updates the documentation, removing the data entry > restrictions on metadata item. >=20 > Fixes: aa0b9484eb5f ("ethdev: support metadata as flow rule criteria") > Cc: dekelp@mellanox.com >=20 > --- > v2: > Restore the correct 'mask' description. > --- >=20 > Signed-off-by: Dekel Peled > --- > doc/guides/prog_guide/rte_flow.rst | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index 6fb0535..5c5dd90 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1202,15 +1202,15 @@ Matches an application specific 32 bit metadata > item. >=20 > .. table:: META >=20 > - +----------+----------+-----------------------+ > - | Field | Subfield | Value | > - +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > - | ``spec`` | ``data`` | 32 bit metadata value | > - +----------+----------------------------------+ > - | ``last`` | ``data`` | ignored | > - +----------+----------+-----------------------+ > - | ``mask`` | ``data`` | ignored | > - +----------+----------+-----------------------+ > + +----------+----------+---------------------------------------+ > + | Field | Subfield | Value | > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > + | ``spec`` | ``data`` | 32 bit metadata value | > + +----------+--------------------------------------------------+ > + | ``last`` | ``data`` | upper range value | > + +----------+----------+---------------------------------------+ > + | ``mask`` | ``data`` | bit-mask applies to "spec" and "last" | > + +----------+----------+---------------------------------------+ >=20 > Actions > ~~~~~~~ > -- > 1.8.3.1 Acked-by: Ori Kam Thanks, Ori